59 lines
2.1 KiB
Diff
59 lines
2.1 KiB
Diff
|
From d179875e1025cbf0df3987a9c3b42a996eae5354 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
|
||
|
|
<congdanhqx@gmail.com>
|
||
|
|
Date: Sat, 23 Jan 2021 11:36:26 +0700
|
||
|
|
Subject: [PATCH 05/11] esp-list: allow external ESP again
|
||
|
|
|
||
|
|
In fwupd 1.5.1 and before, we allowed ESP on external device.
|
||
|
|
From 56d816a5, (Fall back to FAT32 internal partitions for detecting
|
||
|
|
ESP, 2020-11-11), we started to only consider internal devices only.
|
||
|
|
|
||
|
|
While it would be desirable to only consider internal devices for
|
||
|
|
fallback esp partition, there're some setup that put ESP on external
|
||
|
|
device, e.g. full disk encryption with /boot on a USB.
|
||
|
|
|
||
|
|
Let's allow external ESP again.
|
||
|
|
---
|
||
|
|
src/fu-tool.c | 6 ++++--
|
||
|
|
1 file changed, 4 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git src/fu-tool.c src/fu-tool.c
|
||
|
|
index 8624dfed..7c913f29 100644
|
||
|
|
--- src/fu-tool.c
|
||
|
|
+++ src/fu-tool.c
|
||
|
|
@@ -2431,6 +2431,7 @@ fu_util_prompt_for_volume (GError **error)
|
||
|
|
{
|
||
|
|
FuVolume *volume;
|
||
|
|
guint idx;
|
||
|
|
+ gboolean is_fallback = FALSE;
|
||
|
|
g_autoptr(GPtrArray) volumes = NULL;
|
||
|
|
g_autoptr(GPtrArray) volumes_vfat = g_ptr_array_new ();
|
||
|
|
g_autoptr(GError) error_local = NULL;
|
||
|
|
@@ -2438,6 +2439,7 @@ fu_util_prompt_for_volume (GError **error)
|
||
|
|
/* exactly one */
|
||
|
|
volumes = fu_common_get_volumes_by_kind (FU_VOLUME_KIND_ESP, &error_local);
|
||
|
|
if (volumes == NULL) {
|
||
|
|
+ is_fallback = TRUE;
|
||
|
|
g_debug ("%s, falling back to %s", error_local->message, FU_VOLUME_KIND_BDP);
|
||
|
|
volumes = fu_common_get_volumes_by_kind (FU_VOLUME_KIND_BDP, error);
|
||
|
|
if (volumes == NULL) {
|
||
|
|
@@ -2445,13 +2447,13 @@ fu_util_prompt_for_volume (GError **error)
|
||
|
|
return NULL;
|
||
|
|
}
|
||
|
|
}
|
||
|
|
- /* only add internal vfat partitions */
|
||
|
|
+ /* on fallback: only add internal vfat partitions */
|
||
|
|
for (guint i = 0; i < volumes->len; i++) {
|
||
|
|
FuVolume *vol = g_ptr_array_index (volumes, i);
|
||
|
|
g_autofree gchar *type = fu_volume_get_id_type (vol);
|
||
|
|
if (type == NULL)
|
||
|
|
continue;
|
||
|
|
- if (!fu_volume_is_internal (vol))
|
||
|
|
+ if (is_fallback && !fu_volume_is_internal (vol))
|
||
|
|
continue;
|
||
|
|
if (g_strcmp0 (type, "vfat") == 0)
|
||
|
|
g_ptr_array_add (volumes_vfat, vol);
|
||
|
|
--
|
||
|
|
2.29.2
|
||
|
|
|