Fix three cases of comparing pointer to a zero character, where pointers
were apparently intended to be dereferenced first and then compared.
Found with the help of GCC 7 warnings.
Remove unnecessary executable bits from the installed radiusd.service
file. This stops systemd from logging the following message:
localhost systemd: Configuration file
/usr/lib/systemd/system/radiusd.service is marked executable. Please
remove executable permission bits. Proceeding anyway.
Move "$INCLUDE trigger.conf" chunk before module section in
"radiusd.conf.in". This makes it possible to reference "snmptrap" and
related trigger variables under "pool.trigger" in module configurations,
simplifying them.
Resolves: Bug#1155961
Convert freeradius-postgres-sql.patch to git format. This makes all
patches conform to git format, which makes it easier to apply them to a
git repo. This simplifies current and further rebases.
Related: Bug#1120234
Don't remove backslash from unkown escape sequences in pairparsevalue,
adhering to behavior common to most other programs dealing with
backslash escape sequences.
Resolves: Bug#1173526
Remove attribute description from clients.conf(5) source as it is
outdated, lists just a few attributes and wasn't updated for more than a
year. Refer to clients.conf file itself, instead.
Remove references to non-existent naslist and clients manpages as they
are confusing.
Resolves: bug#1147464
Add support for -D option to radclient. The option allows overriding the
main dictionary directory location. This fixes the inability to fully
override dictionary locations introduced with
"freeradius-fix-dhcp-dictionary-loading.patch".
Related: Bug#1146939
This fixes the following Coverity issues:
Error: DEADCODE (CWE-561):
freeradius-server-3.0.4/src/main/conffile.c:1002: assignment: Assigning: "type" &= "255".
freeradius-server-3.0.4/src/main/conffile.c:1041: between: When switching on "type", the value of "type" must be between 0 and 255.
freeradius-server-3.0.4/src/main/conffile.c:1167: dead_error_condition: The switch value "type" cannot be "16385".
freeradius-server-3.0.4/src/main/conffile.c:1167: dead_error_line: Execution cannot reach this statement: "case 16385:".
Error: DEADCODE (CWE-561):
freeradius-server-3.0.4/src/main/conffile.c:1002: assignment: Assigning: "type" &= "255".
freeradius-server-3.0.4/src/main/conffile.c:1041: between: When switching on "type", the value of "type" must be between 0 and 255.
freeradius-server-3.0.4/src/main/conffile.c:1168: dead_error_condition: The switch value "type" cannot be "32769".
freeradius-server-3.0.4/src/main/conffile.c:1168: dead_error_begin: Execution cannot reach this statement: "case 32769:".
Resolves: Bug#1120234
This fixes the following Coverity issue:
Error: RETURN_LOCAL (CWE-562):
freeradius-server-3.0.4/src/modules/rlm_unix/rlm_unix.c:87: local_ptr_identity_local: "getgrnam_r(name, &my_group, group_buffer, group_size, &grp)" stores "&my_group" (address of local variable "my_group") into "grp".
freeradius-server-3.0.4/src/modules/rlm_unix/rlm_unix.c:99: return_local_addr_alias: Returning pointer "grp" which points to local variable "my_group".
Resolves: Bug#1120234
