rpms/freeipmi
6
0
Fork 0
Code Issues Pull Requests Releases Activity

Updated the spec file according to fedora-review tool complaints.

Browse Source 
- remove %clean
-remove %defattr
- use
- remove BuildRoot:
- use %global
This commit is contained in:
Jan Safranek 2012-08-27 10:57:21 +02:00
parent ba1e66b08d
commit 4a5acd48d2
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
freeipmi.spec
View File

@ -13,7 +13,6 @@ Source: http://ftp.gnu.org/gnu/freeipmi/%{name}-%{version}.tar.gz
Source1: bmc-watchdog.service Source1: bmc-watchdog.service
Source2: ipmidetectd.service Source2: ipmidetectd.service
Source3: ipmiseld.service Source3: ipmiseld.service
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: libgcrypt-devel texinfo systemd-units BuildRequires: libgcrypt-devel texinfo systemd-units
Requires(preun): info systemd-units Requires(preun): info systemd-units
Requires(post): info systemd-units systemd-sysv Requires(post): info systemd-units systemd-sysv
@ -55,7 +54,7 @@ Requires: freeipmi = %{version}-%{release}
IPMI SEL syslog logging daemon. IPMI SEL syslog logging daemon.
%if %{?_with_debug:1}%{!?_with_debug:0} %if %{?_with_debug:1}%{!?_with_debug:0}
%define _enable_debug --enable-debug --enable-trace --enable-syslog %global _enable_debug --enable-debug --enable-trace --enable-syslog
%endif %endif
%prep %prep
@ -70,9 +69,9 @@ make %{?_smp_mflags}
%install %install
rm -rf $RPM_BUILD_ROOT rm -rf $RPM_BUILD_ROOT
make install DESTDIR="$RPM_BUILD_ROOT" make install DESTDIR="$RPM_BUILD_ROOT"
rm -f %{buildroot}%{_infodir}/dir rm -rf $RPM_BUILD_ROOT%{_infodir}/dir
# kludge to get around rpmlint complaining about 0 length semephore file # kludge to get around rpmlint complaining about 0 length semephore file
echo freeipmi > %{buildroot}%{_localstatedir}/lib/freeipmi/ipckey echo freeipmi > $RPM_BUILD_ROOT%{_localstatedir}/lib/freeipmi/ipckey
# Remove .la files # Remove .la files
rm -rf $RPM_BUILD_ROOT/%{_libdir}/*.la rm -rf $RPM_BUILD_ROOT/%{_libdir}/*.la
# Install systemd units # Install systemd units
@ -81,9 +80,6 @@ install -m 644 %SOURCE1 %SOURCE2 %SOURCE3 $RPM_BUILD_ROOT/%{_unitdir}/
# Remove initscripts # Remove initscripts
rm -rf $RPM_BUILD_ROOT/%{_initrddir} $RPM_BUILD_ROOT/%{_sysconfdir}/init.d rm -rf $RPM_BUILD_ROOT/%{_initrddir} $RPM_BUILD_ROOT/%{_sysconfdir}/init.d
%clean
rm -rf $RPM_BUILD_ROOT
%post %post
/sbin/install-info %{_infodir}/freeipmi-faq.info.gz %{_infodir}/dir &>/dev/null || : /sbin/install-info %{_infodir}/freeipmi-faq.info.gz %{_infodir}/dir &>/dev/null || :
/sbin/ldconfig /sbin/ldconfig
@ -143,7 +139,6 @@ fi
/bin/systemctl try-restart ipmidetectd.service >/dev/null 2>&1 || : /bin/systemctl try-restart ipmidetectd.service >/dev/null 2>&1 || :
%files %files
%defattr(-,root,root)
%dir %{_sysconfdir}/freeipmi/ %dir %{_sysconfdir}/freeipmi/
%attr(0600,root,root) %config(noreplace) %{_sysconfdir}/freeipmi/freeipmi.conf %attr(0600,root,root) %config(noreplace) %{_sysconfdir}/freeipmi/freeipmi.conf
%attr(0600,root,root) %config(noreplace) %{_sysconfdir}/freeipmi/ipmidetect.conf %attr(0600,root,root) %config(noreplace) %{_sysconfdir}/freeipmi/ipmidetect.conf
@ -277,7 +272,6 @@ fi
%dir %{_localstatedir}/cache/ipmimonitoringsdrcache %dir %{_localstatedir}/cache/ipmimonitoringsdrcache
%files devel %files devel
%defattr(-,root,root)
%dir %{_datadir}/doc/%{name}/contrib/libipmimonitoring %dir %{_datadir}/doc/%{name}/contrib/libipmimonitoring
%doc %{_datadir}/doc/%{name}/contrib/libipmimonitoring/* %doc %{_datadir}/doc/%{name}/contrib/libipmimonitoring/*
%{_libdir}/libipmiconsole.so %{_libdir}/libipmiconsole.so
@ -327,7 +321,6 @@ fi
%{_libdir}/pkgconfig/* %{_libdir}/pkgconfig/*
%files bmc-watchdog %files bmc-watchdog
%defattr(-,root,root)
%doc %{_datadir}/doc/%{name}/COPYING.bmc-watchdog %doc %{_datadir}/doc/%{name}/COPYING.bmc-watchdog
%doc %{_datadir}/doc/%{name}/DISCLAIMER.bmc-watchdog %doc %{_datadir}/doc/%{name}/DISCLAIMER.bmc-watchdog
%doc %{_datadir}/doc/%{name}/DISCLAIMER.bmc-watchdog.UC %doc %{_datadir}/doc/%{name}/DISCLAIMER.bmc-watchdog.UC
@ -337,7 +330,6 @@ fi
%{_unitdir}/bmc-watchdog.service %{_unitdir}/bmc-watchdog.service
%files ipmidetectd %files ipmidetectd
%defattr(-,root,root)
%attr(0600,root,root) %config(noreplace) %{_sysconfdir}/freeipmi/ipmidetectd.conf %attr(0600,root,root) %config(noreplace) %{_sysconfdir}/freeipmi/ipmidetectd.conf
%{_sbindir}/ipmidetectd %{_sbindir}/ipmidetectd
%{_mandir}/man5/ipmidetectd.conf.5* %{_mandir}/man5/ipmidetectd.conf.5*
@ -345,7 +337,6 @@ fi
%{_unitdir}/ipmidetectd.service %{_unitdir}/ipmidetectd.service
%files ipmiseld %files ipmiseld
%defattr(-,root,root)
%doc %{_datadir}/doc/%{name}/COPYING.ipmiseld %doc %{_datadir}/doc/%{name}/COPYING.ipmiseld
%doc %{_datadir}/doc/%{name}/DISCLAIMER.ipmiseld %doc %{_datadir}/doc/%{name}/DISCLAIMER.ipmiseld
%{_unitdir}/ipmiseld.service %{_unitdir}/ipmiseld.service