From 9896afad2118e4552c63fe737590d61dbed0e945 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Tue, 14 Nov 2023 09:50:14 +0100 Subject: [PATCH] Disable %check Fedora's build environment runs inside a systemd-nspawn(1) container and runs into this test failure: ... ... Adding library /lib/libcap.so.2 Adding library /lib/libpcre2-8.so.0 Adding library /lib/libselinux.so.1 Adding library /lib/libtinfo.so.6 error: /tmp/tmp.ppnOBuhUOv/export/share/icons/hicolor/64x64/apps/org.test.Hello.png is not a valid icon: bwrap: Can't mount proc on /newroot/proc: Operation not permitted OK closing connection (test program exited with status code 1) ... which, otherwise, passes when run interactively on a Fedora Workstation 39 system. It is the 'flatpak build-export ...' call in tests/make-test-runtime.sh, which calls 'flatpak-validate-icon --sandbox' to validate the icons in a bwrap(1) sandbox. This used to work in the recent past, even with the build running inside a systemd-nspawn(1) container, but not anymore, likely because of other changes in the build environment. Therefore, there's no point in blocking flatpak-builder builds until the tests are fixed. https://src.fedoraproject.org/rpms/flatpak-builder/pull-request/4 --- flatpak-builder.spec | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/flatpak-builder.spec b/flatpak-builder.spec index f19bac8..939641f 100644 --- a/flatpak-builder.spec +++ b/flatpak-builder.spec @@ -84,8 +84,8 @@ This package contains the installable tests for %{name}. install -pm 644 NEWS README.md %{buildroot}/%{_pkgdocdir} -%check -%meson_test +# %%check +# %%meson_test %files @@ -104,6 +104,7 @@ install -pm 644 NEWS README.md %{buildroot}/%{_pkgdocdir} * Mon Nov 13 2023 Debarshi Ray - 1.3.4-1 - Update to 1.3.4 (#2212349) - Enable installed tests +- Disable %%check * Wed Jul 19 2023 Fedora Release Engineering - 1.3.3-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild