From 8c03510e80ba23c2a64c9fd86c651b5056749684 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Pokorn=C3=BD?= Date: Tue, 14 Aug 2018 15:54:53 +0200 Subject: [PATCH] - sanitize BuildRequires with respect to packaging guidelines MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In particular: * glibc-devel is not the way to declare that build time environment (toolchain) for C code is required -- in fact that gcc was present in the buildroot was an accidental side-effect of libtool requiring "gcc(major)" at particular version: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires * python3-devel package was not in BuildRequires despite the guidelines orders to do so: https://fedoraproject.org/wiki/Packaging:Python#Dependencies * collapse overly long BuildRequire line regarding Python packages into multiple ones Signed-off-by: Jan Pokorný --- fence-agents.spec | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/fence-agents.spec b/fence-agents.spec index c96709a..0ca8a94 100644 --- a/fence-agents.spec +++ b/fence-agents.spec @@ -82,11 +82,19 @@ EOF) %endif # Build dependencies -BuildRequires: glibc-devel -BuildRequires: gnutls-utils -BuildRequires: libxslt -BuildRequires: python3-pexpect python3-pycurl python3-suds python3-requests openwsman-python3 python3-boto3 python3-google-api-client +## general BuildRequires: autoconf automake libtool +## compiled code (-kdump) +BuildRequires: gcc +## man pages generating +BuildRequires: libxslt +## establishing proper paths to particular programs +BuildRequires: gnutls-utils +## Python dependencies +BuildRequires: python3-devel +BuildRequires: python3-pexpect python3-pycurl python3-requests +BuildRequires: python3-suds openwsman-python3 python3-boto3 +BuildRequires: python3-google-api-client %prep %setup -q -n %{name}-%{version} @@ -932,6 +940,7 @@ The fence-agents-zvm package contains a fence agent for IBM z/VM over IP. #- mark non-compiled packages properly as noarch, restructure excludes #- move azure_fence.py and XenAPI.py to respective subpackages from -common #- sanitize allfenceagents internally defined enumeration +#- sanitize BuildRequires with respect to packaging guidelines * Fri Jul 13 2018 Fedora Release Engineering - 4.2.1-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild