Resolves: #2054084 (ECompEditor: Timezone can be reset on component save)

evolution-3.40.4-comp-editor-timezone-reset.patch

@@ -0,0 +1,68 @@
+From 9bbb9289477c8a61a641b0b67cec367629f1e73a Mon Sep 17 00:00:00 2001
+From: Milan Crha <mcrha@redhat.com>
+Date: Thu, 10 Feb 2022 11:59:36 +0100
+Subject: [PATCH] ECompEditor: Timezone can be reset on component save
+
+The libical 3.0.14 contains a change, which unsets non-UTC timezones
+in date/time values. That uncovered a bug in the Evolution code, which
+expects the timezone will be preserved on re-read from the component,
+but it's not always possible. This is corrected by re-setting the timezone
+on the used ICalTime value.
+---
+ src/calendar/gui/e-comp-editor-property-part.c | 18 ++++++++++++++++++
+ 1 file changed, 18 insertions(+)
+
+diff --git a/src/calendar/gui/e-comp-editor-property-part.c b/src/calendar/gui/e-comp-editor-property-part.c
+index 6bed833b12..6ce699a2e6 100644
+--- a/src/calendar/gui/e-comp-editor-property-part.c
++++ b/src/calendar/gui/e-comp-editor-property-part.c
+@@ -913,8 +913,15 @@ ecepp_datetime_fill_component (ECompEditorPropertyPart *property_part,
+ 			g_object_unref (prop);
+ 		}
+ 	} else {
++		ICalTimezone *zone;
++
+ 		value = e_comp_editor_property_part_datetime_get_value (part_datetime);
+ 
++		zone = value && !i_cal_time_is_null_time (value) ? i_cal_time_get_timezone (value) : NULL;
++
++		if (zone)
++			g_object_ref (zone);
++
+ 		if (prop) {
+ 			/* Remove the VALUE parameter, to correspond to the actual value being set */
+ 			i_cal_property_remove_parameter_by_kind (prop, I_CAL_VALUE_PARAMETER);
+@@ -925,6 +932,11 @@ ecepp_datetime_fill_component (ECompEditorPropertyPart *property_part,
+ 			g_clear_object (&value);
+ 			value = klass->i_cal_get_func (prop);
+ 
++			/* The timezone can be dropped since libical 3.0.14, thus restore it
++			   before updating the TZID parameter */
++			if (zone && value && !i_cal_time_is_null_time (value) && !i_cal_time_is_date (value))
++				i_cal_time_set_timezone (value, zone);
++
+ 			cal_comp_util_update_tzid_parameter (prop, value);
+ 		} else {
+ 			prop = klass->i_cal_new_func (value);
+@@ -933,12 +945,18 @@ ecepp_datetime_fill_component (ECompEditorPropertyPart *property_part,
+ 			g_clear_object (&value);
+ 			value = klass->i_cal_get_func (prop);
+ 
++			/* The timezone can be dropped since libical 3.0.14, thus restore it
++			   before updating the TZID parameter */
++			if (zone && value && !i_cal_time_is_null_time (value) && !i_cal_time_is_date (value))
++				i_cal_time_set_timezone (value, zone);
++
+ 			cal_comp_util_update_tzid_parameter (prop, value);
+ 			i_cal_component_add_property (component, prop);
+ 		}
+ 
+ 		g_clear_object (&value);
+ 		g_clear_object (&prop);
++		g_clear_object (&zone);
+ 	}
+ }
+ 
+-- 
+2.33.1
+

evolution.spec

@@ -43,7 +43,7 @@
 
 Name: evolution
 Version: 3.40.4
-Release: 2%{?dist}
+Release: 3%{?dist}
 Summary: Mail and calendar client for GNOME
 License: GPLv2+ and GFDL
 URL: https://wiki.gnome.org/Apps/Evolution
@@ -53,6 +53,7 @@ Source2: flatpak-evolution-wrapper.sh.in
 Source3: emoji.data
 
 Patch01: evolution-3.40.4-empty-emoji-picker.patch
+Patch02: evolution-3.40.4-comp-editor-timezone-reset.patch
 
 # Approximate version number
 Provides: bundled(libgnomecanvas) = 2.30.0
@@ -568,6 +569,9 @@ grep -v "%{_datadir}/locale" evolution.lang > help.lang
 %endif
 
 %changelog
+* Mon Feb 14 2022 Milan Crha <mcrha@redhat.com> - 3.40.4-3
+- Resolves: #2054084 (ECompEditor: Timezone can be reset on component save)
+
 * Mon Oct 11 2021 Milan Crha <mcrha@redhat.com> - 3.40.4-2
 - Resolves: #2012701 (Empty emoji picker with gtk3 3.24.30)