Resolves: #2012701 (Empty emoji picker with gtk3 3.24.30)

This commit is contained in:
Milan Crha 2021-10-11 10:33:02 +02:00
parent f540e867ae
commit 3e1f4e0d36
4 changed files with 67 additions and 1 deletions

1
.gitignore vendored
View File

@ -1 +1,2 @@
/evolution-*.tar.xz /evolution-*.tar.xz
/emoji.data

View File

@ -0,0 +1,56 @@
From e75c4faa36a9eb17b88128e45f9e5d91628149f9 Mon Sep 17 00:00:00 2001
From: Milan Crha <mcrha@redhat.com>
Date: Mon, 4 Oct 2021 17:18:35 +0200
Subject: I#1646 - Emoji picker empty
Embed emoji.data as expected by the copy of the gtk+' emoji chooser dialog.
Closes https://gitlab.gnome.org/GNOME/evolution/-/issues/1646
diff --git a/data/org.gnome.Evolution.gresource.xml b/data/org.gnome.Evolution.gresource.xml
new file mode 100644
index 0000000000..783ed153b8
--- /dev/null
+++ b/data/org.gnome.Evolution.gresource.xml
@@ -0,0 +1,6 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<gresources>
+ <gresource prefix="org.gnome.Evolution">
+ <file>emoji.data</file>
+ </gresource>
+</gresources>
diff --git a/src/e-util/CMakeLists.txt b/src/e-util/CMakeLists.txt
index 03b60d8e4b..6f63f29858 100644
--- a/src/e-util/CMakeLists.txt
+++ b/src/e-util/CMakeLists.txt
@@ -30,6 +30,8 @@ if(WIN32)
)
endif(WIN32)
+glib_compile_resources(${CMAKE_SOURCE_DIR}/data/ ${CMAKE_CURRENT_BINARY_DIR}/org.gnome.Evolution.gresource org_gnome_evolution ../../data/org.gnome.Evolution.gresource.xml ${CMAKE_SOURCE_DIR}/data/emoji.data)
+
# Main libevolution-util
set(DEPENDENCIES
@@ -309,6 +311,8 @@ set(SOURCES
${PLATFORM_SOURCES}
${CMAKE_CURRENT_BINARY_DIR}/e-marshal.c
${CMAKE_CURRENT_BINARY_DIR}/e-util-enumtypes.c
+ ${CMAKE_CURRENT_BINARY_DIR}/org.gnome.Evolution.gresource.c
+ ${CMAKE_CURRENT_BINARY_DIR}/org.gnome.Evolution.gresource.h
)
set(HEADERS
diff --git a/src/e-util/e-gtkemojichooser.c b/src/e-util/e-gtkemojichooser.c
index ba4d15ecee..7d8aae3039 100644
--- a/src/e-util/e-gtkemojichooser.c
+++ b/src/e-util/e-gtkemojichooser.c
@@ -444,7 +444,7 @@ populate_emoji_chooser (gpointer data)
if (!chooser->data)
{
- bytes = g_resources_lookup_data ("/org/gtk/libgtk/emoji/emoji.data", 0, NULL);
+ bytes = g_resources_lookup_data ("/org.gnome.Evolution/emoji.data", 0, NULL);
chooser->data = g_variant_ref_sink (g_variant_new_from_bytes (G_VARIANT_TYPE ("a(auss)"), bytes, TRUE));
}

View File

@ -43,13 +43,16 @@
Name: evolution Name: evolution
Version: 3.40.4 Version: 3.40.4
Release: 1%{?dist} Release: 2%{?dist}
Summary: Mail and calendar client for GNOME Summary: Mail and calendar client for GNOME
License: GPLv2+ and GFDL License: GPLv2+ and GFDL
URL: https://wiki.gnome.org/Apps/Evolution URL: https://wiki.gnome.org/Apps/Evolution
Source: http://download.gnome.org/sources/%{name}/3.40/%{name}-%{version}.tar.xz Source: http://download.gnome.org/sources/%{name}/3.40/%{name}-%{version}.tar.xz
Source1: flatpak-evolution-fix-service-names.sh Source1: flatpak-evolution-fix-service-names.sh
Source2: flatpak-evolution-wrapper.sh.in Source2: flatpak-evolution-wrapper.sh.in
Source3: emoji.data
Patch01: evolution-3.40.4-empty-emoji-picker.patch
# Approximate version number # Approximate version number
Provides: bundled(libgnomecanvas) = 2.30.0 Provides: bundled(libgnomecanvas) = 2.30.0
@ -241,6 +244,8 @@ the functionality of the installed %{name} package.
%prep %prep
%autosetup -p1 -S gendiff %autosetup -p1 -S gendiff
cp %{S:3} data/
# Remove the welcome email from Novell # Remove the welcome email from Novell
for inbox in src/mail/default/*/Inbox; do for inbox in src/mail/default/*/Inbox; do
echo -n "" > $inbox echo -n "" > $inbox
@ -563,6 +568,9 @@ grep -v "%{_datadir}/locale" evolution.lang > help.lang
%endif %endif
%changelog %changelog
* Mon Oct 11 2021 Milan Crha <mcrha@redhat.com> - 3.40.4-2
- Resolves: #2012701 (Empty emoji picker with gtk3 3.24.30)
* Fri Aug 13 2021 Milan Crha <mcrha@redhat.com> - 3.40.4-1 * Fri Aug 13 2021 Milan Crha <mcrha@redhat.com> - 3.40.4-1
- Related: #1992450 (Update to 3.40.4) - Related: #1992450 (Update to 3.40.4)

View File

@ -1 +1,2 @@
SHA512 (evolution-3.40.4.tar.xz) = f6f08ab3cbc21397a0727b1edc5e37711294fdba6e537000d5a9f11f0142f69702fffad3922645fab256ccdee348b914a87abd0e6ed843c01762ccd32333518a SHA512 (evolution-3.40.4.tar.xz) = f6f08ab3cbc21397a0727b1edc5e37711294fdba6e537000d5a9f11f0142f69702fffad3922645fab256ccdee348b914a87abd0e6ed843c01762ccd32333518a
SHA512 (emoji.data) = c7d995ade74272ac2ff82555ea0fd99d4be3436c3cfc380c69f99cac8482322d1aa92779258907d0ab4a8fb85f27f16fecf11a1016747a7e98ae9b527be62dbe