From 385f7c160ae53c9555956a5cbd112b9a83d28766 Mon Sep 17 00:00:00 2001 From: Marek Kasik Date: Wed, 3 Mar 2021 18:24:02 +0100 Subject: [PATCH] Set page cache size with correct type Resolves: #1458845 --- ...et-page-cache-size-with-correct-type.patch | 39 +++++++++++++++++++ evince.spec | 8 +++- 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 0001-window-Set-page-cache-size-with-correct-type.patch diff --git a/0001-window-Set-page-cache-size-with-correct-type.patch b/0001-window-Set-page-cache-size-with-correct-type.patch new file mode 100644 index 0000000..ce7f11f --- /dev/null +++ b/0001-window-Set-page-cache-size-with-correct-type.patch @@ -0,0 +1,39 @@ +From e56653558be1cb8ab2411437bd411f5c1812d0aa Mon Sep 17 00:00:00 2001 +From: Marek Kasik +Date: Wed, 3 Mar 2021 17:15:58 +0100 +Subject: [PATCH] window: Set page cache size with correct type + +ev_view_set_page_cache_size() accepts gsize as its second parameter +but guint was passed in. This reduced maximal cache size considerably +as its size is 4 bytes. +Retyping the multiplication by "1024 * 1024" to gsize increases maximal +configurable cache size beyond 4 GiB. +--- + shell/ev-window.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/shell/ev-window.c b/shell/ev-window.c +index ba282e18..077d577d 100644 +--- a/shell/ev-window.c ++++ b/shell/ev-window.c +@@ -1554,7 +1554,7 @@ page_cache_size_changed (GSettings *settings, + + page_cache_mb = g_settings_get_uint (settings, GS_PAGE_CACHE_SIZE); + ev_view_set_page_cache_size (EV_VIEW (priv->view), +- page_cache_mb * 1024 * 1024); ++ (gsize) page_cache_mb * 1024 * 1024); + } + + static void +@@ -7636,7 +7636,7 @@ ev_window_init (EvWindow *ev_window) + page_cache_mb = g_settings_get_uint (ev_window_ensure_settings (ev_window), + GS_PAGE_CACHE_SIZE); + ev_view_set_page_cache_size (EV_VIEW (priv->view), +- page_cache_mb * 1024 * 1024); ++ (gsize) page_cache_mb * 1024 * 1024); + allow_links_change_zoom = g_settings_get_boolean (ev_window_ensure_settings (ev_window), + GS_ALLOW_LINKS_CHANGE_ZOOM); + ev_view_set_allow_links_change_zoom (EV_VIEW (priv->view), +-- +2.30.1 + diff --git a/evince.spec b/evince.spec index a00ab11..c04554a 100644 --- a/evince.spec +++ b/evince.spec @@ -6,13 +6,15 @@ Name: evince Version: 3.39.2 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Document viewer License: GPLv2+ and GPLv3+ and LGPLv2+ and MIT and Afmparse URL: https://wiki.gnome.org/Apps/Evince Source0: https://download.gnome.org/sources/%{name}/3.39/%{name}-%{version}.tar.xz +Patch0: 0001-window-Set-page-cache-size-with-correct-type.patch + BuildRequires: gcc-c++ BuildRequires: gcc BuildRequires: gettext-devel @@ -256,6 +258,10 @@ desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/org.gnome.Evince-p %{_mandir}/man1/evince-thumbnailer.1* %changelog +* Wed Mar 03 2021 Marek Kasik - 3.39.2-2 +- Set page cache size with correct type +- Resolves: #1458845 + * Wed Feb 17 2021 Kalev Lember - 3.39.2-1 - Update to 3.39.2