44 lines
1.6 KiB
Diff
44 lines
1.6 KiB
Diff
|
From b1b719573ff7410985fd502b3c30e6592229c3bd Mon Sep 17 00:00:00 2001
|
||
|
|
From: Oliver Steffen <osteffen@redhat.com>
|
||
|
|
Date: Mon, 4 Mar 2024 15:32:58 +0100
|
||
|
|
Subject: [PATCH] MdeModulePkg: Warn if out of flash space when writing
|
||
|
|
variables
|
||
|
|
|
||
|
|
RH-Author: Oliver Steffen <osteffen@redhat.com>
|
||
|
|
RH-MergeRequest: 65: MdeModulePkg: Warn if out of flash space when writing variables
|
||
|
|
RH-Jira: RHEL-45261
|
||
|
|
RH-Acked-by: Gerd Hoffmann <None>
|
||
|
|
RH-Commit: [1/1] b1f6ac49f246cc6a670b9fdd583da3bb9556550d (osteffen/edk2)
|
||
|
|
|
||
|
|
Emit a DEBUG_WARN message if there is not enough flash space left to
|
||
|
|
write/update a variable. This condition is currently not logged
|
||
|
|
appropriately in all cases, given that full variable store can easily
|
||
|
|
render the system unbootable.
|
||
|
|
This new message helps identifying this condition.
|
||
|
|
|
||
|
|
Signed-off-by: Oliver Steffen <osteffen@redhat.com>
|
||
|
|
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
|
||
|
|
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
|
||
|
|
(cherry picked from commit 80b59ff8320d1bd134bf689fe9c0ddf4e0473b88)
|
||
|
|
Signed-off-by: Oliver Steffen <osteffen@redhat.com>
|
||
|
|
---
|
||
|
|
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++
|
||
|
|
1 file changed, 2 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
|
||
|
|
index d394d237a5..1c7659031d 100644
|
||
|
|
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
|
||
|
|
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
|
||
|
|
@@ -2364,6 +2364,8 @@ Done:
|
||
|
|
);
|
||
|
|
ASSERT_EFI_ERROR (Status);
|
||
|
|
}
|
||
|
|
+ } else if (Status == EFI_OUT_OF_RESOURCES) {
|
||
|
|
+ DEBUG ((DEBUG_WARN, "UpdateVariable failed: Out of flash space\n"));
|
||
|
|
}
|
||
|
|
|
||
|
|
return Status;
|
||
|
|
--
|
||
|
|
2.39.3
|
||
|
|
|