73 lines
3.0 KiB
Diff
73 lines
3.0 KiB
Diff
|
From 6580637b33ef9b55b6dcfa8517e5933fb87b02d1 Mon Sep 17 00:00:00 2001
|
||
|
|
From: "Roth, Michael via groups.io" <Michael.Roth=amd.com@groups.io>
|
||
|
|
Date: Wed, 16 Aug 2023 15:11:45 -0500
|
||
|
|
Subject: [PATCH 20/20] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure
|
||
|
|
during boot
|
||
|
|
|
||
|
|
Booting an SEV guest with AmdSev OVMF package currently triggers the
|
||
|
|
following assertion with QEMU:
|
||
|
|
|
||
|
|
InstallQemuFwCfgTables: installed 7 tables
|
||
|
|
PcRtc: Write 0x20 to CMOS location 0x32
|
||
|
|
[Variable]END_OF_DXE is signaled
|
||
|
|
Initialize variable error flag (FF)
|
||
|
|
|
||
|
|
ASSERT_EFI_ERROR (Status = Not Found)
|
||
|
|
ASSERT [BdsDxe] /home/VT_BUILD/ovmf/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c(1711): !(((INTN)(RETURN_STATUS)(Status)) < 0)
|
||
|
|
|
||
|
|
This seems to be due to commit 81dc0d8b4c, which switched to using
|
||
|
|
PlatformBootManagerLib instead of PlatformBootManagerLibGrub. That pulls
|
||
|
|
in a dependency on gEfiS3SaveStateProtocolGuid provider being available
|
||
|
|
(which is asserted for in
|
||
|
|
BdsPlatform.c:PlatformBootManagerBeforeConsole()/SaveS3BootScript()),
|
||
|
|
but the libraries that provide it aren't currently included in the
|
||
|
|
build. Add them similarly to what's done for OvmfPkg.
|
||
|
|
|
||
|
|
Fixes: 81dc0d8b4c ("OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub")
|
||
|
|
Signed-off-by: Michael Roth <michael.roth@amd.com>
|
||
|
|
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
|
||
|
|
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
|
||
|
|
(cherry picked from commit f008890ae55929f7f17e7d2f8aff929255007d33)
|
||
|
|
---
|
||
|
|
OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++
|
||
|
|
OvmfPkg/AmdSev/AmdSevX64.fdf | 2 ++
|
||
|
|
2 files changed, 5 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
|
||
|
|
index 7f808126675f..49f6be3a079c 100644
|
||
|
|
--- a/OvmfPkg/AmdSev/AmdSevX64.dsc
|
||
|
|
+++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
|
||
|
|
@@ -200,6 +200,7 @@ [LibraryClasses]
|
||
|
|
|
||
|
|
SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
|
||
|
|
OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
|
||
|
|
+ S3BootScriptLib|MdeModulePkg/Library/PiDxeS3BootScriptLib/DxeS3BootScriptLib.inf
|
||
|
|
|
||
|
|
!include OvmfPkg/Include/Dsc/OvmfTpmLibs.dsc.inc
|
||
|
|
|
||
|
|
@@ -727,6 +728,8 @@ [Components]
|
||
|
|
#
|
||
|
|
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
|
||
|
|
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
|
||
|
|
+ MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
|
||
|
|
+ MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.inf
|
||
|
|
MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
|
||
|
|
|
||
|
|
#
|
||
|
|
diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
|
||
|
|
index 463bd3e9ef15..b2ab0c777320 100644
|
||
|
|
--- a/OvmfPkg/AmdSev/AmdSevX64.fdf
|
||
|
|
+++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
|
||
|
|
@@ -270,6 +270,8 @@ [FV.DXEFV]
|
||
|
|
|
||
|
|
INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
|
||
|
|
INF OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
|
||
|
|
+INF MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
|
||
|
|
+INF MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.inf
|
||
|
|
INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
|
||
|
|
|
||
|
|
INF FatPkg/EnhancedFatDxe/Fat.inf
|
||
|
|
--
|
||
|
|
2.41.0
|
||
|
|
|