From c7d158681fabdb3044bd213c332e489b46625a3b Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Mon, 24 Aug 2020 19:10:10 +0300 Subject: [PATCH] imap: Delay initializing client IO until client_create_finish() This helps writing unit tests. --- src/imap/imap-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/imap/imap-client.c b/src/imap/imap-client.c index 95e57dbf53..c8ffeafc43 100644 --- a/src/imap/imap-client.c +++ b/src/imap/imap-client.c @@ -143,7 +143,6 @@ struct client *client_create(int fd_in, int fd_out, o_stream_set_flush_callback(client->output, client_output, client); p_array_init(&client->module_contexts, client->pool, 5); - client->io = io_add_istream(client->input, client_input, client); client->last_input = ioloop_time; client->to_idle = timeout_add(CLIENT_IDLE_TIMEOUT_MSECS, client_idle_timeout, client); @@ -228,6 +227,7 @@ int client_create_finish(struct client *client, const char **error_r) return -1; mail_namespaces_set_storage_callbacks(client->user->namespaces, &mail_storage_callbacks, client); + client->io = io_add_istream(client->input, client_input, client); client->v.init(client); return 0;