From 957b2b25238d82a6c3afced2ff0423ad171fb22e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Men=C5=A1=C3=ADk?= Date: Fri, 3 Sep 2021 20:10:37 +0200 Subject: [PATCH 12/15] Fix coverity detected issues in cache.c Error: UNINIT (CWE-457): [#def27] dnsmasq-2.86test7/src/cache.c:1193: var_decl: Declaring variable "lrec" without initializer. dnsmasq-2.86test7/src/cache.c:1315: uninit_use_in_call: Using uninitialized value "lrec.ttd" when calling "make_non_terminals". # 1313| { # 1314| lrec.name.namep = txt->name; # 1315|-> make_non_terminals(&lrec); # 1316| } # 1317| Error: CLANG_WARNING: [#def29] dnsmasq-2.86test7/src/cache.c:1552:15: warning[core.uninitialized.Assign]: Assigned value is garbage or undefined # 1550| { # 1551| crecp->flags = (source->flags | F_NAMEP) & ~(F_IPV4 | F_IPV6 | F_CNAME | F_SRV | F_DNSKEY | F_DS | F_REVERSE); # 1552|-> crecp->ttd = source->ttd; # 1553| crecp->name.namep = name; # 1554| --- src/cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cache.c b/src/cache.c index 97c51a7..6722fa6 100644 --- a/src/cache.c +++ b/src/cache.c @@ -1188,7 +1188,7 @@ void cache_reload(void) struct host_record *hr; struct name_list *nl; struct cname *a; - struct crec lrec; + struct crec lrec = { 0, }; struct mx_srv_record *mx; struct txt_record *txt; struct interface_name *intr; -- 2.31.1