9abdc502cf
Rebased on top of additional commits staged for upstream
* Previous patches 0048-0060 are now patches 0053-0054 & 0059-0069
Add 0048-libmultipath-add-device-to-hwtable.c.patch
Add 0049-master-libmultipath-fix-use-after-free-when-iscsi-lo.patch
Add 0050-libmultipath-warn-if-freeing-path-that-holds-mpp-hwe.patch
Add 0051-libmultipath-warn-about-NULL-value-of-mpp-hwe.patch
Add 0052-libmultipath-fix-mpp-hwe-handling-in-sync_paths.patch
Add 0055-libmultipath-remove-code-duplication-in-path-countin.patch
Add 0056-libmultipath-count-pending-paths-as-active-on-loads.patch
Add 0057-libmultipath-deal-with-flushing-no-maps.patch
Add 0058-multipath-deal-with-delegation-failures-correctly.patch
Add 0070-multipath-add-libmpathvalid-library.patch
* adds the libmpathvalid.so library to determine if devices are
valid multipath paths.
Add 0071-libmultipath-add-uid-failback-for-dasd-devices.patch
Add 0072-libmultipath-add-ignore_udev_uid-option.patch
90 lines
2.5 KiB
Diff
90 lines
2.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Benjamin Marzinski <bmarzins@redhat.com>
|
|
Date: Tue, 19 May 2020 15:55:15 -0500
|
|
Subject: [PATCH] libmultipath: add uid failback for dasd devices
|
|
|
|
Add failback code to get the uid for dasd devices from sysfs. Copied
|
|
from dasdinfo
|
|
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
|
---
|
|
libmultipath/defaults.h | 1 +
|
|
libmultipath/discovery.c | 37 ++++++++++++++++++++++++++++++++++++-
|
|
2 files changed, 37 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h
|
|
index 984d8dd8..6a678a83 100644
|
|
--- a/libmultipath/defaults.h
|
|
+++ b/libmultipath/defaults.h
|
|
@@ -8,6 +8,7 @@
|
|
*/
|
|
#define DEFAULT_UID_ATTRIBUTE "ID_SERIAL"
|
|
#define DEFAULT_NVME_UID_ATTRIBUTE "ID_WWN"
|
|
+#define DEFAULT_DASD_UID_ATTRIBUTE "ID_UID"
|
|
#define DEFAULT_UDEVDIR "/dev"
|
|
#define DEFAULT_MULTIPATHDIR "/" LIB_STRING "/multipath"
|
|
#define DEFAULT_SELECTOR "service-time 0"
|
|
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
|
|
index aa5942c3..002d3d18 100644
|
|
--- a/libmultipath/discovery.c
|
|
+++ b/libmultipath/discovery.c
|
|
@@ -1920,12 +1920,44 @@ get_vpd_uid(struct path * pp)
|
|
return get_vpd_sysfs(parent, 0x83, pp->wwid, WWID_SIZE);
|
|
}
|
|
|
|
+/* based on code from s390-tools/dasdinfo/dasdinfo.c */
|
|
+static ssize_t dasd_get_uid(struct path *pp)
|
|
+{
|
|
+ struct udev_device *parent;
|
|
+ char value[80];
|
|
+ char *p;
|
|
+ int i;
|
|
+
|
|
+ parent = udev_device_get_parent_with_subsystem_devtype(pp->udev, "ccw",
|
|
+ NULL);
|
|
+ if (!parent)
|
|
+ return -1;
|
|
+
|
|
+ if (sysfs_attr_get_value(parent, "uid", value, 80) < 0)
|
|
+ return -1;
|
|
+
|
|
+ p = value - 1;
|
|
+ /* look for the 4th '.' and cut there */
|
|
+ for (i = 0; i < 4; i++) {
|
|
+ p = index(p + 1, '.');
|
|
+ if (!p)
|
|
+ break;
|
|
+ }
|
|
+ if (p)
|
|
+ *p = '\0';
|
|
+
|
|
+ return strlcpy(pp->wwid, value, WWID_SIZE);
|
|
+}
|
|
+
|
|
static ssize_t uid_fallback(struct path *pp, int path_state,
|
|
const char **origin)
|
|
{
|
|
ssize_t len = -1;
|
|
|
|
- if (pp->bus == SYSFS_BUS_SCSI) {
|
|
+ if (pp->bus == SYSFS_BUS_CCW) {
|
|
+ len = dasd_get_uid(pp);
|
|
+ *origin = "sysfs";
|
|
+ } else if (pp->bus == SYSFS_BUS_SCSI) {
|
|
len = get_vpd_uid(pp);
|
|
*origin = "sysfs";
|
|
if (len < 0 && path_state == PATH_UP) {
|
|
@@ -1970,6 +2002,9 @@ static bool has_uid_fallback(struct path *pp)
|
|
!strcmp(pp->uid_attribute, ""))) ||
|
|
(pp->bus == SYSFS_BUS_NVME &&
|
|
(!strcmp(pp->uid_attribute, DEFAULT_NVME_UID_ATTRIBUTE) ||
|
|
+ !strcmp(pp->uid_attribute, ""))) ||
|
|
+ (pp->bus == SYSFS_BUS_CCW &&
|
|
+ (!strcmp(pp->uid_attribute, DEFAULT_DASD_UID_ATTRIBUTE) ||
|
|
!strcmp(pp->uid_attribute, ""))));
|
|
}
|
|
|
|
--
|
|
2.17.2
|
|
|