9abdc502cf
Rebased on top of additional commits staged for upstream
* Previous patches 0048-0060 are now patches 0053-0054 & 0059-0069
Add 0048-libmultipath-add-device-to-hwtable.c.patch
Add 0049-master-libmultipath-fix-use-after-free-when-iscsi-lo.patch
Add 0050-libmultipath-warn-if-freeing-path-that-holds-mpp-hwe.patch
Add 0051-libmultipath-warn-about-NULL-value-of-mpp-hwe.patch
Add 0052-libmultipath-fix-mpp-hwe-handling-in-sync_paths.patch
Add 0055-libmultipath-remove-code-duplication-in-path-countin.patch
Add 0056-libmultipath-count-pending-paths-as-active-on-loads.patch
Add 0057-libmultipath-deal-with-flushing-no-maps.patch
Add 0058-multipath-deal-with-delegation-failures-correctly.patch
Add 0070-multipath-add-libmpathvalid-library.patch
* adds the libmpathvalid.so library to determine if devices are
valid multipath paths.
Add 0071-libmultipath-add-uid-failback-for-dasd-devices.patch
Add 0072-libmultipath-add-ignore_udev_uid-option.patch
34 lines
1.1 KiB
Diff
34 lines
1.1 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Martin Wilck <mwilck@suse.com>
|
|
Date: Mon, 13 Jul 2020 13:07:41 +0200
|
|
Subject: [PATCH] libmultipath: warn if freeing path that holds mpp->hwe
|
|
|
|
This just adds an error message to the previous patch.
|
|
|
|
Signed-off-by: Martin Wilck <mwilck@suse.com>
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
|
---
|
|
libmultipath/structs_vec.c | 5 ++++-
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c
|
|
index 430eaad7..cde4dbe6 100644
|
|
--- a/libmultipath/structs_vec.c
|
|
+++ b/libmultipath/structs_vec.c
|
|
@@ -93,8 +93,11 @@ int adopt_paths(vector pathvec, struct multipath *mpp)
|
|
void orphan_path(struct path *pp, const char *reason)
|
|
{
|
|
condlog(3, "%s: orphan path, %s", pp->dev, reason);
|
|
- if (pp->mpp && pp->mpp->hwe == pp->hwe)
|
|
+ if (pp->mpp && pp->hwe && pp->mpp->hwe == pp->hwe) {
|
|
+ condlog(0, "BUG: orphaning path %s that holds hwe of %s",
|
|
+ pp->dev, pp->mpp->alias);
|
|
pp->mpp->hwe = NULL;
|
|
+ }
|
|
pp->mpp = NULL;
|
|
pp->dmstate = PSTATE_UNDEF;
|
|
pp->uid_attribute = NULL;
|
|
--
|
|
2.17.2
|
|
|