From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Benjamin Marzinski Date: Mon, 16 Nov 2020 13:52:09 -0600 Subject: [PATCH] libmultipath: warn about missing braces at end of multipath.conf Multipath doesn't warn when multipath.conf is missing closing braces at the end of the file. This has confused people about the correct config file syntax, so add a warning. Signed-off-by: Benjamin Marzinski --- libmultipath/parser.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libmultipath/parser.c b/libmultipath/parser.c index a7285a35..48b54e87 100644 --- a/libmultipath/parser.c +++ b/libmultipath/parser.c @@ -544,7 +544,7 @@ process_stream(struct config *conf, FILE *stream, vector keywords, char *file) if (!strcmp(str, EOB)) { if (kw_level > 0) { free_strvec(strvec); - break; + goto out; } condlog(0, "unmatched '%s' at line %d of %s", EOB, line_nr, file); @@ -583,7 +583,8 @@ process_stream(struct config *conf, FILE *stream, vector keywords, char *file) free_strvec(strvec); } - + if (kw_level == 1) + condlog(1, "missing '%s' at end of %s", EOB, file); out: FREE(buf); free_uniques(uniques); -- 2.17.2