96 lines
2.6 KiB
Diff
96 lines
2.6 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
Date: Mon, 8 Jun 2020 20:23:56 -0500
|
||
|
|
Subject: [PATCH] libmultipath: fix parser issue with comments in strings
|
||
|
|
|
||
|
|
If a quoted string starts with '#' or '!', the parser will stop
|
||
|
|
parsing the line, thinking that it's a comment. It should only
|
||
|
|
be checking for comments outside of quoted strings. Fixed this and
|
||
|
|
added unit tests to verify it.
|
||
|
|
|
||
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
---
|
||
|
|
libmultipath/parser.c | 4 +++-
|
||
|
|
tests/parser.c | 42 ++++++++++++++++++++++++++++++++++++++++++
|
||
|
|
2 files changed, 45 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/libmultipath/parser.c b/libmultipath/parser.c
|
||
|
|
index a184511b..a7285a35 100644
|
||
|
|
--- a/libmultipath/parser.c
|
||
|
|
+++ b/libmultipath/parser.c
|
||
|
|
@@ -300,8 +300,10 @@ alloc_strvec(char *string)
|
||
|
|
(isspace((int) *cp) || !isascii((int) *cp)))
|
||
|
|
&& *cp != '\0')
|
||
|
|
cp++;
|
||
|
|
- if (*cp == '\0' || *cp == '!' || *cp == '#')
|
||
|
|
+ if (*cp == '\0' ||
|
||
|
|
+ (!in_string && (*cp == '!' || *cp == '#'))) {
|
||
|
|
return strvec;
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
out:
|
||
|
|
vector_free(strvec);
|
||
|
|
diff --git a/tests/parser.c b/tests/parser.c
|
||
|
|
index 29859dac..5772391e 100644
|
||
|
|
--- a/tests/parser.c
|
||
|
|
+++ b/tests/parser.c
|
||
|
|
@@ -440,6 +440,46 @@ static void test18(void **state)
|
||
|
|
free_strvec(v);
|
||
|
|
}
|
||
|
|
|
||
|
|
+static void test19(void **state)
|
||
|
|
+{
|
||
|
|
+#define QUOTED19 "!value"
|
||
|
|
+ vector v = alloc_strvec("key \"" QUOTED19 "\"");
|
||
|
|
+ char *val;
|
||
|
|
+
|
||
|
|
+ assert_int_equal(VECTOR_SIZE(v), 4);
|
||
|
|
+ assert_string_equal(VECTOR_SLOT(v, 0), "key");
|
||
|
|
+ assert_true(is_quote(VECTOR_SLOT(v, 1)));
|
||
|
|
+ assert_string_equal(VECTOR_SLOT(v, 2), QUOTED19);
|
||
|
|
+ assert_true(is_quote(VECTOR_SLOT(v, 3)));
|
||
|
|
+ assert_int_equal(validate_config_strvec(v, test_file), 0);
|
||
|
|
+
|
||
|
|
+ val = set_value(v);
|
||
|
|
+ assert_string_equal(val, QUOTED19);
|
||
|
|
+
|
||
|
|
+ free(val);
|
||
|
|
+ free_strvec(v);
|
||
|
|
+}
|
||
|
|
+
|
||
|
|
+static void test20(void **state)
|
||
|
|
+{
|
||
|
|
+#define QUOTED20 "#value"
|
||
|
|
+ vector v = alloc_strvec("key \"" QUOTED20 "\"");
|
||
|
|
+ char *val;
|
||
|
|
+
|
||
|
|
+ assert_int_equal(VECTOR_SIZE(v), 4);
|
||
|
|
+ assert_string_equal(VECTOR_SLOT(v, 0), "key");
|
||
|
|
+ assert_true(is_quote(VECTOR_SLOT(v, 1)));
|
||
|
|
+ assert_string_equal(VECTOR_SLOT(v, 2), QUOTED20);
|
||
|
|
+ assert_true(is_quote(VECTOR_SLOT(v, 3)));
|
||
|
|
+ assert_int_equal(validate_config_strvec(v, test_file), 0);
|
||
|
|
+
|
||
|
|
+ val = set_value(v);
|
||
|
|
+ assert_string_equal(val, QUOTED20);
|
||
|
|
+
|
||
|
|
+ free(val);
|
||
|
|
+ free_strvec(v);
|
||
|
|
+}
|
||
|
|
+
|
||
|
|
int test_config_parser(void)
|
||
|
|
{
|
||
|
|
const struct CMUnitTest tests[] = {
|
||
|
|
@@ -461,6 +501,8 @@ int test_config_parser(void)
|
||
|
|
cmocka_unit_test(test16),
|
||
|
|
cmocka_unit_test(test17),
|
||
|
|
cmocka_unit_test(test18),
|
||
|
|
+ cmocka_unit_test(test19),
|
||
|
|
+ cmocka_unit_test(test20),
|
||
|
|
};
|
||
|
|
return cmocka_run_group_tests(tests, setup, teardown);
|
||
|
|
}
|
||
|
|
--
|
||
|
|
2.17.2
|
||
|
|
|