31 lines
896 B
Diff
31 lines
896 B
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
Date: Mon, 30 Jul 2018 15:41:53 -0500
|
||
|
|
Subject: [PATCH] libmultipath: fix null dereference int alloc_path_group
|
||
|
|
|
||
|
|
If all_pathgroup failed to allocate a vector for pgp->paths, instead of
|
||
|
|
failing after it freed pgp, it would set pgp to NULL and then
|
||
|
|
dereference it. This patch fixes that. Found by coverity.
|
||
|
|
|
||
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
---
|
||
|
|
libmultipath/structs.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/libmultipath/structs.c b/libmultipath/structs.c
|
||
|
|
index ae847d6..caa178a 100644
|
||
|
|
--- a/libmultipath/structs.c
|
||
|
|
+++ b/libmultipath/structs.c
|
||
|
|
@@ -165,7 +165,7 @@ alloc_pathgroup (void)
|
||
|
|
|
||
|
|
if (!pgp->paths) {
|
||
|
|
FREE(pgp);
|
||
|
|
- pgp = NULL;
|
||
|
|
+ return NULL;
|
||
|
|
}
|
||
|
|
|
||
|
|
dm_pathgroup_to_gen(pgp)->ops = &dm_gen_pathgroup_ops;
|
||
|
|
--
|
||
|
|
2.7.4
|
||
|
|
|