From 768ce3965dcc9798e1a7dfd0de756ab159e04988 Mon Sep 17 00:00:00 2001 From: Kamil Dudka Date: Mon, 27 Jun 2022 17:00:18 +0200 Subject: [PATCH] test3026: disable valgrind It fails on x86_64 with: ``` Use --max-threads=INT to specify a larger number of threads and rerun valgrind valgrind: the 'impossible' happened: Max number of threads is too low host stacktrace: ==174357== at 0x58042F5A: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x58043087: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x580432EF: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x58043310: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x58099E77: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x580E67E9: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x5809D59D: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x5809901A: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x5809B0B6: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) ==174357== by 0x580E4050: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) sched status: running_tid=1 Thread 1: status = VgTs_Runnable syscall 56 (lwpid 174357) ==174357== at 0x4A07816: clone (in /usr/lib64/libc.so.6) ==174357== by 0x4A08720: __clone_internal (in /usr/lib64/libc.so.6) ==174357== by 0x4987ACF: create_thread (in /usr/lib64/libc.so.6) ==174357== by 0x49885F6: pthread_create@@GLIBC_2.34 (in /usr/lib64/libc.so.6) ==174357== by 0x1093B5: test.part.0 (lib3026.c:64) ==174357== by 0x492454F: (below main) (in /usr/lib64/libc.so.6) client stack range: [0x1FFEFFC000 0x1FFF000FFF] client SP: 0x1FFEFFC998 valgrind stack range: [0x1002BAA000 0x1002CA9FFF] top usage: 11728 of 1048576 [...] ``` --- 0102-curl-7.84.0-test3026.patch | 55 +++++++++++++++++++++++++++++++++ curl.spec | 4 +++ 2 files changed, 59 insertions(+) create mode 100644 0102-curl-7.84.0-test3026.patch diff --git a/0102-curl-7.84.0-test3026.patch b/0102-curl-7.84.0-test3026.patch new file mode 100644 index 0000000..d92ed07 --- /dev/null +++ b/0102-curl-7.84.0-test3026.patch @@ -0,0 +1,55 @@ +From 279b990727a1fd3e2828fbbd80581777e4200b67 Mon Sep 17 00:00:00 2001 +From: Kamil Dudka +Date: Mon, 27 Jun 2022 16:50:57 +0200 +Subject: [PATCH] test3026: disable valgrind + +It fails on x86_64 with: +``` + Use --max-threads=INT to specify a larger number of threads + and rerun valgrind + valgrind: the 'impossible' happened: + Max number of threads is too low + host stacktrace: + ==174357== at 0x58042F5A: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x58043087: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x580432EF: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x58043310: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x58099E77: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x580E67E9: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x5809D59D: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x5809901A: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x5809B0B6: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + ==174357== by 0x580E4050: ??? (in /usr/libexec/valgrind/memcheck-amd64-linux) + sched status: + running_tid=1 + Thread 1: status = VgTs_Runnable syscall 56 (lwpid 174357) + ==174357== at 0x4A07816: clone (in /usr/lib64/libc.so.6) + ==174357== by 0x4A08720: __clone_internal (in /usr/lib64/libc.so.6) + ==174357== by 0x4987ACF: create_thread (in /usr/lib64/libc.so.6) + ==174357== by 0x49885F6: pthread_create@@GLIBC_2.34 (in /usr/lib64/libc.so.6) + ==174357== by 0x1093B5: test.part.0 (lib3026.c:64) + ==174357== by 0x492454F: (below main) (in /usr/lib64/libc.so.6) + client stack range: [0x1FFEFFC000 0x1FFF000FFF] client SP: 0x1FFEFFC998 + valgrind stack range: [0x1002BAA000 0x1002CA9FFF] top usage: 11728 of 1048576 +[...] +``` +--- + tests/data/test3026 | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/tests/data/test3026 b/tests/data/test3026 +index fb80cc8..01f2ba5 100644 +--- a/tests/data/test3026 ++++ b/tests/data/test3026 +@@ -41,5 +41,8 @@ none + + 0 + ++ ++disable ++ + + +-- +2.35.3 + diff --git a/curl.spec b/curl.spec index ec7925b..405068d 100644 --- a/curl.spec +++ b/curl.spec @@ -13,6 +13,9 @@ Source2: mykey.asc # patch making libcurl multilib ready Patch101: 0101-curl-7.32.0-multilib.patch +# test3026: disable valgrind +Patch102: 0102-curl-7.84.0-test3026.patch + Provides: curl-full = %{version}-%{release} Provides: webclient URL: https://curl.se/ @@ -188,6 +191,7 @@ be installed. # Fedora patches %patch101 -p1 +%patch102 -p1 # disable test 1112 (#565305), test 1455 (occasionally fails with 'bind failed # with errno 98: Address already in use' in Koji environment), and test 1801