32 lines
1.0 KiB
Diff
32 lines
1.0 KiB
Diff
|
From ad9943254ded9a983af7d581e8a1f3317e8a8781 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Daniel Stenberg <daniel@haxx.se>
|
||
|
|
Date: Fri, 28 Sep 2018 16:08:16 +0200
|
||
|
|
Subject: [PATCH] Curl_auth_create_plain_message: fix too-large-input-check
|
||
|
|
|
||
|
|
CVE-2018-16839
|
||
|
|
Reported-by: Harry Sintonen
|
||
|
|
Bug: https://curl.haxx.se/docs/CVE-2018-16839.html
|
||
|
|
|
||
|
|
Upstream-commit: f3a24d7916b9173c69a3e0ee790102993833d6c5
|
||
|
|
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
|
||
|
|
---
|
||
|
|
lib/vauth/cleartext.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/lib/vauth/cleartext.c b/lib/vauth/cleartext.c
|
||
|
|
index 5d61ce6..1367143 100644
|
||
|
|
--- a/lib/vauth/cleartext.c
|
||
|
|
+++ b/lib/vauth/cleartext.c
|
||
|
|
@@ -74,7 +74,7 @@ CURLcode Curl_auth_create_plain_message(struct Curl_easy *data,
|
||
|
|
plen = strlen(passwdp);
|
||
|
|
|
||
|
|
/* Compute binary message length. Check for overflows. */
|
||
|
|
- if((ulen > SIZE_T_MAX/2) || (plen > (SIZE_T_MAX/2 - 2)))
|
||
|
|
+ if((ulen > SIZE_T_MAX/4) || (plen > (SIZE_T_MAX/2 - 2)))
|
||
|
|
return CURLE_OUT_OF_MEMORY;
|
||
|
|
plainlen = 2 * ulen + plen + 2;
|
||
|
|
|
||
|
|
--
|
||
|
|
2.17.2
|
||
|
|
|