From f5752bae78a4881fef6131fb61f5e48d681c9285 Mon Sep 17 00:00:00 2001
From: Zdenek Dohnal <zdohnal@redhat.com>
Date: Wed, 3 Nov 2021 08:00:13 +0100
Subject: [PATCH] 2018950 - Unauthenticated users can't move print jobs in Web
 UI

---
 ...ar.c-Use-guest-user-for-Move-Job-when-n.patch | 16 ++++++++++++++++
 cups.spec                                        |  9 ++++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 0001-cgi-bin-ipp-var.c-Use-guest-user-for-Move-Job-when-n.patch

diff --git a/0001-cgi-bin-ipp-var.c-Use-guest-user-for-Move-Job-when-n.patch b/0001-cgi-bin-ipp-var.c-Use-guest-user-for-Move-Job-when-n.patch
new file mode 100644
index 0000000..d2c0716
--- /dev/null
+++ b/0001-cgi-bin-ipp-var.c-Use-guest-user-for-Move-Job-when-n.patch
@@ -0,0 +1,16 @@
+diff --git a/cgi-bin/ipp-var.c b/cgi-bin/ipp-var.c
+index 92f1501..7edc058 100644
+--- a/cgi-bin/ipp-var.c
++++ b/cgi-bin/ipp-var.c
+@@ -275,10 +275,7 @@ cgiMoveJobs(http_t     *http,		/* I - Connection to server */
+   */
+ 
+   if ((user = getenv("REMOTE_USER")) == NULL)
+-  {
+-    puts("Status: 401\n");
+-    exit(0);
+-  }
++    user = "guest";
+ 
+  /*
+   * See if the user has already selected a new destination...
diff --git a/cups.spec b/cups.spec
index 2ea63b3..d4261ac 100644
--- a/cups.spec
+++ b/cups.spec
@@ -17,7 +17,7 @@ Summary: CUPS printing system
 Name: cups
 Epoch: 1
 Version: 2.3.3%{OP_VER}
-Release: 8%{?dist}
+Release: 9%{?dist}
 License: ASL 2.0
 Url: https://openprinting.github.io/cups/
 # Apple stopped uploading the new versions into github, use OpenPrinting fork
@@ -85,6 +85,8 @@ Patch17: 0001-Retry-Validate-Job-once-if-needed-Issue-132.patch
 Patch18: 0001-cups.service.in-Add-SYSTEMD_WANTED_BY-variable.patch
 # 1960170 - PreserveJobHistory/JobFiles aren't applied after the first cupsd restart right after successful print
 Patch19: cups-cleanfiles.patch
+# 2018950 - Unauthenticated users can't move print jobs in Web UI
+Patch20: 0001-cgi-bin-ipp-var.c-Use-guest-user-for-Move-Job-when-n.patch
 
 ##### Patches removed because IMHO they aren't no longer needed
 ##### but still I'll leave them in git in case their removal
@@ -298,6 +300,8 @@ to CUPS daemon. This solution will substitute printer drivers and raw queues in
 %patch18 -p1 -b .multiuser-target
 # 1960170 - PreserveJobHistory/JobFiles aren't applied after the first cupsd restart right after successful print
 %patch19 -p1 -b .cleanfiles
+# 2018950 - Unauthenticated users can't move print jobs in Web UI
+%patch20 -p1 -b .move-job
 
 
 %if %{lspp}
@@ -647,6 +651,9 @@ rm -f %{cups_serverbin}/backend/smb
 %{_mandir}/man7/ippeveps.7.gz
 
 %changelog
+* Wed Nov 03 2021 Zdenek Dohnal <zdohnal@redhat.com> - 1:2.3.3op2-9
+- 2018950 - Unauthenticated users can't move print jobs in Web UI
+
 * Wed Jul 21 2021 Fedora Release Engineering <releng@fedoraproject.org> - 1:2.3.3op2-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild