From c477b04aee34d4f4784c326ed715e91b2c43eb3e Mon Sep 17 00:00:00 2001 From: HATAYAMA Daisuke Date: Thu, 9 Dec 2021 01:05:07 +0000 Subject: [PATCH 2/3] defs.h: fix breakage of compatibility of struct machdep_table for extension modules Commit <2f967fb5ebd7> ("crash_taget: fetch_registers support") added new member get_cpu_reg in the middle of struct machdep_table, which breaks compatibility of struct machdep_table for extension modules. As the result, crash gcore command results in unexpected behavior, furthermore may cause segmentation fault. Fixes: 2f967fb5ebd7 ("crash_taget: fetch_registers support") Signed-off-by: HATAYAMA Daisuke --- defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defs.h b/defs.h index 7e2a16e34a59..7d3ed78fcd23 100644 --- a/defs.h +++ b/defs.h @@ -1013,7 +1013,6 @@ struct machdep_table { ulong (*processor_speed)(void); int (*uvtop)(struct task_context *, ulong, physaddr_t *, int); int (*kvtop)(struct task_context *, ulong, physaddr_t *, int); - int (*get_cpu_reg)(int, int, const char *, int, void *); ulong (*get_task_pgd)(ulong); void (*dump_irq)(int); void (*get_stack_frame)(struct bt_info *, ulong *, ulong *); @@ -1063,6 +1062,7 @@ struct machdep_table { void (*get_irq_affinity)(int); void (*show_interrupts)(int, ulong *); int (*is_page_ptr)(ulong, physaddr_t *); + int (*get_cpu_reg)(int, int, const char *, int, void *); }; /* -- 2.30.2