Commit Graph

1 Commits

Author SHA1 Message Date
HATAYAMA Daisuke
6949e5d561 coredump: fix building failure due to undefined macros MAPLE_TREE_{COUNT,GATHER}
Backport from the upstream crash-gcore.

commit 33f3c97f7d45c8bb1b43a8d551cb01a9873bb123
Author: HATAYAMA Daisuke <d.hatayama@fujitsu.com>
Date:   Tue Feb 28 03:59:16 2023 -0500

    coredump: fix building failure due to undefined macros MAPLE_TREE_{COUNT,GATHER}

    As of the commit 13794ace3830bf0274fe7b2e0e579ad72e31848f (coredump:
    fix failure of executing gcore command due to introduction of maple
    tree management on vma list), gcore.so fails to get built with the
    following error messages with defs.h without maple tree API support:

        libgcore/gcore_coredump.c:189:50: error: ‘MAPLE_TREE_COUNT’ undeclared (first use in this function); did you mean ‘RADIX_TREE_COUNT’?
          189 |                 entry_num = do_maple_tree(mm_mt, MAPLE_TREE_COUNT, NULL);
              |                                                  ^~~~~~~~~~~~~~~~
              |                                                  RADIX_TREE_COUNT
        libgcore/gcore_coredump.c:189:50: note: each undeclared identifier is reported only once for each function it appears in
        libgcore/gcore_coredump.c:191:38: error: ‘MAPLE_TREE_GATHER’ undeclared (first use in this function); did you mean ‘RADIX_TREE_GATHER’?
          191 |                 do_maple_tree(mm_mt, MAPLE_TREE_GATHER, entry_list);
              |                                      ^~~~~~~~~~~~~~~~~
              |                                      RADIX_TREE_GATHER

    This is caused by the missing macros MAPLE_TREE_COUNT and
    MAPLE_TREE_GATHER.

    To fix the issue, define the two macros within crash gcore so that
    build is successfully done expecting the resulting binary works well
    when it is ran against new crash utility that has maple tree API
    support.

    Signed-off-by: HATAYAMA Daisuke <d.hatayama@fujitsu.com>

Signed-off-by: HATAYAMA Daisuke <d.hatayama@fujitsu.com>
2023-03-01 05:25:27 +00:00