Commit Graph

5 Commits

Author SHA1 Message Date
Tom Stellard
f4a53e34d0 Fix missing inline function definition
The coreutils-i18n-expand-unexpand.patch adds 3 definitions of the
mbfile_multi_getc function.  2 of the definitions are marked with
the inline keyword, which means that there must also be an externally
visible definition.  The 3rd definition is marked extern inline, which statisfies
this requirement.  However, the 3rd definition is defined in mbfile.c
which is not compiled or linked in to any executable.  This causes build
failures if the compiler decides not to inline the function (which it is
allowed to do) e.g.

src/expand.c:153: undefined reference to `mbfile_multi_getc'

clang does not inline this function, but gcc does which is why
you will not see this failure when compiling with gcc.  However,
gcc could choose not to inline this, so even though the build succeeds,
it is depending on an implementation detail of gcc rather than the
C specification.

In order to fix this problem, mbfile.c was added to the list of sources for
any executable that uses mbfile_multi_getc.
2020-04-17 04:12:54 +00:00
Kamil Dudka
8d9eac4093 new upstream release 8.26 2016-12-01 19:14:56 +01:00
Kamil Dudka
d3849ced08 fix patches such that they apply without offset 2016-07-14 16:29:59 +02:00
Ondřej Vašík
7d9c9afa38 Initial commit for coreutils 8.25 ... still need to fix two failing tests before build (likely i18n stuff) 2016-01-20 16:43:39 +01:00
Ondrej Oprala
32b1e5a154 Use the new i18n implementation for expand/unexpand 2015-12-01 11:20:49 +01:00