Commit Graph

670 Commits

Author SHA1 Message Date
Kamil Dudka
9666248b72 Resolves: #1953669 - cp: pick additional copy_file_range()-related fixes
... from upstream
2021-05-17 18:52:48 +02:00
Kamil Dudka
18d8c0abc1 Related: #1953669 - embed coreutils-8.32-copy-swap.patch
... into coreutils-8.32-cp-file-range.patch

It is confusing when 1 patch out of 8 from the same patchset is kept
separately.
2021-05-17 16:35:15 +02:00
Kamil Dudka
ce3b866d19 changelog: forgot to mention public bug #1956080 2021-05-03 14:03:56 +02:00
Kamil Dudka
3a336cf37e Related: #1953669 - copy: ensure we enforce --reflink=never 2021-05-03 12:31:07 +02:00
Kamil Dudka
56555a47f2 Resolves: #1953669 - copy: do not refuse to copy a swap file 2021-04-27 10:35:48 +02:00
Kamil Dudka
e4decc2688 Resolves: #1947850 - weaken the dependency on glibc-doc
... to reduce minimal installations
2021-04-10 18:33:31 +02:00
Kamil Dudka
e680748e28 Related: #1830318 - drop the last use of ncurses no longer needed
We do not install or maintain /etc/DIR_COLORS.256color any more.
2021-04-10 18:33:31 +02:00
Kamil Dudka
32fb61705f Related: #1938695 - utimens: fix confusing arg type in internal func 2021-04-10 18:33:12 +02:00
Kamil Dudka
e3402b5fd4 Resolves: #1938695 - hostname,ln: fix memory leaks detected by Coverity 2021-03-26 14:01:53 +01:00
Kamil Dudka
1737e5c81f Resolves: #1730048 - cp: use copy_file_range if available 2021-03-24 16:09:51 +01:00
Kamil Dudka
6b50cb9fc4 Resolves: #1921427 - stat: add support for the exfat file system 2021-02-18 15:38:36 +01:00
Kamil Dudka
c822f6b1c0 Resolves: #959597 - make coreutils-common recommend glibc-doc
... for info doc refs
2021-02-03 17:05:57 +01:00
Kamil Dudka
4bd3080a00 Resolves: #1921249 - ls: fix crash printing SELinux context for unstatable files 2021-02-02 15:28:59 +01:00
Kamil Dudka
7afd521be2 Resolves: #1921246 - split: fix --number=K/N to output correct part of file 2021-02-02 15:28:19 +01:00
Kamil Dudka
d5245cc71c Resolves: #1919775 - expr: fix invalid read with unmatched \(...\) 2021-02-02 15:25:51 +01:00
Fedora Release Engineering
581c05ccb4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-01-26 02:34:09 +00:00
Kamil Dudka
44351906c7 coreutils.spec: keep BR list alphabetically sorted 2021-01-07 09:00:22 +01:00
Tom Stellard
f0b46ff947 Add BuildRequires: make
https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot
2020-12-19 05:23:46 +00:00
Kamil Dudka
1a18f20c40 Resolves: #1905481 - rm: do not skip files upon failure
... to remove an empty dir
2020-12-08 14:36:26 +01:00
Kamil Dudka
4af0c9fc89 df,stat,tail: recognize more file system types 2020-11-03 20:45:20 +01:00
Kamil Dudka
3a62768287 use upstream patch to eliminate unportable gnulib tests 2020-11-03 20:44:21 +01:00
Kamil Dudka
f4b85e63ba make the %build section idempotent
... so that we can run `fedpkg compile --short` repeatedly
2020-10-14 18:13:09 +02:00
Kamil Dudka
441f1d7519 Resolves: #1830318 - do not install /etc/DIR_COLORS.256color 2020-08-17 12:46:51 +02:00
Kamil Dudka
5d08d14bbc Resolves: #1861108 - cp: default to --reflink=auto 2020-07-30 17:36:08 +02:00
Fedora Release Engineering
fe6d386d13 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-07-27 14:35:30 +00:00
Kamil Dudka
27d47106a2 replace weirdo constant in gnulib tests
... causing test failures on armv7hl
2020-07-24 19:17:09 +02:00
Kamil Dudka
6d3ccf4f6f Related: #1789115 - disable -flto on ppc64le to make test-float pass 2020-07-24 19:16:16 +02:00
Kamil Dudka
fac4ffd39e fix the last change log entry 2020-07-24 19:15:28 +02:00
Tom Stellard
3426965b81 Use make macros
https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro
2020-07-13 18:53:32 +00:00
James Cassell
5d12163012 make ncurses optional 2020-06-26 03:19:47 -04:00
James Cassell
d72df4e29b ncurses is required by colorls.sh in coreutils-common
- colorls.sh uses tput from ncurses https://bugzilla.redhat.com/show_bug.cgi?id=469277
- colorls.sh was moved to -common package but the ncurses requirement
was not (in commit 5fb9bc4700 )
2020-06-26 02:45:57 -04:00
Kamil Dudka
1f6e0df263 compile with -Dlint to enable optional initialization and cleanup code
Upstream suggests to build with -Dlint for static analyzers:

    https://lists.gnu.org/archive/html/coreutils/2018-06/msg00110.html

... and even for production binary RPMs:

    https://lists.gnu.org/archive/html/bug-gnulib/2020-05/msg00130.html

There is currently no measurable performance drop or other known downside.
2020-05-15 19:19:05 +02:00
Kamil Dudka
bce50ab523 increase verbosity of the build
... so that compiler flags used for each compilation unit are visible
directly in the build log.
2020-05-15 19:19:05 +02:00
Kamil Dudka
2f7b3e0a8c Resolves: #1823247 - du: simplify leaf optimization for XFS 2020-04-23 15:07:37 +02:00
Tom Stellard
f4a53e34d0 Fix missing inline function definition
The coreutils-i18n-expand-unexpand.patch adds 3 definitions of the
mbfile_multi_getc function.  2 of the definitions are marked with
the inline keyword, which means that there must also be an externally
visible definition.  The 3rd definition is marked extern inline, which statisfies
this requirement.  However, the 3rd definition is defined in mbfile.c
which is not compiled or linked in to any executable.  This causes build
failures if the compiler decides not to inline the function (which it is
allowed to do) e.g.

src/expand.c:153: undefined reference to `mbfile_multi_getc'

clang does not inline this function, but gcc does which is why
you will not see this failure when compiling with gcc.  However,
gcc could choose not to inline this, so even though the build succeeds,
it is depending on an implementation detail of gcc rather than the
C specification.

In order to fix this problem, mbfile.c was added to the list of sources for
any executable that uses mbfile_multi_getc.
2020-04-17 04:12:54 +00:00
Kamil Dudka
d27f8523e2 uniq: remove collation handling as required by newer POSIX
Related upstream commit:
https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=8e81d44b5

Related Austin Group ticket:
https://www.austingroupbugs.net/view.php?id=963

Patch provided by Bernhard Voelker.
2020-03-11 14:20:22 +01:00
Kamil Dudka
9ed5d5b0f9 add missing BR for perl* needed for test-suite 2020-03-11 12:50:58 +01:00
Kamil Dudka
acfa9e81ec Resolves: #1811038 - make mknod work again in chroot
... without /proc being mounted
2020-03-11 10:42:02 +01:00
Kamil Dudka
44b7afa142 ls: restore 8.31 behavior on removed directories 2020-03-09 14:19:35 +01:00
Kamil Dudka
4a6bfcaa46 do not use IF_LINT for initialization of scalar variables
It triggers false positives in compilers and static analyzers
for no real benefit.
2020-03-05 18:02:07 +01:00
Kamil Dudka
b7eb17e7ee run tests/ls/removed-directory on x86_64 only for now 2020-03-05 17:51:56 +01:00
Kamil Dudka
eadc061798 ls: fix compilation failure on aarch64
Bug: https://debbugs.gnu.org/39929
2020-03-05 17:29:48 +01:00
Kamil Dudka
46d49783fe adapt DIR_COLORS patch for the new release
... and make it easier to maintain (by using sed for substitutions).
2020-03-05 16:51:13 +01:00
Kamil Dudka
00f87f4b88 new upstream release 8.32 2020-03-05 16:50:47 +01:00
Kamil Dudka
3dbfd57eac Resolves: #1800597 - make upstream test-suite work with root privileges 2020-02-11 10:36:16 +01:00
Kamil Dudka
3957dee9a4 use upstream fix the cp/proc-short-read test 2020-02-05 09:58:24 +01:00
Kamil Dudka
788bd804ff skip a test that relies on /proc/kallsyms having immutable content 2020-01-30 15:02:20 +01:00
Fedora Release Engineering
4f1cea8bda - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-01-28 14:49:55 +00:00
Kamil Dudka
664c64dec9 Revert "Resolves: #1760300 - use statx instead of stat when available"
This reverts commit 5cd3289cea because it
does not work well in containers hosted on RHEL-7, as reported in RHBZ:

    https://bugzilla.redhat.com/1760300#c5
2019-10-17 09:19:30 +02:00
Kamil Dudka
5cd3289cea Resolves: #1760300 - use statx instead of stat when available 2019-10-11 13:20:40 +02:00
Fedora Release Engineering
16fe71f18e - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-07-24 21:02:06 +00:00
Kamil Dudka
07291932a7 Resolves: #1728986 - disable flashing in ls colors for broken symbolic links 2019-07-16 13:04:35 +02:00
Kamil Dudka
2bc851a491 Resolves: #1688740 - fix formatting of sha512sum(1) man page 2019-03-18 13:49:13 +01:00
Kamil Dudka
5637e2b274 new upstream release 8.31 2019-03-11 12:25:47 +01:00
Fedora Release Engineering
30ec1629e9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-01-31 16:17:52 +00:00
Igor Gnatenko
df169bbdad Remove obsolete Group tag
References: https://fedoraproject.org/wiki/Changes/Remove_Group_Tag
2019-01-28 20:23:58 +01:00
Kamil Dudka
990cf47f04 sync: fix open() fallback bug
Detected by Coverity Analysis:

Error: RESOURCE_LEAK (CWE-772):
coreutils-8.30/src/sync.c:112: open_fn: Returning handle opened by "open". [Note: The source code implementation of the function has been overridden by a user model.]
coreutils-8.30/src/sync.c:112: var_assign: Assigning: "fd" = handle returned from "open(file, 2049)".
coreutils-8.30/src/sync.c:115: leaked_handle: Handle variable "fd" going out of scope leaks the handle.
113|         if (fd < 0)
114|           error (0, rd_errno, _("error opening %s"), quoteaf (file));
115|->       return false;
116|       }
117|

Bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33287
2018-11-07 16:04:59 +01:00
Kamil Dudka
d3d47dee12 fix implicit declaration warning in coreutils-getgrouplist.patch
Error: COMPILER_WARNING:
coreutils-8.30/lib/mgetgroups.c: scope_hint: In function 'mgetgroups'
coreutils-8.30/lib/mgetgroups.c:167:11: warning: implicit declaration of function 'xrealloc'; did you mean 'realloc'? [-Wimplicit-function-declaration]
     g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
         ^~~~~~~~
165|       {
166|         max_n_groups = ng;
167|->       g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
168|       }
169|       if (e == -1)
2018-11-07 15:54:23 +01:00
Kevin Fenzi
5decf6eab4 Also remove Requires pre/post used by info scriptlets. 2018-11-03 14:12:43 -07:00
Kevin Fenzi
9cc8a839e2 Remove no longer needed info scriptlets 2018-11-03 12:41:59 -07:00
Kamil Dudka
71b79ae180 Resolves: CVE-2018-17942 - fix heap-based buffer overflow in vasnprintf() 2018-10-11 14:39:54 +02:00
Kamil Dudka
7c7259b187 changelog: fix the last entry (version-release was missing) 2018-10-11 14:37:42 +02:00
Fedora Release Engineering
abb9bb783a - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-07-12 22:15:30 +00:00
Kamil Dudka
333a307888 Resolves: #1598518 - rename gnulib's renameat2 to renameatu to avoid clash with glibc 2018-07-10 15:04:21 +02:00
Bernhard Voelker
822c7685b5 sync i18n patches with Suse
- coreutils-i18n-suse-merge.patch:
  * src/exand.c,src/unexpand.c: Avoid -Wcomment warning.
  * src/cut.c (cut_characters_or_cut_bytes_no_split): Change idx from size_t
    to uintmax_t type to avoid a regression on i586, armv7l and ppc.
    Compare upstream, non-MB commit:
      https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=d1a754c8272
    (cut_fields_mb): Likewise for field_idx.
  * tests/misc/cut.pl: Remove downstream tweaks as upstream MB tests are
     working since a while.
2018-07-04 13:02:12 +02:00
Kamil Dudka
cf6dd7194c new upstream release 8.30 2018-07-02 11:42:58 +02:00
Kamil Dudka
a38fffab2a add provides to coreutils-single to make it a drop-in replacement 2018-05-30 09:37:32 +02:00
Kamil Dudka
44ebc66935 Resolves: #1577872 - ls: increase the allowed abmon width from 5 to 12 2018-05-29 17:02:58 +02:00
Kamil Dudka
79b09b54df Resolves: #1577872 - date, ls: pick strftime fixes from glibc to improve locale support 2018-05-28 17:48:34 +02:00
Kamil Dudka
dd90a0a24b Resolves: #1558249 - fix crash caused by mistakenly enabled leaf optimization 2018-04-20 17:19:41 +02:00
Kamil Dudka
36ef66d59d make it possible to install the latest available Adobe Reader RPM for Linux
This was recently broken by e9599c8226.
2018-03-23 17:39:38 +01:00
Kamil Dudka
359784bfb0 Related: #1555079 - drop BR for bison
... which is not used during the build
2018-03-19 19:21:48 +01:00
Kamil Dudka
d507a7b94c Resolves: #1555079 - make sure that parse-datetime.{c,y} ends up in debuginfo 2018-03-16 18:29:04 +01:00
Kamil Dudka
7995abc6ec fix build failure with glibc-2.28
Reported at:
https://lists.gnu.org/r/bug-gnulib/2018-03/msg00000.html

../lib/freadahead.c: In function 'freadahead':
../lib/freadahead.c:97:3: error: #error "Please port gnulib freadahead.c to your platform! Look at the definition of fflush, fread, ungetc on your system, then report this to bug-gnulib."
  #error "Please port gnulib freadahead.c to your platform! Look at the definition of fflush, fread, ungetc on your system, then report this to bug-gnulib."
   ^~~~~
../lib/freadahead.c:99:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[2]: *** [Makefile:9144: lib/freadahead.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../lib/freadptr.c: In function 'freadptr':
../lib/freadptr.c:119:3: error: #error "Please port gnulib freadptr.c to your platform! Look at the definition of fflush, fread, getc, getc_unlocked on your system, then report this to bug-gnulib."
  #error "Please port gnulib freadptr.c to your platform! Look at the definition of fflush, fread, getc, getc_unlocked on your system, then report this to bug-gnulib."
   ^~~~~
../lib/freadptr.c:29:10: warning: unused variable 'size' [-Wunused-variable]
   size_t size;
          ^~~~
../lib/freadptr.c:121:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
2018-03-06 12:44:50 +01:00
Igor Gnatenko
e9599c8226
Remove /bin/* Provides
UsrMove happened more than 10 Fedora releases ago.

Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-26 11:21:05 +01:00
Kamil Dudka
4a8582e246 add explicit BR for the gcc compiler
... as instructed at:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
2018-02-19 16:23:12 +01:00
Fedora Release Engineering
5d3dc8fdbd - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-02-07 05:45:49 +00:00
Kamil Dudka
fd470b54bc Resolves: CVE-2017-18018 - doc: warn about following symlinks recursively in chown/chgrp 2018-01-23 16:55:04 +01:00
Kamil Dudka
79fe59c7fc mv -n: do not overwrite the destination 2018-01-23 16:42:41 +01:00
Kamil Dudka
d51b521e30 avoid test-suite failure if SELinux is disabled 2018-01-02 15:27:54 +01:00
Kamil Dudka
7effe141a5 add BR for hostname
... to avoid the following build-time message:

./configure: line 7463: hostname: command not found
2018-01-02 15:27:41 +01:00
Kamil Dudka
0cb3deb32b new upstream release 8.29 2018-01-02 15:25:24 +01:00
Igor Gnatenko
02030dc915 Remove very old Provides (mktemp, sh-utils, textwrap, fileutils, stat)
Those are gone in fc9, more than decade ago.

Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2017-11-07 16:44:31 +01:00
Kamil Dudka
2d00e2bb9a new upstream release 8.28 2017-09-04 11:43:42 +02:00
Ville Skyttä
3490621545 Own the %{_libexecdir}/coreutils dir
According to Fedora Packaging Guidelines, packages must own all
directories they put files in.

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1483938
2017-08-22 12:52:05 +02:00
Kamil Dudka
d2d5d5d057 Resolves: #1482445 - ptx: fix a possible crash caused by integer overflow 2017-08-18 17:52:50 +02:00
Fedora Release Engineering
353860c35c - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild 2017-08-02 19:11:06 +00:00
Igor Gnatenko
8401ff18e3 Enable separate debuginfo back
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2017-07-28 19:42:43 +02:00
Kamil Dudka
28658db744 avoid build failure caused broken RPM code
... that produces debuginfo packages

Bug: https://github.com/rpm-software-management/rpm/issues/280
2017-07-26 17:04:53 +02:00
Fedora Release Engineering
8fd1881fe2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild 2017-07-26 05:30:55 +00:00
Sebastian Kisela
8d02212742 doc: mention setpriv --no-new-privs feature in runcon info
* doc/coreutils.texi (runcon invocation): Mention setpriv usage.
Discussed at https://bugzilla.redhat.com/1360903
2017-05-30 09:39:28 +02:00
Kamil Dudka
6f16afd4a6 add coreutils-full provides for coreutils
... to make it explicitly installable
2017-05-16 14:15:41 +02:00
Kamil Dudka
fde94e2609 Related: #158405 - drop coreutils-overflow.patch no longer needed
The bug was fixed by the following upstream commit 13 years ago:

http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=COREUTILS-5_2_1-705-g5bca9fb
2017-05-03 15:49:04 +02:00
Kamil Dudka
34aa759415 Related: #1306559 - drop workaround for already fixed rpm-build bug 2017-05-03 14:17:50 +02:00
Kamil Dudka
28873d6a70 do not mention a deprecated option in localized man pages 2017-05-03 13:13:22 +02:00
Kamil Dudka
e0b67f5aa9 Related: #246729 - drop workaround no longer needed for 10 years old rpm-build bug 2017-05-03 13:13:22 +02:00
Kamil Dudka
b9d157d0ce drop unnecessary uses of %defattr 2017-05-03 13:13:18 +02:00
Sebastian Kisela
e00cb1843f tail: revert to polling if a followed directory is replaced (#1283760) 2017-04-28 12:48:03 +02:00
Kamil Dudka
e0567d54a7 Resolves: CVE-2017-7476 - date, touch: fix out-of-bounds write via large TZ variable 2017-04-27 09:51:08 +02:00
Kamil Dudka
3d65658099 Resolves: #1444802 - do not obsolete coreutils-single, so it can be installed by DNF2
This reverts commit c553cab787.
2017-04-25 13:44:32 +02:00