From a043a83424ce03e052faa04cb0b07edf045e9121 Mon Sep 17 00:00:00 2001
From: Martin Pitt <martin@piware.de>
Date: Sun, 14 Jun 2020 16:13:00 +0200
Subject: [PATCH] tests: Use run-tests for everything

Cockpit 221 fixed storage test classes to all have different names, so
the "TestStorage" pattern now catches them all.

Also move the `image-download cirros` to simplify conditional blocks.
---
 tests/run-test.sh | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/tests/run-test.sh b/tests/run-test.sh
index 6c32810..6c5da00 100755
--- a/tests/run-test.sh
+++ b/tests/run-test.sh
@@ -20,11 +20,6 @@ fi
 cd "$SOURCE"
 git clone --depth=1 https://github.com/cockpit-project/bots
 
-if [ -n "$test_optional" ]; then
-    # pre-download cirros image for Machines tests
-    bots/image-download cirros
-fi
-
 # only install a subset to save time/space
 npm install axe-core chrome-remote-interface sizzle
 
@@ -39,6 +34,9 @@ fi
 TESTS=""
 RC=0
 if [ -n "$test_optional" ]; then
+    # pre-download cirros image for Machines tests
+    bots/image-download cirros
+
     # some tests are still too unstable: testCreate,testNetworkSettings,testVmNICs
     # testAddDisk triggers SELinux violation
     TESTS="$TESTS
@@ -50,16 +48,8 @@ if [ -n "$test_optional" ]; then
     # not all classes are nondestructive, and we can't run rebooting tests
     TESTS="$TESTS
          TestUpdates.test{Basic,SecurityOnly}
-         TestAutoUpdates"
-
-    # FIXME: storage test classes are all called TestStorage, doesn't work with run-tests selection
-    for t in storage-basic \
-             storage-ignored \
-             storage-partitions \
-             storage-used \
-             storage-lvm2; do
-        test/verify/check-$t -tv --machine localhost:22 --browser localhost:9090 || RC=$?
-    done
+         TestAutoUpdates
+         TestStorage"
 fi
 
 if [ -n "$test_basic" ]; then