From 12cf08914b741472a4e7e20444035fe7baed7b85 Mon Sep 17 00:00:00 2001
From: Martin Pitt <martin@piware.de>
Date: Mon, 23 Mar 2020 12:15:45 +0100
Subject: [PATCH] tests: Run more browser tests

Upstream now grows more and more @nondestructive test, which we can run
in our single test VM, so add the first batch.

This uncovers some issues in the tests that assume that there is no root
login in the VM, skip them. They are being fixed in
https://github.com/cockpit-project/cockpit/pull/13773
---
 tests/tests.yml |  2 ++
 tests/verify.sh | 13 +++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/tests/tests.yml b/tests/tests.yml
index 893af8c..c39eb8a 100644
--- a/tests/tests.yml
+++ b/tests/tests.yml
@@ -13,6 +13,8 @@
     - cockpit
     - cockpit-tests
     - cockpit-dashboard
+    - cockpit-sosreport
+    - cockpit-storaged
     - podman
     tests:
     - smoke:
diff --git a/tests/verify.sh b/tests/verify.sh
index 6c61cc6..0e33a39 100755
--- a/tests/verify.sh
+++ b/tests/verify.sh
@@ -11,7 +11,7 @@ chcon -Rt container_file_t "$SOURCE" "$LOGS"
 
 # create user account for logging in
 if ! id admin 2>/dev/null; then
-    useradd admin -G wheel
+    useradd -c Administrator -G wheel admin
     echo admin:foobar | chpasswd
 fi
 
@@ -40,7 +40,16 @@ cp -a /source/test .
 npm install axe-core chrome-remote-interface sizzle
 
 export TEST_OS=fedora-32
-test/verify/check-menu -tv --machine \$HOST:22 --browser \$HOST:9090
+export TEST_AUDIT_NO_SELINUX=1
+
+# FIXME: Test{Accounts,Login}.testBasic don't get along with the existing root session (https://github.com/cockpit-project/cockpit/pull/13773)
+test/verify/check-accounts -tv --machine \$HOST:22 --browser \$HOST:9090 TestAccounts.{testRootLogin,testUnprivileged}
+test/verify/check-login -tv --machine \$HOST:22 --browser \$HOST:9090 TestLogin.{testExpired,testSELinuxRestrictedUser}
+
+# check-menu is not @nondestructive yet, keep it last
+for t in sosreport storage-basic menu; do
+    test/verify/check-\$t -tv --machine \$HOST:22 --browser \$HOST:9090
+done
 EOF
 
 # reset system changes from verify tests, for running this multiple times in a row