284 lines
9.4 KiB
Diff
284 lines
9.4 KiB
Diff
From 9eb7ef217eb03131904fb6e0c692130126334f52 Mon Sep 17 00:00:00 2001
|
|
From: Ani Sinha <anisinha@redhat.com>
|
|
Date: Fri, 23 Jun 2023 16:54:24 +0530
|
|
Subject: [PATCH] test fixes: remove NM_CONTROLLED=no from tests
|
|
|
|
X-downstream-only: true
|
|
fixes: b3b96bff187e9 ("Do not write NM_CONTROLLED=no in generated interface config files")
|
|
|
|
Signed-off-by: Ani Sinha <anisinha@redhat.com>
|
|
---
|
|
tests/unittests/cmd/devel/test_net_convert.py | 1 -
|
|
tests/unittests/distros/test_netconfig.py | 8 -------
|
|
tests/unittests/test_net.py | 23 -------------------
|
|
3 files changed, 32 deletions(-)
|
|
|
|
diff --git a/tests/unittests/cmd/devel/test_net_convert.py b/tests/unittests/cmd/devel/test_net_convert.py
|
|
index 43e879f7..082e9656 100644
|
|
--- a/tests/unittests/cmd/devel/test_net_convert.py
|
|
+++ b/tests/unittests/cmd/devel/test_net_convert.py
|
|
@@ -63,7 +63,6 @@ SAMPLE_SYSCONFIG_CONTENT = """\
|
|
AUTOCONNECT_PRIORITY=120
|
|
BOOTPROTO=dhcp
|
|
DEVICE=eth0
|
|
-NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
diff --git a/tests/unittests/distros/test_netconfig.py b/tests/unittests/distros/test_netconfig.py
|
|
index eaf723c8..7ac8182a 100644
|
|
--- a/tests/unittests/distros/test_netconfig.py
|
|
+++ b/tests/unittests/distros/test_netconfig.py
|
|
@@ -724,7 +724,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
GATEWAY=192.168.1.254
|
|
IPADDR=192.168.1.5
|
|
NETMASK=255.255.255.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -735,7 +734,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
AUTOCONNECT_PRIORITY=120
|
|
BOOTPROTO=dhcp
|
|
DEVICE=eth1
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -767,7 +765,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
IPV6_AUTOCONF=no
|
|
IPV6_DEFAULTGW=2607:f0d0:1002:0011::1
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -778,7 +775,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
AUTOCONNECT_PRIORITY=120
|
|
BOOTPROTO=dhcp
|
|
DEVICE=eth1
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -826,7 +822,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
HWADDR=00:16:3e:60:7c:df
|
|
IPADDR=192.10.1.2
|
|
NETMASK=255.255.255.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -839,7 +834,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
DEVICE=infra0
|
|
IPADDR=10.0.1.2
|
|
NETMASK=255.255.0.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
PHYSDEV=eth0
|
|
USERCTL=no
|
|
@@ -876,7 +870,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
DEVICE=eth0
|
|
IPADDR=192.10.1.2
|
|
NETMASK=255.255.255.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -889,7 +882,6 @@ class TestNetCfgDistroRedhat(TestNetCfgDistroBase):
|
|
DEVICE=eth0.1001
|
|
IPADDR=10.0.1.2
|
|
NETMASK=255.255.0.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
PHYSDEV=eth0
|
|
USERCTL=no
|
|
diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py
|
|
index 1261840b..fd656a57 100644
|
|
--- a/tests/unittests/test_net.py
|
|
+++ b/tests/unittests/test_net.py
|
|
@@ -1502,7 +1502,6 @@ NETWORK_CONFIGS = {
|
|
DHCPV6C=yes
|
|
IPV6INIT=yes
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1594,7 +1593,6 @@ NETWORK_CONFIGS = {
|
|
IPV6INIT=yes
|
|
IPV6_FORCE_ACCEPT_RA=yes
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1671,7 +1669,6 @@ NETWORK_CONFIGS = {
|
|
IPV6INIT=yes
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1736,7 +1733,6 @@ NETWORK_CONFIGS = {
|
|
IPV6_AUTOCONF=yes
|
|
IPV6INIT=yes
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1792,7 +1788,6 @@ NETWORK_CONFIGS = {
|
|
IPV6_AUTOCONF=no
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1850,7 +1845,6 @@ NETWORK_CONFIGS = {
|
|
IPV6_AUTOCONF=yes
|
|
IPV6INIT=yes
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1933,7 +1927,6 @@ NETWORK_CONFIGS = {
|
|
IPV6_AUTOCONF=no
|
|
IPV6_FORCE_ACCEPT_RA=yes
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -1975,7 +1968,6 @@ NETWORK_CONFIGS = {
|
|
AUTOCONNECT_PRIORITY=120
|
|
BOOTPROTO=dhcp
|
|
DEVICE=iface0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -2053,7 +2045,6 @@ NETWORK_CONFIGS = {
|
|
BOOTPROTO=dhcp
|
|
DEVICE=iface0
|
|
ETHTOOL_OPTS="wol g"
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -2530,7 +2521,6 @@ pre-down route del -net 10.0.0.0/8 gw 11.0.0.1 metric 3 || true
|
|
IPADDR=192.168.200.7
|
|
MTU=9000
|
|
NETMASK=255.255.255.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=InfiniBand
|
|
USERCTL=no"""
|
|
@@ -3609,7 +3599,6 @@ iface bond0 inet6 static
|
|
IPV6INIT=yes
|
|
IPV6_AUTOCONF=no
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -3626,7 +3615,6 @@ iface bond0 inet6 static
|
|
IPV6INIT=yes
|
|
IPV6_AUTOCONF=no
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -3920,7 +3908,6 @@ iface bond0 inet6 static
|
|
BOOTPROTO=none
|
|
DEVICE=eth0
|
|
HWADDR=cf:d6:af:48:e8:80
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no"""
|
|
@@ -4759,7 +4746,6 @@ HWADDR=fa:16:3e:25:b4:59
|
|
IPADDR=51.68.89.122
|
|
MTU=1500
|
|
NETMASK=255.255.240.0
|
|
-NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -4774,7 +4760,6 @@ DEVICE=eth1
|
|
DHCLIENT_SET_DEFAULT_ROUTE=no
|
|
HWADDR=fa:16:3e:b1:ca:29
|
|
MTU=9000
|
|
-NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -5027,7 +5012,6 @@ USERCTL=no
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
IPV6_DEFAULTGW=2001:db8::1
|
|
NETMASK=255.255.255.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -5060,7 +5044,6 @@ USERCTL=no
|
|
AUTOCONNECT_PRIORITY=120
|
|
BOOTPROTO=none
|
|
DEVICE=eno1
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -5074,7 +5057,6 @@ USERCTL=no
|
|
IPADDR=192.6.1.9
|
|
MTU=1495
|
|
NETMASK=255.255.255.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
PHYSDEV=eno1
|
|
USERCTL=no
|
|
@@ -5111,7 +5093,6 @@ USERCTL=no
|
|
IPADDR=10.101.8.65
|
|
MTU=1334
|
|
NETMASK=255.255.255.192
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Bond
|
|
USERCTL=no
|
|
@@ -5124,7 +5105,6 @@ USERCTL=no
|
|
BOOTPROTO=none
|
|
DEVICE=enp0s0
|
|
MASTER=bond0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
SLAVE=yes
|
|
TYPE=Bond
|
|
@@ -5138,7 +5118,6 @@ USERCTL=no
|
|
BOOTPROTO=none
|
|
DEVICE=enp0s1
|
|
MASTER=bond0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
SLAVE=yes
|
|
TYPE=Bond
|
|
@@ -5170,7 +5149,6 @@ USERCTL=no
|
|
DEVICE=eno1
|
|
HWADDR=07-1c-c6-75-a4-be
|
|
METRIC=100
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|
|
@@ -5262,7 +5240,6 @@ USERCTL=no
|
|
IPV6_FORCE_ACCEPT_RA=no
|
|
MTU=1400
|
|
NETMASK=255.255.248.0
|
|
- NM_CONTROLLED=no
|
|
ONBOOT=yes
|
|
TYPE=Ethernet
|
|
USERCTL=no
|