import clang-13.0.0-2.module+el8.6.0+13046+42aaae31

.clang.metadata

@@ -1,3 +1,3 @@
-e3cdd3fb39c78a5bcb0a1d5706678cf8643a48f6 SOURCES/clang-12.0.1.src.tar.xz
+c071f016b5e8965a52cea4f0905924aaf5495d49 SOURCES/clang-13.0.0.src.tar.xz
-42f179bb59432c4d2785239952853ad6308d0863 SOURCES/clang-tools-extra-12.0.1.src.tar.xz
+7fe8345c57469fcf32945a16dc0a719e9131741c SOURCES/clang-tools-extra-13.0.0.src.tar.xz
 b8d2648a01d36ed0186fd2c5af325fd28797f9a0 SOURCES/tstellar-gpg-key.asc

.gitignore

@@ -1,3 +1,3 @@
-SOURCES/clang-12.0.1.src.tar.xz
+SOURCES/clang-13.0.0.src.tar.xz
-SOURCES/clang-tools-extra-12.0.1.src.tar.xz
+SOURCES/clang-tools-extra-13.0.0.src.tar.xz
 SOURCES/tstellar-gpg-key.asc

SOURCES/0001-Driver-Add-a-gcc-equivalent-triple-to-the-list-of-tr.patch

@@ -0,0 +1,59 @@
+From d68a5a7817dc0d43853d8b84c9185dc24338664f Mon Sep 17 00:00:00 2001
+From: Tom Stellard <tstellar@redhat.com>
+Date: Wed, 6 Oct 2021 05:32:44 +0000
+Subject: [PATCH] Driver: Add a gcc equivalent triple to the list of triples to
+ search
+
+There are some gcc triples, like x86_64-redhat-linux, that provide the
+same behavior as a clang triple with a similar name (e.g.
+x86_64-redhat-linux-gnu).  When searching for a gcc install, also search
+for a gcc equivalent triple if one exists.
+
+Differential Revision: https://reviews.llvm.org/D111207
+---
+ clang/lib/Driver/ToolChains/Gnu.cpp | 22 ++++++++++++++++++++++
+ 1 file changed, 22 insertions(+)
+
+diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp
+index fe5bda5c6605..fd4a7f72be14 100644
+--- a/clang/lib/Driver/ToolChains/Gnu.cpp
++++ b/clang/lib/Driver/ToolChains/Gnu.cpp
+@@ -1884,6 +1884,18 @@ static llvm::StringRef getGCCToolchainDir(const ArgList &Args,
+   return GCC_INSTALL_PREFIX;
+ }
+ 
++/// This function takes a 'clang' triple and converts it to an equivalent gcc
++/// triple.
++static const char *ConvertToGccTriple(StringRef CandidateTriple) {
++  return llvm::StringSwitch<const char *>(CandidateTriple)
++      .Case("aarch64-redhat-linux-gnu", "aarch64-redhat-linux")
++      .Case("i686-redhat-linux-gnu", "i686-redhat-linux")
++      .Case("ppc64le-redhat-linux-gnu", "ppc64le-redhat-linux")
++      .Case("s390x-redhat-linux-gnu", "s390x-redhat-linux")
++      .Case("x86_64-redhat-linux-gnu", "x86_64-redhat-linux")
++      .Default(NULL);
++}
++
+ /// Initialize a GCCInstallationDetector from the driver.
+ ///
+ /// This performs all of the autodetection and sets up the various paths.
+@@ -1904,6 +1916,16 @@ void Generic_GCC::GCCInstallationDetector::init(
+   // The compatible GCC triples for this particular architecture.
+   SmallVector<StringRef, 16> CandidateTripleAliases;
+   SmallVector<StringRef, 16> CandidateBiarchTripleAliases;
++
++  // In some cases gcc uses a slightly different triple than clang for the
++  // same target.  Convert the clang triple to the gcc equivalent and use that
++  // to search for the gcc install.
++  const char *ConvertedTriple = ConvertToGccTriple(TargetTriple.str());
++  if (ConvertedTriple) {
++    CandidateTripleAliases.push_back(ConvertedTriple);
++    CandidateBiarchTripleAliases.push_back(ConvertedTriple);
++  }
++
+   CollectLibDirsAndTriples(TargetTriple, BiarchVariantTriple, CandidateLibDirs,
+                            CandidateTripleAliases, CandidateBiarchLibDirs,
+                            CandidateBiarchTripleAliases);
+-- 
+2.26.2
+

SOURCES/0001-PATCH-clang-Fix-scan-build-py-executable-lookup-path.patch

@@ -0,0 +1,36 @@
+From 62eaebcb6bb872830299efa3f87506f1d23ef366 Mon Sep 17 00:00:00 2001
+From: serge-sans-paille <sguelton@redhat.com>
+Date: Mon, 13 Sep 2021 10:25:45 +0200
+Subject: [PATCH][clang] Fix scan-build-py executable lookup path
+
+Once installed, scan-build-py doesn't know anything about its auxiliary
+executable and can't find them.
+Use relative path wrt. scan-build-py script.
+
+Differential Revision: https://reviews.llvm.org/D109659
+
+(cherry picked from commit c84755a046bbdcd0564693e30b2508034b06002b)
+---
+ clang/tools/scan-build-py/lib/libscanbuild/analyze.py | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/clang/tools/scan-build-py/lib/libscanbuild/analyze.py b/clang/tools/scan-build-py/lib/libscanbuild/analyze.py
+index 9a249a8..d83ff2a 100644
+--- a/clang/tools/scan-build-py/lib/libscanbuild/analyze.py
++++ b/clang/tools/scan-build-py/lib/libscanbuild/analyze.py
+@@ -39,8 +39,10 @@ from libscanbuild.shell import decode
+ 
+ __all__ = ['scan_build', 'analyze_build', 'analyze_compiler_wrapper']
+ 
+-COMPILER_WRAPPER_CC = 'analyze-cc'
+-COMPILER_WRAPPER_CXX = 'analyze-c++'
++scanbuild_dir = os.path.dirname(__import__('sys').argv[0])
++
++COMPILER_WRAPPER_CC = os.path.join(scanbuild_dir, '..', 'libexec', 'analyze-cc')
++COMPILER_WRAPPER_CXX = os.path.join(scanbuild_dir, '..', 'libexec', 'analyze-c++')
+ 
+ CTU_EXTDEF_MAP_FILENAME = 'externalDefMap.txt'
+ CTU_TEMP_DEFMAP_FOLDER = 'tmpExternalDefMaps'
+-- 
+1.8.3.1
+

SOURCES/0001-cmake-Allow-shared-libraries-to-customize-the-soname.patch

@@ -0,0 +1,39 @@
+From 3dc5722d5c7673a879f2b4680369d3ac8b6b64b6 Mon Sep 17 00:00:00 2001
+From: Tom Stellard <tstellar@redhat.com>
+Date: Wed, 4 Aug 2021 14:05:38 -0700
+Subject: [PATCH] cmake: Allow shared libraries to customize the soname using
+ LLVM_ABI_REVISION
+
+The LLVM_ABI_REVISION variable is intended to be used for release
+candidates which introduce an ABI change to a shared library.  This
+variable can be specified per library, so there is not one global value
+for all of LLVM.
+
+For example, if we LLVM X.0.0-rc2 introduces an ABI change for a library
+compared with LLVM X.0.0-rc1, then the LLVM_ABI_REVISION number for
+library will be incremented by 1.
+
+In the main branch, LLVM_ABI_REVISION should always be 0, it is only
+meant to be used in the release branch.
+
+Differential Revision: https://reviews.llvm.org/D105594
+---
+ clang/tools/clang-shlib/CMakeLists.txt | 5 +++++
+ 3 files changed, 19 insertions(+), 2 deletions(-)
+
+diff --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
+index 9c1f8ea452b3..4d785924e4bb 100644
+--- a/clang/tools/clang-shlib/CMakeLists.txt
++++ b/clang/tools/clang-shlib/CMakeLists.txt
+@@ -1,3 +1,8 @@
++# In the main branch, LLVM_ABI_REVISION should always be 0.  In the release
++# branches, this should be incremented before each release candidate every
++# time the ABI of libclang-cpp.so changes.
++set(LLVM_ABI_REVISION 0)
++
+ # Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off
+ if (NOT LLVM_ENABLE_PIC)
+   return()
+-- 
+2.27.0
+

SOURCES/0002-Misleading-bidirectional-detection.patch

@@ -1,332 +0,0 @@
-From 9613c86f0427be88ee43bddb7ae7cde74c1157ac Mon Sep 17 00:00:00 2001
-From: serge-sans-paille <sguelton@redhat.com>
-Date: Thu, 4 Nov 2021 11:11:53 +0100
-Subject: [PATCH 2/3] Misleading bidirectional detection
-
-Differential Revision: https://reviews.llvm.org/D112913
----
- clang-tools-extra/clang-tidy/misc/CMakeLists.txt   |   1 +
- .../clang-tidy/misc/MiscTidyModule.cpp             |   3 +
- .../clang-tidy/misc/MisleadingBidirectional.cpp    | 131 +++++++++++++++++++++
- .../clang-tidy/misc/MisleadingBidirectional.h      |  38 ++++++
- clang-tools-extra/docs/ReleaseNotes.rst            |   5 +
- clang-tools-extra/docs/clang-tidy/checks/list.rst  |   3 +-
- .../checks/misc-misleading-bidirectional.rst       |  21 ++++
- .../checkers/misc-misleading-bidirectional.cpp     |  31 +++++
- 8 files changed, 232 insertions(+), 1 deletion(-)
- create mode 100644 clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp
- create mode 100644 clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h
- create mode 100644 clang-tools-extra/docs/clang-tidy/checks/misc-misleading-bidirectional.rst
- create mode 100644 clang-tools-extra/test/clang-tidy/checkers/misc-misleading-bidirectional.cpp
-
-diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
-index d438a47..d6bb718 100644
---- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
-+++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
-@@ -11,6 +11,7 @@ add_clang_library(clangTidyMiscModule
-   DefinitionsInHeadersCheck.cpp
-   Homoglyph.cpp
-   MiscTidyModule.cpp
-+  MisleadingBidirectional.cpp
-   MisplacedConstCheck.cpp
-   NewDeleteOverloadsCheck.cpp
-   NoRecursionCheck.cpp
-diff --git a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
-index 5c7bd0c..bb5fde2 100644
---- a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
-+++ b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
-@@ -11,6 +11,7 @@
- #include "../ClangTidyModuleRegistry.h"
- #include "DefinitionsInHeadersCheck.h"
- #include "Homoglyph.h"
-+#include "MisleadingBidirectional.h"
- #include "MisplacedConstCheck.h"
- #include "NewDeleteOverloadsCheck.h"
- #include "NoRecursionCheck.h"
-@@ -35,6 +36,8 @@ public:
-     CheckFactories.registerCheck<DefinitionsInHeadersCheck>(
-         "misc-definitions-in-headers");
-     CheckFactories.registerCheck<Homoglyph>("misc-homoglyph");
-+    CheckFactories.registerCheck<MisleadingBidirectionalCheck>(
-+        "misc-misleading-bidirectional");
-     CheckFactories.registerCheck<MisplacedConstCheck>("misc-misplaced-const");
-     CheckFactories.registerCheck<NewDeleteOverloadsCheck>(
-         "misc-new-delete-overloads");
-diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp
-new file mode 100644
-index 0000000..7a2f06b
---- /dev/null
-+++ b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp
-@@ -0,0 +1,131 @@
-+//===--- MisleadingBidirectional.cpp - clang-tidy -------------------------===//
-+//
-+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-+// See https://llvm.org/LICENSE.txt for license information.
-+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-+//
-+//===----------------------------------------------------------------------===//
-+
-+#include "MisleadingBidirectional.h"
-+
-+#include "clang/Frontend/CompilerInstance.h"
-+#include "clang/Lex/Preprocessor.h"
-+#include "llvm/Support/ConvertUTF.h"
-+
-+using namespace clang;
-+
-+static bool containsMisleadingBidi(StringRef Buffer,
-+                                   bool HonorLineBreaks = true) {
-+  const char *CurPtr = Buffer.begin();
-+  unsigned EmbeddingOverride = 0, Isolate = 0;
-+  unsigned i = 0;
-+
-+  enum {
-+    LS = 0x2028,
-+    PS = 0x2029,
-+    RLO = 0x202E,
-+    RLE = 0x202B,
-+    LRO = 0x202D,
-+    LRE = 0x202A,
-+    PDF = 0x202C,
-+    RLI = 0x2067,
-+    LRI = 0x2066,
-+    FSI = 0x2068,
-+    PDI = 0x2069
-+  };
-+
-+  // Scan each character while maintaining a count of opened bidi context.
-+  // RLO/RLE/LRO/LRE all are closed by PDF while RLI LRI and FSI are closed by
-+  // PDI. New lines reset the context count. Extra PDF / PDI are ignored.
-+  //
-+  // Warn if we end up with an unclosed context.
-+  while (CurPtr < Buffer.end()) {
-+    ++i;
-+    unsigned char C = *CurPtr;
-+    if (isASCII(C)) {
-+      ++CurPtr;
-+      // Line break: https://www.unicode.org/reports/tr14/tr14-32.html
-+      if (C == '\n' || C == '\r' || C == '\f' || C == '\v' ||
-+          C == 0x85 /*next line*/)
-+        EmbeddingOverride = Isolate = 0;
-+      continue;
-+    }
-+    llvm::UTF32 CodePoint;
-+    llvm::ConversionResult Result = llvm::convertUTF8Sequence(
-+        (const llvm::UTF8 **)&CurPtr, (const llvm::UTF8 *)Buffer.end(),
-+        &CodePoint, llvm::strictConversion);
-+
-+    // If conversion fails, utf-8 is designed so that we can just try next char.
-+    if (Result != llvm::conversionOK) {
-+      ++CurPtr;
-+      continue;
-+    }
-+
-+    if (CodePoint == RLO || CodePoint == RLE || CodePoint == LRO ||
-+        CodePoint == LRE)
-+      EmbeddingOverride += 1;
-+    else if (CodePoint == PDF)
-+      EmbeddingOverride = std::min(EmbeddingOverride - 1, EmbeddingOverride);
-+    else if (CodePoint == RLI || CodePoint == LRI || CodePoint == FSI)
-+      Isolate += 1;
-+    else if (CodePoint == PDI)
-+      Isolate = std::min(Isolate - 1, Isolate);
-+    // Line break: https://www.unicode.org/reports/tr14/tr14-32.html
-+    else if (CodePoint == LS || CodePoint == PS)
-+      EmbeddingOverride = Isolate = 0;
-+  }
-+  return EmbeddingOverride != 0 || Isolate != 0;
-+}
-+
-+class clang::tidy::misc::MisleadingBidirectionalCheck::
-+    MisleadingBidirectionalHandler : public CommentHandler {
-+public:
-+  MisleadingBidirectionalHandler(MisleadingBidirectionalCheck &Check,
-+                                 llvm::Optional<std::string> User)
-+      : Check(Check) {}
-+
-+  bool HandleComment(Preprocessor &PP, SourceRange Range) override {
-+    // FIXME: check that we are in a /* */ comment
-+    StringRef Text =
-+        Lexer::getSourceText(CharSourceRange::getCharRange(Range),
-+                             PP.getSourceManager(), PP.getLangOpts());
-+
-+    if (containsMisleadingBidi(Text, true))
-+      Check.diag(
-+          Range.getBegin(),
-+          "comment contains misleading bidirectional Unicode characters");
-+    return false;
-+  }
-+
-+private:
-+  MisleadingBidirectionalCheck &Check;
-+};
-+
-+clang::tidy::misc::MisleadingBidirectionalCheck::MisleadingBidirectionalCheck(
-+    StringRef Name, ClangTidyContext *Context)
-+    : ClangTidyCheck(Name, Context),
-+      Handler(std::make_unique<MisleadingBidirectionalHandler>(
-+          *this, Context->getOptions().User)) {}
-+
-+clang::tidy::misc::MisleadingBidirectionalCheck::
-+    ~MisleadingBidirectionalCheck() = default;
-+
-+void clang::tidy::misc::MisleadingBidirectionalCheck::registerPPCallbacks(
-+    const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) {
-+  PP->addCommentHandler(Handler.get());
-+}
-+
-+void clang::tidy::misc::MisleadingBidirectionalCheck::check(
-+    const ast_matchers::MatchFinder::MatchResult &Result) {
-+  if (const auto *SL = Result.Nodes.getNodeAs<StringLiteral>("strlit")) {
-+    StringRef Literal = SL->getBytes();
-+    if (containsMisleadingBidi(Literal, false))
-+      diag(SL->getBeginLoc(), "string literal contains misleading "
-+                              "bidirectional Unicode characters");
-+  }
-+}
-+
-+void clang::tidy::misc::MisleadingBidirectionalCheck::registerMatchers(
-+    ast_matchers::MatchFinder *Finder) {
-+  Finder->addMatcher(ast_matchers::stringLiteral().bind("strlit"), this);
-+}
-diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h
-new file mode 100644
-index 0000000..18e7060
---- /dev/null
-+++ b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h
-@@ -0,0 +1,38 @@
-+//===--- MisleadingBidirectionalCheck.h - clang-tidy ------------*- C++ -*-===//
-+//
-+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-+// See https://llvm.org/LICENSE.txt for license information.
-+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-+//
-+//===----------------------------------------------------------------------===//
-+
-+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MISLEADINGBIDIRECTIONALCHECK_H
-+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MISLEADINGBIDIRECTIONALCHECK_H
-+
-+#include "../ClangTidyCheck.h"
-+
-+namespace clang {
-+namespace tidy {
-+namespace misc {
-+
-+class MisleadingBidirectionalCheck : public ClangTidyCheck {
-+public:
-+  MisleadingBidirectionalCheck(StringRef Name, ClangTidyContext *Context);
-+  ~MisleadingBidirectionalCheck();
-+
-+  void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
-+                           Preprocessor *ModuleExpanderPP) override;
-+
-+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
-+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
-+
-+private:
-+  class MisleadingBidirectionalHandler;
-+  std::unique_ptr<MisleadingBidirectionalHandler> Handler;
-+};
-+
-+} // namespace misc
-+} // namespace tidy
-+} // namespace clang
-+
-+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MISLEADINGBIDIRECTIONALCHECK_H
-diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
-index e4ad7b9..546d544 100644
---- a/clang-tools-extra/docs/ReleaseNotes.rst
-+++ b/clang-tools-extra/docs/ReleaseNotes.rst
-@@ -326,6 +326,11 @@ New checks
- 
-   Detects confusable unicode identifiers.
- 
-+- New :doc:`misc-misleading-bidirectional <clang-tidy/checks/misc-misleading-bidirectional>` check.
-+
-+  Inspect string literal and comments for unterminated bidirectional Unicode
-+  characters.
-+
- New check aliases
- ^^^^^^^^^^^^^^^^^
- 
-diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst
-index 47ff5b7..977867d 100644
---- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
-+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
-@@ -202,7 +202,8 @@ Clang-Tidy Checks
-    `llvmlibc-implementation-in-namespace <llvmlibc-implementation-in-namespace.html>`_,
-    `llvmlibc-restrict-system-libc-headers <llvmlibc-restrict-system-libc-headers.html>`_, "Yes"
-    `misc-definitions-in-headers <misc-definitions-in-headers.html>`_, "Yes"
--   `misc-homoglyph <misc-homoglyph.html>`_, "Yes"
-+   `misc-homoglyph <misc-homoglyph.html>`_,
-+   `misc-misleading-bidirectional <misc-misleading-bidirectional.html>`_,
-    `misc-misplaced-const <misc-misplaced-const.html>`_,
-    `misc-new-delete-overloads <misc-new-delete-overloads.html>`_,
-    `misc-no-recursion <misc-no-recursion.html>`_,
-diff --git a/clang-tools-extra/docs/clang-tidy/checks/misc-misleading-bidirectional.rst b/clang-tools-extra/docs/clang-tidy/checks/misc-misleading-bidirectional.rst
-new file mode 100644
-index 0000000..16ffc97
---- /dev/null
-+++ b/clang-tools-extra/docs/clang-tidy/checks/misc-misleading-bidirectional.rst
-@@ -0,0 +1,21 @@
-+.. title:: clang-tidy - misc-misleading-bidirectional
-+
-+misc-misleading-bidirectional
-+=============================
-+
-+Warn about unterminated bidirectional unicode sequence, detecting potential attack
-+as described in the `Trojan Source <https://www.trojansource.codes>`_ attack.
-+
-+Example:
-+
-+.. code-block:: c++
-+
-+    #include <iostream>
-+
-+    int main() {
-+        bool isAdmin = false;
-+        /*‮ } ⁦if (isAdmin)⁩ ⁦ begin admins only */
-+            std::cout << "You are an admin.\n";
-+        /* end admins only ‮ { ⁦*/
-+        return 0;
-+    }
-diff --git a/clang-tools-extra/test/clang-tidy/checkers/misc-misleading-bidirectional.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc-misleading-bidirectional.cpp
-new file mode 100644
-index 0000000..12fdf63
---- /dev/null
-+++ b/clang-tools-extra/test/clang-tidy/checkers/misc-misleading-bidirectional.cpp
-@@ -0,0 +1,31 @@
-+// RUN: %check_clang_tidy %s misc-misleading-bidirectional %t
-+
-+void func(void) {
-+  int admin = 0;
-+  /*‮ }⁦if(admin)⁩ ⁦ begin*/
-+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: comment contains misleading bidirectional Unicode characters [misc-misleading-bidirectional]
-+  const char msg[] = "‮⁦if(admin)⁩ ⁦tes";
-+  // CHECK-MESSAGES: :[[@LINE-1]]:22: warning: string literal contains misleading bidirectional Unicode characters [misc-misleading-bidirectional]
-+}
-+
-+void all_fine(void) {
-+  char valid[] = "some‮valid‬sequence";
-+  /* EOL ends bidi‮ sequence
-+   * end it's fine to do so.
-+   * EOL ends ⁧isolate too
-+   */
-+}
-+
-+int invalid_utf_8(void) {
-+  bool isAdmin = false;
-+
-+  // the comment below contains an invalid utf8 character, but should still be
-+  // processed.
-+
-+  // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: comment contains misleading bidirectional Unicode characters [misc-misleading-bidirectional]
-+  /*€‮ } ⁦if (isAdmin)⁩ ⁦ begin admins only */
-+  return 1;
-+  /* end admins only ‮ { ⁦*/
-+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: comment contains misleading bidirectional Unicode characters [misc-misleading-bidirectional]
-+  return 0;
-+}
--- 
-1.8.3.1
-

SOURCES/0003-Misleading-unicode-identifier-detection-pass.patch

@@ -1,355 +0,0 @@
-From d214ffa5e0bea78f85f61e96dc1071e4ed4ac69f Mon Sep 17 00:00:00 2001
-From: serge-sans-paille <sguelton@redhat.com>
-Date: Fri, 15 Oct 2021 15:18:52 +0200
-Subject: [PATCH 3/3] Misleading unicode identifier detection pass
-
-Detect when an identifier contains some Right-To-Left characters.
-This pass relates to https://trojansource.codes/
-
-Differential Revision: https://reviews.llvm.org/D112914
----
- clang-tools-extra/clang-tidy/misc/CMakeLists.txt   |   1 +
- .../clang-tidy/misc/MiscTidyModule.cpp             |   3 +
- .../clang-tidy/misc/MisleadingIdentifier.cpp       | 163 +++++++++++++++++++++
- .../clang-tidy/misc/MisleadingIdentifier.h         |  31 ++++
- clang-tools-extra/docs/ReleaseNotes.rst            |   9 ++
- clang-tools-extra/docs/clang-tidy/checks/list.rst  |   1 +
- .../checks/misc-misleading-identifier.rst          |  23 +++
- .../checkers/misc-misleading-identifier.cpp        |  15 ++
- 8 files changed, 246 insertions(+)
- create mode 100644 clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.cpp
- create mode 100644 clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h
- create mode 100644 clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst
- create mode 100644 clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp
-
-diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
-index d6bb718..1974245 100644
---- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
-+++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
-@@ -12,6 +12,7 @@ add_clang_library(clangTidyMiscModule
-   Homoglyph.cpp
-   MiscTidyModule.cpp
-   MisleadingBidirectional.cpp
-+  MisleadingIdentifier.cpp
-   MisplacedConstCheck.cpp
-   NewDeleteOverloadsCheck.cpp
-   NoRecursionCheck.cpp
-diff --git a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
-index bb5fde2..b484db8 100644
---- a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
-+++ b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
-@@ -12,6 +12,7 @@
- #include "DefinitionsInHeadersCheck.h"
- #include "Homoglyph.h"
- #include "MisleadingBidirectional.h"
-+#include "MisleadingIdentifier.h"
- #include "MisplacedConstCheck.h"
- #include "NewDeleteOverloadsCheck.h"
- #include "NoRecursionCheck.h"
-@@ -38,6 +39,8 @@ public:
-     CheckFactories.registerCheck<Homoglyph>("misc-homoglyph");
-     CheckFactories.registerCheck<MisleadingBidirectionalCheck>(
-         "misc-misleading-bidirectional");
-+    CheckFactories.registerCheck<MisleadingIdentifierCheck>(
-+        "misc-misleading-identifier");
-     CheckFactories.registerCheck<MisplacedConstCheck>("misc-misplaced-const");
-     CheckFactories.registerCheck<NewDeleteOverloadsCheck>(
-         "misc-new-delete-overloads");
-diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.cpp b/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.cpp
-new file mode 100644
-index 0000000..f9b3075
---- /dev/null
-+++ b/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.cpp
-@@ -0,0 +1,163 @@
-+//===--- MisleadingIdentifier.cpp - clang-tidy-----------------------------===//
-+//
-+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-+// See https://llvm.org/LICENSE.txt for license information.
-+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-+//
-+//===----------------------------------------------------------------------===//
-+
-+#include "MisleadingIdentifier.h"
-+
-+#include "clang/Frontend/CompilerInstance.h"
-+#include "llvm/Support/ConvertUTF.h"
-+
-+namespace clang {
-+namespace tidy {
-+namespace misc {
-+
-+// See https://www.unicode.org/Public/14.0.0/ucd/extracted/DerivedBidiClass.txt
-+static bool isUnassignedAL(llvm::UTF32 CP) {
-+  return (0x0600 <= CP && CP <= 0x07BF) || (0x0860 <= CP && CP <= 0x08FF) ||
-+         (0xFB50 <= CP && CP <= 0xFDCF) || (0xFDF0 <= CP && CP <= 0xFDFF) ||
-+         (0xFE70 <= CP && CP <= 0xFEFF) ||
-+         (0x00010D00 <= CP && CP <= 0x00010D3F) ||
-+         (0x00010F30 <= CP && CP <= 0x00010F6F) ||
-+         (0x0001EC70 <= CP && CP <= 0x0001ECBF) ||
-+         (0x0001ED00 <= CP && CP <= 0x0001ED4F) ||
-+         (0x0001EE00 <= CP && CP <= 0x0001EEFF);
-+}
-+
-+// See https://www.unicode.org/Public/14.0.0/ucd/extracted/DerivedBidiClass.txt
-+static bool isUnassignedR(llvm::UTF32 CP) {
-+  return (0x0590 <= CP && CP <= 0x05FF) || (0x07C0 <= CP && CP <= 0x085F) ||
-+         (0xFB1D <= CP && CP <= 0xFB4F) ||
-+         (0x00010800 <= CP && CP <= 0x00010CFF) ||
-+         (0x00010D40 <= CP && CP <= 0x00010F2F) ||
-+         (0x00010F70 <= CP && CP <= 0x00010FFF) ||
-+         (0x0001E800 <= CP && CP <= 0x0001EC6F) ||
-+         (0x0001ECC0 <= CP && CP <= 0x0001ECFF) ||
-+         (0x0001ED50 <= CP && CP <= 0x0001EDFF) ||
-+         (0x0001EF00 <= CP && CP <= 0x0001EFFF);
-+}
-+
-+// See https://www.unicode.org/Public/14.0.0/ucd/extracted/DerivedBidiClass.txt
-+static bool isR(llvm::UTF32 CP) {
-+  return (CP == 0x0590) || (CP == 0x05BE) || (CP == 0x05C0) || (CP == 0x05C3) ||
-+         (CP == 0x05C6) || (0x05C8 <= CP && CP <= 0x05CF) ||
-+         (0x05D0 <= CP && CP <= 0x05EA) || (0x05EB <= CP && CP <= 0x05EE) ||
-+         (0x05EF <= CP && CP <= 0x05F2) || (0x05F3 <= CP && CP <= 0x05F4) ||
-+         (0x05F5 <= CP && CP <= 0x05FF) || (0x07C0 <= CP && CP <= 0x07C9) ||
-+         (0x07CA <= CP && CP <= 0x07EA) || (0x07F4 <= CP && CP <= 0x07F5) ||
-+         (CP == 0x07FA) || (0x07FB <= CP && CP <= 0x07FC) ||
-+         (0x07FE <= CP && CP <= 0x07FF) || (0x0800 <= CP && CP <= 0x0815) ||
-+         (CP == 0x081A) || (CP == 0x0824) || (CP == 0x0828) ||
-+         (0x082E <= CP && CP <= 0x082F) || (0x0830 <= CP && CP <= 0x083E) ||
-+         (CP == 0x083F) || (0x0840 <= CP && CP <= 0x0858) ||
-+         (0x085C <= CP && CP <= 0x085D) || (CP == 0x085E) || (CP == 0x085F) ||
-+         (CP == 0x200F) || (CP == 0xFB1D) || (0xFB1F <= CP && CP <= 0xFB28) ||
-+         (0xFB2A <= CP && CP <= 0xFB36) || (CP == 0xFB37) ||
-+         (0xFB38 <= CP && CP <= 0xFB3C) || (CP == 0xFB3D) || (CP == 0xFB3E) ||
-+         (CP == 0xFB3F) || (0xFB40 <= CP && CP <= 0xFB41) || (CP == 0xFB42) ||
-+         (0xFB43 <= CP && CP <= 0xFB44) || (CP == 0xFB45) ||
-+         (0xFB46 <= CP && CP <= 0xFB4F) || (0x10800 <= CP && CP <= 0x10805) ||
-+         (0x10806 <= CP && CP <= 0x10807) || (CP == 0x10808) ||
-+         (CP == 0x10809) || (0x1080A <= CP && CP <= 0x10835) ||
-+         (CP == 0x10836) || (0x10837 <= CP && CP <= 0x10838) ||
-+         (0x10839 <= CP && CP <= 0x1083B) || (CP == 0x1083C) ||
-+         (0x1083D <= CP && CP <= 0x1083E) || (0x1083F <= CP && CP <= 0x10855) ||
-+         (CP == 0x10856) || (CP == 0x10857) ||
-+         (0x10858 <= CP && CP <= 0x1085F) || (0x10860 <= CP && CP <= 0x10876) ||
-+         (0x10877 <= CP && CP <= 0x10878) || (0x10879 <= CP && CP <= 0x1087F) ||
-+         (0x10880 <= CP && CP <= 0x1089E) || (0x1089F <= CP && CP <= 0x108A6) ||
-+         (0x108A7 <= CP && CP <= 0x108AF) || (0x108B0 <= CP && CP <= 0x108DF) ||
-+         (0x108E0 <= CP && CP <= 0x108F2) || (CP == 0x108F3) ||
-+         (0x108F4 <= CP && CP <= 0x108F5) || (0x108F6 <= CP && CP <= 0x108FA) ||
-+         (0x108FB <= CP && CP <= 0x108FF) || (0x10900 <= CP && CP <= 0x10915) ||
-+         (0x10916 <= CP && CP <= 0x1091B) || (0x1091C <= CP && CP <= 0x1091E) ||
-+         (0x10920 <= CP && CP <= 0x10939) || (0x1093A <= CP && CP <= 0x1093E) ||
-+         (CP == 0x1093F) || (0x10940 <= CP && CP <= 0x1097F) ||
-+         (0x10980 <= CP && CP <= 0x109B7) || (0x109B8 <= CP && CP <= 0x109BB) ||
-+         (0x109BC <= CP && CP <= 0x109BD) || (0x109BE <= CP && CP <= 0x109BF) ||
-+         (0x109C0 <= CP && CP <= 0x109CF) || (0x109D0 <= CP && CP <= 0x109D1) ||
-+         (0x109D2 <= CP && CP <= 0x109FF) || (CP == 0x10A00) ||
-+         (CP == 0x10A04) || (0x10A07 <= CP && CP <= 0x10A0B) ||
-+         (0x10A10 <= CP && CP <= 0x10A13) || (CP == 0x10A14) ||
-+         (0x10A15 <= CP && CP <= 0x10A17) || (CP == 0x10A18) ||
-+         (0x10A19 <= CP && CP <= 0x10A35) || (0x10A36 <= CP && CP <= 0x10A37) ||
-+         (0x10A3B <= CP && CP <= 0x10A3E) || (0x10A40 <= CP && CP <= 0x10A48) ||
-+         (0x10A49 <= CP && CP <= 0x10A4F) || (0x10A50 <= CP && CP <= 0x10A58) ||
-+         (0x10A59 <= CP && CP <= 0x10A5F) || (0x10A60 <= CP && CP <= 0x10A7C) ||
-+         (0x10A7D <= CP && CP <= 0x10A7E) || (CP == 0x10A7F) ||
-+         (0x10A80 <= CP && CP <= 0x10A9C) || (0x10A9D <= CP && CP <= 0x10A9F) ||
-+         (0x10AA0 <= CP && CP <= 0x10ABF) || (0x10AC0 <= CP && CP <= 0x10AC7) ||
-+         (CP == 0x10AC8) || (0x10AC9 <= CP && CP <= 0x10AE4) ||
-+         (0x10AE7 <= CP && CP <= 0x10AEA) || (0x10AEB <= CP && CP <= 0x10AEF) ||
-+         (0x10AF0 <= CP && CP <= 0x10AF6) || (0x10AF7 <= CP && CP <= 0x10AFF) ||
-+         (0x10B00 <= CP && CP <= 0x10B35) || (0x10B36 <= CP && CP <= 0x10B38) ||
-+         (0x10B40 <= CP && CP <= 0x10B55) || (0x10B56 <= CP && CP <= 0x10B57) ||
-+         (0x10B58 <= CP && CP <= 0x10B5F) || (0x10B60 <= CP && CP <= 0x10B72) ||
-+         (0x10B73 <= CP && CP <= 0x10B77) || (0x10B78 <= CP && CP <= 0x10B7F) ||
-+         (0x10B80 <= CP && CP <= 0x10B91) || (0x10B92 <= CP && CP <= 0x10B98) ||
-+         (0x10B99 <= CP && CP <= 0x10B9C) || (0x10B9D <= CP && CP <= 0x10BA8) ||
-+         (0x10BA9 <= CP && CP <= 0x10BAF) || (0x10BB0 <= CP && CP <= 0x10BFF) ||
-+         (0x10C00 <= CP && CP <= 0x10C48) || (0x10C49 <= CP && CP <= 0x10C7F) ||
-+         (0x10C80 <= CP && CP <= 0x10CB2) || (0x10CB3 <= CP && CP <= 0x10CBF) ||
-+         (0x10CC0 <= CP && CP <= 0x10CF2) || (0x10CF3 <= CP && CP <= 0x10CF9) ||
-+         (0x10CFA <= CP && CP <= 0x10CFF) || (0x10D40 <= CP && CP <= 0x10E5F) ||
-+         (CP == 0x10E7F) || (0x10E80 <= CP && CP <= 0x10EA9) ||
-+         (CP == 0x10EAA) || (CP == 0x10EAD) ||
-+         (0x10EAE <= CP && CP <= 0x10EAF) || (0x10EB0 <= CP && CP <= 0x10EB1) ||
-+         (0x10EB2 <= CP && CP <= 0x10EFF) || (0x10F00 <= CP && CP <= 0x10F1C) ||
-+         (0x10F1D <= CP && CP <= 0x10F26) || (CP == 0x10F27) ||
-+         (0x10F28 <= CP && CP <= 0x10F2F) || (0x10F70 <= CP && CP <= 0x10F81) ||
-+         (0x10F86 <= CP && CP <= 0x10F89) || (0x10F8A <= CP && CP <= 0x10FAF) ||
-+         (0x10FB0 <= CP && CP <= 0x10FC4) || (0x10FC5 <= CP && CP <= 0x10FCB) ||
-+         (0x10FCC <= CP && CP <= 0x10FDF) || (0x10FE0 <= CP && CP <= 0x10FF6) ||
-+         (0x10FF7 <= CP && CP <= 0x10FFF) || (0x1E800 <= CP && CP <= 0x1E8C4) ||
-+         (0x1E8C5 <= CP && CP <= 0x1E8C6) || (0x1E8C7 <= CP && CP <= 0x1E8CF) ||
-+         (0x1E8D7 <= CP && CP <= 0x1E8FF) || (0x1E900 <= CP && CP <= 0x1E943) ||
-+         (CP == 0x1E94B) || (0x1E94C <= CP && CP <= 0x1E94F) ||
-+         (0x1E950 <= CP && CP <= 0x1E959) || (0x1E95A <= CP && CP <= 0x1E95D) ||
-+         (0x1E95E <= CP && CP <= 0x1E95F) || (0x1E960 <= CP && CP <= 0x1EC6F) ||
-+         (0x1ECC0 <= CP && CP <= 0x1ECFF) || (0x1ED50 <= CP && CP <= 0x1EDFF);
-+}
-+
-+static bool hasRTLCharacters(StringRef Buffer) {
-+  const char *CurPtr = Buffer.begin();
-+  const char *EndPtr = Buffer.end();
-+  while (CurPtr < EndPtr) {
-+    llvm::UTF32 CodePoint;
-+    llvm::ConversionResult Result = llvm::convertUTF8Sequence(
-+        (const llvm::UTF8 **)&CurPtr, (const llvm::UTF8 *)EndPtr, &CodePoint,
-+        llvm::strictConversion);
-+    if (Result != llvm::conversionOK)
-+      break;
-+    if (isUnassignedAL(CodePoint) || isUnassignedR(CodePoint) || isR(CodePoint))
-+      return true;
-+  }
-+  return false;
-+}
-+
-+MisleadingIdentifierCheck::MisleadingIdentifierCheck(StringRef Name,
-+                                                     ClangTidyContext *Context)
-+    : ClangTidyCheck(Name, Context) {}
-+
-+MisleadingIdentifierCheck::~MisleadingIdentifierCheck() = default;
-+
-+void MisleadingIdentifierCheck::check(
-+    const ast_matchers::MatchFinder::MatchResult &Result) {
-+  if (const auto *ND = Result.Nodes.getNodeAs<NamedDecl>("nameddecl")) {
-+    IdentifierInfo *II = ND->getIdentifier();
-+    if (II && hasRTLCharacters(II->getName()))
-+      diag(ND->getBeginLoc(), "identifier has right-to-left codepoints");
-+  }
-+}
-+
-+void MisleadingIdentifierCheck::registerMatchers(
-+    ast_matchers::MatchFinder *Finder) {
-+  Finder->addMatcher(ast_matchers::namedDecl().bind("nameddecl"), this);
-+}
-+
-+} // namespace misc
-+} // namespace tidy
-+} // namespace clang
-diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h b/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h
-new file mode 100644
-index 0000000..9580ae6
---- /dev/null
-+++ b/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h
-@@ -0,0 +1,31 @@
-+//===--- MisleadingIdentifierCheck.h - clang-tidy ---------------*- C++ -*-===//
-+//
-+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-+// See https://llvm.org/LICENSE.txt for license information.
-+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-+//
-+//===----------------------------------------------------------------------===//
-+
-+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MISLEADINGIDENTIFIERCHECK_H
-+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MISLEADINGIDENTIFIERCHECK_H
-+
-+#include "../ClangTidyCheck.h"
-+
-+namespace clang {
-+namespace tidy {
-+namespace misc {
-+
-+class MisleadingIdentifierCheck : public ClangTidyCheck {
-+public:
-+  MisleadingIdentifierCheck(StringRef Name, ClangTidyContext *Context);
-+  ~MisleadingIdentifierCheck();
-+
-+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
-+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
-+};
-+
-+} // namespace misc
-+} // namespace tidy
-+} // namespace clang
-+
-+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MISLEADINGIDENTIFIERCHECK_H
-diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
-index 546d544..3f0ab3b 100644
---- a/clang-tools-extra/docs/ReleaseNotes.rst
-+++ b/clang-tools-extra/docs/ReleaseNotes.rst
-@@ -308,6 +308,11 @@ New checks
- - New :doc:`bugprone-signal-handler
-   <clang-tidy/checks/bugprone-signal-handler>` check.
- 
-+- New :doc:`readability-data-pointer <clang-tidy/checks/readability-data-pointer>` check.
-+
-+- New :doc:`concurrency-thread-canceltype-asynchronous
-+  <clang-tidy/checks/concurrency-thread-canceltype-asynchronous>` check.
-+
-   Finds functions registered as signal handlers that call non asynchronous-safe
-   functions.
- 
-@@ -331,6 +336,10 @@ New checks
-   Inspect string literal and comments for unterminated bidirectional Unicode
-   characters.
- 
-+- New :doc:`misc-misleading-identifier <clang-tidy/checks/misc-misleading-identifier>` check.
-+
-+  Reports identifier with unicode right-to-left characters.
-+
- New check aliases
- ^^^^^^^^^^^^^^^^^
- 
-diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst
-index 977867d..9c0a5b0 100644
---- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
-+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
-@@ -204,6 +204,7 @@ Clang-Tidy Checks
-    `misc-definitions-in-headers <misc-definitions-in-headers.html>`_, "Yes"
-    `misc-homoglyph <misc-homoglyph.html>`_,
-    `misc-misleading-bidirectional <misc-misleading-bidirectional.html>`_,
-+   `misc-misleading-identifier <misc-mileading-identifier.html>`_,
-    `misc-misplaced-const <misc-misplaced-const.html>`_,
-    `misc-new-delete-overloads <misc-new-delete-overloads.html>`_,
-    `misc-no-recursion <misc-no-recursion.html>`_,
-diff --git a/clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst b/clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst
-new file mode 100644
-index 0000000..7ccbc94
---- /dev/null
-+++ b/clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst
-@@ -0,0 +1,23 @@
-+.. title:: clang-tidy - misc-misleading-identifier
-+
-+misc-misleading-identifier
-+==========================
-+
-+Finds identifiers that contain Unicode characters with right-to-left direction,
-+which can be confusing as they may change the understanding of a whole statement
-+line, as described in `Trojan Source <https://trojansource.codes>`_.
-+
-+An example of such misleading code follows:
-+
-+.. code-block:: c
-+
-+  #include <stdio.h>
-+
-+  short int א = (short int)0;
-+  short int ג = (short int)12345;
-+
-+  int main() {
-+    int א = ג; // a local variable, set to zero?
-+    printf("ג is %d\n", ג);
-+    printf("א is %d\n", א);
-+  }
-diff --git a/clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp
-new file mode 100644
-index 0000000..cb036f9
---- /dev/null
-+++ b/clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp
-@@ -0,0 +1,15 @@
-+// RUN: %check_clang_tidy %s misc-misleading-identifier %t
-+
-+#include <stdio.h>
-+
-+// CHECK-MESSAGES: :[[#@LINE+1]]:1: warning: identifier has right-to-left codepoints [misc-misleading-identifier]
-+short int א = (short int)0;
-+// CHECK-MESSAGES: :[[#@LINE+1]]:1: warning: identifier has right-to-left codepoints [misc-misleading-identifier]
-+short int ג = (short int)12345;
-+
-+int main() {
-+  // CHECK-MESSAGES: :[[#@LINE+1]]:3: warning: identifier has right-to-left codepoints [misc-misleading-identifier]
-+  int א = ג; // a local variable, set to zero?
-+  printf("ג is %d\n", ג);
-+  printf("א is %d\n", א);
-+}
--- 
-1.8.3.1
-

SOURCES/0003-PATCH-clang-Don-t-install-static-libraries.patch

@@ -1,25 +1,25 @@
-From 2c6cd40d016f492d53e16f1c7424a0d9878ae7ec Mon Sep 17 00:00:00 2001
+From 88704fc2eabb9dd19a9c3eb81a9b3dc37d95651c Mon Sep 17 00:00:00 2001
 From: Tom Stellard <tstellar@redhat.com>
 Date: Fri, 31 Jan 2020 11:04:57 -0800
-Subject: [PATCH 3/6] [PATCH][clang] Don't install static libraries
+Subject: [PATCH][clang] Don't install static libraries
 
 ---
  clang/cmake/modules/AddClang.cmake | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/clang/cmake/modules/AddClang.cmake b/clang/cmake/modules/AddClang.cmake
-index 704278a..1737b24 100644
+index 5752f4277444..0f52822d91f0 100644
 --- a/clang/cmake/modules/AddClang.cmake
 +++ b/clang/cmake/modules/AddClang.cmake
-@@ -111,7 +111,7 @@ macro(add_clang_library name)
+@@ -113,7 +113,7 @@ macro(add_clang_library name)
      if(TARGET ${lib})
        target_link_libraries(${lib} INTERFACE ${LLVM_COMMON_LIBS})
  
 -      if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ARG_INSTALL_WITH_TOOLCHAIN)
 +      if (ARG_SHARED AND (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ARG_INSTALL_WITH_TOOLCHAIN))
-         set(export_to_clangtargets)
+         get_target_export_arg(${name} Clang export_to_clangtargets UMBRELLA clang-libraries)
-         if(${lib} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
+         install(TARGETS ${lib}
-             "clang-libraries" IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
+           COMPONENT ${lib}
 -- 
-1.8.3.1
+2.30.2
 

SOURCES/0004-PATCH-clang-Prefer-gcc-toolchains-with-libgcc_s.so-w.patch

@@ -1,132 +0,0 @@
-From d8af49687765744efaae7ba0f0c4c0fcd58a0e31 Mon Sep 17 00:00:00 2001
-From: serge-sans-paille <sguelton@redhat.com>
-Date: Wed, 23 Sep 2020 12:47:30 +0000
-Subject: [PATCH 4/6] [PATCH][clang] Prefer gcc toolchains with libgcc_s.so
- when not static linking libgcc
-
-Fedora ships cross-compilers on all platforms, so a user could end up
-with a gcc x86_64 cross-compiler installed on an x86_64 system. clang
-maintains a list of supported triples for each target and when all
-else is equal will prefer toolchains with triples that appear earlier
-in the list.
-
-The cross-compiler triple on Fedora is x86_64-linux-gnu and this comes
-before the Fedora system compiler's triple: x86_64-redhat-linux in
-the triples list, so the cross compiler is always preferred. This
-is a problem, because the cross compiler is missing libraries, like
-libgcc_s.so, that clang expects to be there so linker invocations
-will fail.
-
-This patch fixes this by checking for the existence of libgcc_s.so
-when it is required and taking that into account when selecting a
-toolchain.
----
- clang/lib/Driver/ToolChains/Gnu.cpp                      | 16 ++++++++++++++--
- clang/lib/Driver/ToolChains/Gnu.h                        |  4 +++-
- .../usr/lib/gcc/x86_64-linux-gnu/7/crtbegin.o            |  0
- .../usr/lib/gcc/x86_64-redhat-linux/7/crtbegin.o         |  0
- .../usr/lib/gcc/x86_64-redhat-linux/7/libgcc_s.so        |  0
- clang/test/Driver/linux-ld.c                             | 12 ++++++++++++
- 6 files changed, 29 insertions(+), 3 deletions(-)
- create mode 100644 clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-linux-gnu/7/crtbegin.o
- create mode 100644 clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/crtbegin.o
- create mode 100644 clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/libgcc_s.so
-
-diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp
-index 5deeb10..5d51517 100644
---- a/clang/lib/Driver/ToolChains/Gnu.cpp
-+++ b/clang/lib/Driver/ToolChains/Gnu.cpp
-@@ -2539,6 +2539,8 @@ void Generic_GCC::GCCInstallationDetector::ScanLibDirForGCCTriple(
-        (TargetArch == llvm::Triple::x86 &&
-         TargetTriple.getOS() != llvm::Triple::Solaris)}};
- 
-+  bool NeedLibgccShared = !Args.hasArg(options::OPT_static_libgcc) &&
-+                          !Args.hasArg(options::OPT_static);
-   for (auto &Suffix : Suffixes) {
-     if (!Suffix.Active)
-       continue;
-@@ -2556,8 +2558,17 @@ void Generic_GCC::GCCInstallationDetector::ScanLibDirForGCCTriple(
-           continue; // Saw this path before; no need to look at it again.
-       if (CandidateVersion.isOlderThan(4, 1, 1))
-         continue;
--      if (CandidateVersion <= Version)
--        continue;
-+
-+      bool CandidateHasLibGccShared = false;
-+      if (CandidateVersion <= Version) {
-+        if (NeedLibgccShared && !HasLibGccShared) {
-+          CandidateHasLibGccShared =
-+                D.getVFS().exists(LI->path() + "/libgcc_s.so");
-+
-+        }
-+        if (HasLibGccShared || !CandidateHasLibGccShared)
-+          continue;
-+      }
- 
-       if (!ScanGCCForMultilibs(TargetTriple, Args, LI->path(),
-                                NeedsBiarchSuffix))
-@@ -2571,6 +2582,7 @@ void Generic_GCC::GCCInstallationDetector::ScanLibDirForGCCTriple(
-       GCCInstallPath = (LibDir + "/" + LibSuffix + "/" + VersionText).str();
-       GCCParentLibPath = (GCCInstallPath + "/../" + Suffix.ReversePath).str();
-       IsValid = true;
-+      HasLibGccShared = CandidateHasLibGccShared;
-     }
-   }
- }
-diff --git a/clang/lib/Driver/ToolChains/Gnu.h b/clang/lib/Driver/ToolChains/Gnu.h
-index 90d3baf..9d0cea2 100644
---- a/clang/lib/Driver/ToolChains/Gnu.h
-+++ b/clang/lib/Driver/ToolChains/Gnu.h
-@@ -190,6 +190,7 @@ public:
-   /// Driver, and has logic for fuzzing that where appropriate.
-   class GCCInstallationDetector {
-     bool IsValid;
-+    bool HasLibGccShared;
-     llvm::Triple GCCTriple;
-     const Driver &D;
- 
-@@ -216,7 +217,8 @@ public:
-     const std::string GentooConfigDir = "/etc/env.d/gcc";
- 
-   public:
--    explicit GCCInstallationDetector(const Driver &D) : IsValid(false), D(D) {}
-+    explicit GCCInstallationDetector(const Driver &D)
-+        : IsValid(false), HasLibGccShared(false), D(D) {}
-     void init(const llvm::Triple &TargetTriple, const llvm::opt::ArgList &Args,
-               ArrayRef<std::string> ExtraTripleAliases = None);
- 
-diff --git a/clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-linux-gnu/7/crtbegin.o b/clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-linux-gnu/7/crtbegin.o
-new file mode 100644
-index 0000000..e69de29
-diff --git a/clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/crtbegin.o b/clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/crtbegin.o
-new file mode 100644
-index 0000000..e69de29
-diff --git a/clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/libgcc_s.so b/clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/libgcc_s.so
-new file mode 100644
-index 0000000..e69de29
-diff --git a/clang/test/Driver/linux-ld.c b/clang/test/Driver/linux-ld.c
-index 24d3c78..071bb9b 100644
---- a/clang/test/Driver/linux-ld.c
-+++ b/clang/test/Driver/linux-ld.c
-@@ -784,6 +784,18 @@
- // CHECK-FEDORA-31-RISCV64: "{{.*}}/usr/lib/gcc/riscv64-redhat-linux/9{{/|\\\\}}crtend.o"
- // CHECK-FEDORA-31-RISCV64: "{{.*}}/usr/lib/gcc/riscv64-redhat-linux/9{{/|\\\\}}crtn.o"
- //
-+// Check that clang does not select the cross compiler by default on Fedora 28.
-+//
-+// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
-+// RUN:     --target=x86_64-unknown-linux-gnu \
-+// RUN:     --gcc-toolchain="" \
-+// RUN:     --sysroot=%S/Inputs/fedora_28_tree \
-+// RUN:   | FileCheck --check-prefix=CHECK-FEDORA-28-X86_64 %s
-+//
-+// CHECK-FEDORA-28-X86_64: "{{.*}}ld{{(.exe)?}}" "--sysroot=[[SYSROOT:[^"]+]]"
-+// CHECK-FEDORA-28-X86_64: "[[SYSROOT]]/usr/lib/gcc/x86_64-redhat-linux/7/crtbegin.o"
-+// CHECK-FEDORA-28-X86_64: "-L[[SYSROOT]]/usr/lib/gcc/x86_64-redhat-linux/7"
-+//
- // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
- // RUN:     --target=arm-unknown-linux-gnueabi -rtlib=platform \
- // RUN:     --gcc-toolchain="" \
--- 
-1.8.3.1
-

SOURCES/0006-PATCH-clang-Allow-__ieee128-as-an-alias-to-__float12.patch

@@ -1,77 +0,0 @@
-From 1ef1e91142ac48ecb826f33e1e7072c7402d9fe7 Mon Sep 17 00:00:00 2001
-From: serge-sans-paille <sguelton@redhat.com>
-Date: Wed, 3 Mar 2021 09:58:31 +0100
-Subject: [PATCH 6/6] [PATCH][clang] Allow __ieee128 as an alias to __float128
- on ppc
-
-This matches gcc behavior.
-
-Differential Revision: https://reviews.llvm.org/D97846
-
-(cherry picked from commit 4aa510be78a75a4da82657fe433016f00dad0784)
----
- clang/include/clang/Basic/LangOptions.def | 1 +
- clang/lib/Basic/IdentifierTable.cpp       | 3 +++
- clang/lib/Basic/Targets/PPC.cpp           | 1 +
- clang/test/Sema/128bitfloat.cpp           | 7 +++++++
- 4 files changed, 12 insertions(+)
-
-diff --git a/clang/include/clang/Basic/LangOptions.def b/clang/include/clang/Basic/LangOptions.def
-index c01f0cc..3c22393e 100644
---- a/clang/include/clang/Basic/LangOptions.def
-+++ b/clang/include/clang/Basic/LangOptions.def
-@@ -107,6 +107,7 @@ LANGOPT(Bool              , 1, 0, "bool, true, and false keywords")
- LANGOPT(Half              , 1, 0, "half keyword")
- LANGOPT(WChar             , 1, CPlusPlus, "wchar_t keyword")
- LANGOPT(Char8             , 1, 0, "char8_t keyword")
-+LANGOPT(IEEE128           , 1, 0, "__ieee128 keyword")
- LANGOPT(DeclSpecKeyword   , 1, 0, "__declspec keyword")
- BENIGN_LANGOPT(DollarIdents   , 1, 1, "'$' in identifiers")
- BENIGN_LANGOPT(AsmPreprocessor, 1, 0, "preprocessor in asm mode")
-diff --git a/clang/lib/Basic/IdentifierTable.cpp b/clang/lib/Basic/IdentifierTable.cpp
-index 51c6e02..cedc94a 100644
---- a/clang/lib/Basic/IdentifierTable.cpp
-+++ b/clang/lib/Basic/IdentifierTable.cpp
-@@ -227,6 +227,9 @@ void IdentifierTable::AddKeywords(const LangOptions &LangOpts) {
-   if (LangOpts.DeclSpecKeyword)
-     AddKeyword("__declspec", tok::kw___declspec, KEYALL, LangOpts, *this);
- 
-+  if (LangOpts.IEEE128)
-+    AddKeyword("__ieee128", tok::kw___float128, KEYALL, LangOpts, *this);
-+
-   // Add the 'import' contextual keyword.
-   get("import").setModulesImport(true);
- }
-diff --git a/clang/lib/Basic/Targets/PPC.cpp b/clang/lib/Basic/Targets/PPC.cpp
-index ff09c0f..38f286c 100644
---- a/clang/lib/Basic/Targets/PPC.cpp
-+++ b/clang/lib/Basic/Targets/PPC.cpp
-@@ -551,6 +551,7 @@ void PPCTargetInfo::adjust(LangOptions &Opts) {
-     LongDoubleFormat = Opts.PPCIEEELongDouble
-                            ? &llvm::APFloat::IEEEquad()
-                            : &llvm::APFloat::PPCDoubleDouble();
-+  Opts.IEEE128 = 1;
- }
- 
- ArrayRef<Builtin::Info> PPCTargetInfo::getTargetBuiltins() const {
-diff --git a/clang/test/Sema/128bitfloat.cpp b/clang/test/Sema/128bitfloat.cpp
-index 4a826b4..6a9ae74 100644
---- a/clang/test/Sema/128bitfloat.cpp
-+++ b/clang/test/Sema/128bitfloat.cpp
-@@ -6,6 +6,13 @@
- // RUN: %clang_cc1 -triple x86_64-windows-msvc -verify -std=c++11 %s
- 
- #if defined(__FLOAT128__) || defined(__SIZEOF_FLOAT128__)
-+
-+#if defined(__ppc__)
-+template <typename> struct __is_float128 { static constexpr bool value = false; };
-+template <> struct __is_float128<__float128> { static constexpr bool value = true; };
-+static_assert(__is_float128<__ieee128>::value, "__ieee128 aliases to __float128");
-+#endif
-+
- __float128 f;
- template<typename> struct __is_floating_point_helper {};
- template<> struct __is_floating_point_helper<__float128> {};
--- 
-1.8.3.1
-

SOURCES/macros.clang

@@ -0,0 +1,16 @@
+%clang_major_version @@CLANG_MAJOR_VERSION@@
+%clang_minor_version @@CLANG_MINOR_VERSION@@
+%clang_patch_version @@CLANG_PATCH_VERSION@@
+
+%clang_version %{clang_major_version}.%{clang_minor_version}.%{clang_patch_version}
+
+# This is the path to the clang resource directory that has clang's internal
+# headers and libraries.  This path should be used by packages that need to
+# install files into this directory.  This macro's value changes every time
+# clang's version changes.
+%clang_resource_dir %{_libdir}/clang/%{clang_version}
+
+# This is the path to the clang resource directory that should be used
+# by packages that need to read files from this directory at runtime.
+# This macro only changes when clang's major version changes.
+%clang_resource_dir_readonly %{_libdir}/clang/%{clang_major_version}

SPECS/clang.spec

@@ -1,9 +1,11 @@
-%global compat_build 0
+%bcond_with compat_build
+%bcond_without check
 
-%global maj_ver 12
+%global maj_ver 13
 %global min_ver 0
-%global patch_ver 1
+%global patch_ver 0
-#%%global rc_ver 5
+#global rc_ver 4
+%global clang_version %{maj_ver}.%{min_ver}.%{patch_ver}
 
 %global clang_tools_binaries \
 	%{_bindir}/clang-apply-replacements \
@@ -20,6 +22,7 @@
 	%{_bindir}/clang-refactor \
 	%{_bindir}/clang-rename \
 	%{_bindir}/clang-reorder-fields \
+	%{_bindir}/clang-repl \
 	%{_bindir}/clang-scan-deps \
 	%{_bindir}/clang-tidy \
 	%{_bindir}/clangd \
@@ -35,7 +38,7 @@
 	%{_bindir}/clang-cl \
 	%{_bindir}/clang-cpp \
 
-%if 0%{?compat_build}
+%if %{with compat_build}
 %global pkg_name clang%{maj_ver}
 # Install clang to same prefix as llvm, so that apps that use llvm-config
 # will also be able to find clang libs.
@@ -53,40 +56,52 @@
 %global pkg_libdir %{_libdir}
 %endif
 
+%global build_install_prefix %{buildroot}%{install_prefix}
+
+%ifarch ppc64le aarch64
+# Too many threads on some systems causes OOM errors.
+%global _smp_mflags -j8
+%endif
+
+%global clang_srcdir clang-%{clang_version}%{?rc_ver:rc%{rc_ver}}.src
+%global clang_tools_srcdir clang-tools-extra-%{clang_version}%{?rc_ver:rc%{rc_ver}}.src
+
+%if !%{maj_ver} && 0%{?rc_ver}
+%global abi_revision 2
+%endif
+
 %if 0%{?fedora} || 0%{?rhel} > 7
 %bcond_without python3
 %else
 %bcond_with python3
 %endif
 
-%global build_install_prefix %{buildroot}%{install_prefix}
-
-%global _smp_mflags -j2
-
-%global clang_srcdir clang-%{version}%{?rc_ver:rc%{rc_ver}}.src
-%global clang_tools_srcdir clang-tools-extra-%{version}%{?rc_ver:rc%{rc_ver}}.src
-
 Name:		%pkg_name
 Version:	%{maj_ver}.%{min_ver}.%{patch_ver}%{?rc_ver:~rc%{rc_ver}}
-Release:	4%{?dist}
+Release:	2%{?dist}
 Summary:	A C language family front-end for LLVM
 
 License:	NCSA
 URL:		http://llvm.org
-Source0:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{version}%{?rc_ver:-rc%{rc_ver}}/%{clang_srcdir}.tar.xz
+Source0:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{clang_version}%{?rc_ver:-rc%{rc_ver}}/%{clang_srcdir}.tar.xz
-Source3:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{version}%{?rc_ver:-rc%{rc_ver}}/%{clang_srcdir}.tar.xz.sig
+Source3:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{clang_version}%{?rc_ver:-rc%{rc_ver}}/%{clang_srcdir}.tar.xz.sig
-%if !0%{?compat_build}
+%if %{without compat_build}
-Source1:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{version}%{?rc_ver:-rc%{rc_ver}}/%{clang_tools_srcdir}.tar.xz
+Source1:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{clang_version}%{?rc_ver:-rc%{rc_ver}}/%{clang_tools_srcdir}.tar.xz
-Source2:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{version}%{?rc_ver:-rc%{rc_ver}}/%{clang_tools_srcdir}.tar.xz.sig
+Source2:	https://github.com/llvm/llvm-project/releases/download/llvmorg-%{clang_version}%{?rc_ver:-rc%{rc_ver}}/%{clang_tools_srcdir}.tar.xz.sig
 %endif
 Source4:	tstellar-gpg-key.asc
+%if !0%{?compat_build}
+Source5:	macros.%{name}
+%endif
 
 # Patches for clang
 Patch0:     0001-PATCH-clang-Reorganize-gtest-integration.patch
 Patch1:     0002-PATCH-clang-Make-funwind-tables-the-default-on-all-a.patch
 Patch2:     0003-PATCH-clang-Don-t-install-static-libraries.patch
-Patch3:     0004-PATCH-clang-Prefer-gcc-toolchains-with-libgcc_s.so-w.patch
+Patch3:     0001-Driver-Add-a-gcc-equivalent-triple-to-the-list-of-tr.patch
-Patch5:     0006-PATCH-clang-Allow-__ieee128-as-an-alias-to-__float12.patch
+Patch4:     0001-cmake-Allow-shared-libraries-to-customize-the-soname.patch
+Patch5:     0001-PATCH-clang-Fix-scan-build-py-executable-lookup-path.patch
+
 
 # Patches for clang-tools-extra
 %if !0%{?compat_build}
@@ -95,18 +110,11 @@ Patch201    clangd-tests.patch
 %endif
 %endif
 
-Patch202:   0001-Confusable-identifiers-detection.patch
-Patch203:   0002-Misleading-bidirectional-detection.patch
-Patch204:   0003-Misleading-unicode-identifier-detection-pass.patch
-
-
-# Not Upstream
-
 BuildRequires:	gcc
 BuildRequires:	gcc-c++
 BuildRequires:	cmake
 BuildRequires:	ninja-build
-%if 0%{?compat_build}
+%if %{with compat_build}
 BuildRequires:	llvm%{maj_ver}-devel = %{version}
 BuildRequires:	llvm%{maj_ver}-static = %{version}
 %else
@@ -202,7 +210,7 @@ Runtime library for clang.
 
 %package devel
 Summary: Development header files for clang
-%if !0%{?compat_build}
+%if %{without compat_build}
 Requires: %{name}%{?_isa} = %{version}-%{release}
 # The clang CMake files reference tools from clang-tools-extra.
 Requires: %{name}-tools-extra%{?_isa} = %{version}-%{release}
@@ -219,7 +227,7 @@ Provides: %{name}-resource-filesystem(major) = %{maj_ver}
 %description resource-filesystem
 This package owns the clang resouce directory: $libdir/clang/$version/
 
-%if !0%{?compat_build}
+%if %{without compat_build}
 %package analyzer
 Summary:	A source code analysis framework
 License:	NCSA and MIT
@@ -265,7 +273,7 @@ Requires:      python3
 
 
 %prep
-%if 0%{?compat_build}
+%if %{with compat_build}
 %autosetup -n %{clang_srcdir} -p2
 %else
 %setup -T -q -b 1 -n %{clang_tools_srcdir}
@@ -288,7 +296,9 @@ pathfix.py -i %{__python3} -pn \
 	tools/clang-format/*.py \
 	tools/clang-format/git-clang-format \
 	utils/hmaptool/hmaptool \
-	tools/scan-view/bin/scan-view
+	tools/scan-view/bin/scan-view \
+	tools/scan-build-py/bin/* \
+	tools/scan-build-py/libexec/*
 %endif
 
 %build
@@ -333,9 +343,9 @@ cd %{_vpath_builddir}
 	-DCMAKE_C_FLAGS_RELWITHDEBINFO="%{optflags} -DNDEBUG" \
 	-DCMAKE_CXX_FLAGS_RELWITHDEBINFO="%{optflags} -DNDEBUG" \
 %endif
-%if 0%{?compat_build}
+%if %{with compat_build}
 	-DCLANG_BUILD_TOOLS:BOOL=OFF \
-	-DLLVM_CONFIG:FILEPATH=%{_bindir}/llvm-config-%{maj_ver}-%{__isa_bits} \
+	-DLLVM_CONFIG:FILEPATH=%{_bindir}/llvm-config-%{maj_ver} \
 	-DCMAKE_INSTALL_PREFIX=%{install_prefix} \
 	-DCLANG_INCLUDE_TESTS:BOOL=OFF \
 %else
@@ -350,7 +360,7 @@ cd %{_vpath_builddir}
 %endif
 %endif
 	\
-%if 0%{compat_build}
+%if %{with compat_build}
 	-DLLVM_TABLEGEN_EXE:FILEPATH=%{_bindir}/llvm-tblgen-%{maj_ver} \
 %else
 	-DLLVM_TABLEGEN_EXE:FILEPATH=%{_bindir}/llvm-tblgen \
@@ -363,8 +373,10 @@ cd %{_vpath_builddir}
 	-DLLVM_ENABLE_EH=ON \
 	-DLLVM_ENABLE_RTTI=ON \
 	-DLLVM_BUILD_DOCS=ON \
+	-DLLVM_ENABLE_NEW_PASS_MANAGER=ON \
 	-DLLVM_ENABLE_SPHINX=ON \
 	-DCLANG_LINK_CLANG_DYLIB=ON \
+	%{?abi_revision:-DLLVM_ABI_REVISION=%{abi_revision}} \
 	-DSPHINX_WARNINGS_AS_ERRORS=OFF \
 	\
 	-DCLANG_BUILD_EXAMPLES:BOOL=OFF \
@@ -380,25 +392,33 @@ pushd %{_vpath_builddir}
 %cmake_install
 popd
 
-%if 0%{?compat_build}
+%if %{with compat_build}
 
 # Remove binaries/other files
 rm -Rf %{buildroot}%{install_bindir}
 rm -Rf %{buildroot}%{install_prefix}/share
 rm -Rf %{buildroot}%{install_prefix}/libexec
 
-# Move include files
-mkdir -p %{buildroot}%{pkg_includedir}
-mv  %{buildroot}/%{install_includedir}/clang %{buildroot}/%{pkg_includedir}/
-mv  %{buildroot}/%{install_includedir}/clang-c %{buildroot}/%{pkg_includedir}/
-
 %else
 
+# File in the macros file for other packages to use.  We are not doing this
+# in the compat package, because the version macros would # conflict with
+# eachother if both clang and the clang compat package were installed together.
+install -p -m0644 -D %{SOURCE5} %{buildroot}%{_rpmmacrodir}/macros.%{name}
+sed -i -e "s|@@CLANG_MAJOR_VERSION@@|%{maj_ver}|" \
+       -e "s|@@CLANG_MINOR_VERSION@@|%{min_ver}|" \
+       -e "s|@@CLANG_PATCH_VERSION@@|%{patch_ver}|" \
+       %{buildroot}%{_rpmmacrodir}/macros.%{name}
+
 # install clang python bindings
 mkdir -p %{buildroot}%{python3_sitelib}/clang/
 install -p -m644 bindings/python/clang/* %{buildroot}%{python3_sitelib}/clang/
 %py_byte_compile %{__python3} %{buildroot}%{python3_sitelib}/clang
 
+# install scanbuild-py to python sitelib.
+mv %{buildroot}%{_prefix}/lib/{libear,libscanbuild} %{buildroot}%{python3_sitelib}
+%py_byte_compile %{__python3} %{buildroot}%{python3_sitelib}/{libear,libscanbuild}
+
 # multilib fix
 %multilib_fix_c_header --file %{_includedir}/clang/Config/config.h
 
@@ -441,25 +461,30 @@ pushd %{buildroot}%{_libdir}/clang/
 ln -s %{version} %{maj_ver}
 popd
 
+%endif
+
 # Create sub-directories in the clang resource directory that will be
 # populated by other packages
-mkdir -p %{buildroot}%{_libdir}/clang/%{version}/{include,lib,share}/
+mkdir -p %{buildroot}%{pkg_libdir}/clang/%{version}/{include,lib,share}/
 
-%endif
 
 # Remove clang-tidy headers.  We don't ship the libraries for these.
 rm -Rvf %{buildroot}%{_includedir}/clang-tidy/
 
+%if %{without compat_build}
 # Add a symlink in /usr/bin to clang-format-diff
 ln -s %{_datadir}/clang/clang-format-diff.py %{buildroot}%{_bindir}/clang-format-diff
+%endif
 
 %check
 cd %{_vpath_builddir}
 
-%if !0%{?compat_build}
+%if %{without compat_build}
+%if %{with check}
 # requires lit.py from LLVM utilities
 # FIXME: Fix failing ARM tests
 LD_LIBRARY_PATH=%{buildroot}/%{_libdir} %cmake_build --target check-all || \
+%endif
 %ifarch %{arm}
 :
 %else
@@ -469,7 +494,7 @@ false
 %endif
 
 
-%if !0%{?compat_build}
+%if %{without compat_build}
 %files
 %license LICENSE.TXT
 %{clang_binaries}
@@ -480,7 +505,7 @@ false
 %endif
 
 %files libs
-%if !0%{?compat_build}
+%if %{without compat_build}
 %{_libdir}/clang/
 %{_libdir}/*.so.*
 %else
@@ -489,12 +514,13 @@ false
 %endif
 
 %files devel
-%if !0%{?compat_build}
+%if %{without compat_build}
 %{_libdir}/*.so
 %{_includedir}/clang/
 %{_includedir}/clang-c/
 %{_libdir}/cmake/*
 %dir %{_datadir}/clang/
+%{_rpmmacrodir}/macros.%{name}
 %else
 %{pkg_libdir}/*.so
 %{pkg_includedir}/clang/
@@ -507,19 +533,28 @@ false
 %dir %{pkg_libdir}/clang/%{version}/include/
 %dir %{pkg_libdir}/clang/%{version}/lib/
 %dir %{pkg_libdir}/clang/%{version}/share/
-%if !0%{?compat_build}
+%if %{without compat_build}
 %{pkg_libdir}/clang/%{maj_ver}
 %endif
 
-%if !0%{?compat_build}
+%if %{without compat_build}
 %files analyzer
 %{_bindir}/scan-view
 %{_bindir}/scan-build
+%{_bindir}/analyze-build
+%{_bindir}/intercept-build
+%{_bindir}/scan-build-py
 %{_libexecdir}/ccc-analyzer
 %{_libexecdir}/c++-analyzer
+%{_libexecdir}/analyze-c++
+%{_libexecdir}/analyze-cc
+%{_libexecdir}/intercept-c++
+%{_libexecdir}/intercept-cc
 %{_datadir}/scan-view/
 %{_datadir}/scan-build/
 %{_mandir}/man1/scan-build.1.*
+%{python3_sitelib}/libear
+%{python3_sitelib}/libscanbuild
 
 %files tools-extra
 %{clang_tools_binaries}
@@ -535,7 +570,7 @@ false
 %{_datadir}/clang/clang-format-diff.py*
 %{_datadir}/clang/clang-include-fixer.py*
 %{_datadir}/clang/clang-tidy-diff.py*
-%{_datadir}/clang/run-clang-tidy.py*
+%{_bindir}/run-clang-tidy
 %{_datadir}/clang/run-find-all-symbols.py*
 %{_datadir}/clang/clang-rename.py*
 
@@ -548,14 +583,11 @@ false
 
 %endif
 %changelog
-* Wed Nov 10 2021 sguelton@redhat.com - 12.0.1-4
+* Fri Oct 22 2021 Tom Stellard <tstellar@redhat.com> - 13.0.0-2
-- Trojan source clang-tidy patchset fix
+- Don't emit unwind tables for bpf
 
-* Thu Nov 4 2021 sguelton@redhat.com - 12.0.1-3
+* Fri Oct 15 2021 Tom Stellard <tstellar@redhat.com> - 13.0.0-1
-- Trojan source clang-tidy patchset
+- 13.0.0 Release
-
-* Fri Sep 17 2021 Tom Stellard <tstellar@redhat.com> - 12.0.1-2
-- Only enable -funwind-tables by default on some arches
 
 * Fri Jul 16 2021 sguelton@redhat.com - 12.0.1-1
 - 12.0.1 release