From 7cdb2a8fd2af0a063d6e505fd1250ca10ebbea11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Date: Tue, 6 Jul 2021 19:54:23 +0200 Subject: [PATCH] checkpolicy: simplify assignment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit checkpolicy.c:504:20: style: The statement 'if (policyvers!=n) policyvers=n' is logically equivalent to 'policyvers=n'. [duplicateConditionalAssign] if (policyvers != n) ^ checkpolicy.c:505:17: note: Assignment 'policyvers=n' policyvers = n; ^ checkpolicy.c:504:20: note: Condition 'policyvers!=n' is redundant if (policyvers != n) ^ Found by Cppcheck Signed-off-by: Christian Göttsche --- checkpolicy/checkpolicy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/checkpolicy/checkpolicy.c b/checkpolicy/checkpolicy.c index 8af31db5c6b7..b52595a87b29 100644 --- a/checkpolicy/checkpolicy.c +++ b/checkpolicy/checkpolicy.c @@ -504,8 +504,7 @@ int main(int argc, char **argv) usage(argv[0]); exit(1); } - if (policyvers != n) - policyvers = n; + policyvers = n; break; } case 'E': -- 2.32.0