Go 1.15 deprecates checking CN; this broke gating tests:
Get "https://localhost:5000/v2/": x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0
Easy two-line solution in the 'openssl' invocation. Huge
thanks to Nalin for tracking down and fixing while I was
still getting started:
https://github.com/containers/buildah/pull/2595
Signed-off-by: Ed Santiago <santiago@redhat.com>
Newer buildah tests now depend on encryption functionality
only present in later (2.7? 2.8?) versions of docker.io/registry.
So, undo our earlier change in which we forced registry:2.6
to use its htpasswd. Instead, tests now require httpd-tools
package and we use native host htpasswd. We revert back to
using registry:2 (no dot), which is a moving target, so be
prepared for future breakage.
Signed-off-by: Ed Santiago <santiago@redhat.com>
The docker.io/registry:2 image broke suddenly and with no warning:
https://github.com/docker/distribution-library-image/issues/106
Symptom: running 'htpasswd' from that container no longer works,
even though it's been documented for years (at docker.com) and
as of this writing still remains documented.
One solution is to run htpasswd locally (requires installing the
httpd-tools package) or using any crypt library to hash. Not
hard, but tedious, and it doesn't address the issue of the
docker registry:2 image being a moving target.
I choose to force the use of the :2.6 tag, in hopes that that
image will remain unmodified. Refactored to use FQIN instead
of shortname, and to define it in only one place.
Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit gets rid of the existing, unused, nonworking
and nonmaintained tests. The person who created them
is (AFAICT) no longer with Red Hat; and the tests weren't
being run in gating; and they aren't even in working
condition.
Replace with our standard convention: install the -tests
package, and run it with BATS. This setup is more complex
than podman/skopeo because we need to fire up a local
registry before the tests begin, then tear it down at
the end.
I am expecting these tests to fail in actual gating due
to what I believe are actual buildah problems.
Signed-off-by: Ed Santiago <santiago@redhat.com>
* the tests is quite old since it moved from upstreamfirst
* lots of new cases are added, like option 'run', 'inspect' etc
* save log to TEST_ARTIFACTS when the variable is set
* always run tests with latest runc built from source
* merge task and task status to same line
