diff --git a/.bcc.metadata b/.bcc.metadata index 4b4b7d0..c84dac0 100644 --- a/.bcc.metadata +++ b/.bcc.metadata @@ -1 +1 @@ -e200806e56095091ff22a73c4c8ec294176527e2 SOURCES/bcc-0.11.0.tar.gz +a94aa5005d66f17284f2244ff2018821f35ff4df SOURCES/bcc-src-with-submodule.tar.gz diff --git a/.gitignore b/.gitignore index 88fc8f9..ff7e7e9 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1 @@ -SOURCES/bcc-0.11.0.tar.gz +SOURCES/bcc-src-with-submodule.tar.gz diff --git a/SOURCES/bcc-0.11.0-man-add-missing-c-option-to-tcpretrans-synopsis.patch b/SOURCES/bcc-0.11.0-man-add-missing-c-option-to-tcpretrans-synopsis.patch deleted file mode 100644 index 21bed81..0000000 --- a/SOURCES/bcc-0.11.0-man-add-missing-c-option-to-tcpretrans-synopsis.patch +++ /dev/null @@ -1,25 +0,0 @@ -From 930846dc2c49281c693c2e39a0a2d21c650c61de Mon Sep 17 00:00:00 2001 -From: Jerome Marchand -Date: Fri, 9 Aug 2019 13:15:13 +0200 -Subject: [PATCH] man: add missing -c option to tcpretrans synopsis - ---- - man/man8/tcpretrans.8 | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/man/man8/tcpretrans.8 b/man/man8/tcpretrans.8 -index e4f6fbf6..0ac82afa 100644 ---- a/man/man8/tcpretrans.8 -+++ b/man/man8/tcpretrans.8 -@@ -2,7 +2,7 @@ - .SH NAME - tcpretrans \- Trace or count TCP retransmits and TLPs. Uses Linux eBPF/bcc. - .SH SYNOPSIS --.B tcpretrans [\-h] [\-l] -+.B tcpretrans [\-h] [\-l] [\-c] - .SH DESCRIPTION - This traces TCP retransmits, showing address, port, and TCP state information, - and sometimes the PID (although usually not, since retransmits are usually --- -2.23.0 - diff --git a/SOURCES/bcc-0.11.0-Manpages-remove-unstable-statement.patch b/SOURCES/bcc-0.14.0-Manpages-remove-unstable-statement.patch similarity index 91% rename from SOURCES/bcc-0.11.0-Manpages-remove-unstable-statement.patch rename to SOURCES/bcc-0.14.0-Manpages-remove-unstable-statement.patch index 036cbb9..2981e68 100644 --- a/SOURCES/bcc-0.11.0-Manpages-remove-unstable-statement.patch +++ b/SOURCES/bcc-0.14.0-Manpages-remove-unstable-statement.patch @@ -1,4 +1,4 @@ -From 4457d22318c0014bf498928fc66f66086df22bf1 Mon Sep 17 00:00:00 2001 +From 0f53d4de3416d78d0af5c0f70b9a29cb988719c3 Mon Sep 17 00:00:00 2001 From: Jerome Marchand Date: Tue, 6 Aug 2019 14:44:33 +0200 Subject: [PATCH] Manpages: remove unstable statement @@ -8,7 +8,9 @@ enough. --- man/man8/argdist.8 | 2 -- man/man8/bashreadline.8 | 2 -- + man/man8/bindsnoop.8 | 2 -- man/man8/biolatency.8 | 2 -- + man/man8/biolatpcts.8 | 2 -- man/man8/biosnoop.8 | 2 -- man/man8/biotop.8 | 2 -- man/man8/bitesize.8 | 2 -- @@ -19,6 +21,7 @@ enough. man/man8/cachestat.8 | 2 -- man/man8/cachetop.8 | 2 -- man/man8/capable.8 | 2 -- + man/man8/compactsnoop.8 | 2 -- man/man8/cpudist.8 | 2 -- man/man8/cpuunclaimed.8 | 2 -- man/man8/criticalstat.8 | 2 -- @@ -42,6 +45,7 @@ enough. man/man8/hardirqs.8 | 2 -- man/man8/inject.8 | 4 ---- man/man8/killsnoop.8 | 2 -- + man/man8/klockstat.8 | 2 -- man/man8/llcstat.8 | 2 -- man/man8/mdflush.8 | 2 -- man/man8/memleak.8 | 2 -- @@ -96,7 +100,7 @@ enough. man/man8/xfsslower.8 | 2 -- man/man8/zfsdist.8 | 2 -- man/man8/zfsslower.8 | 2 -- - 90 files changed, 182 deletions(-) + 94 files changed, 190 deletions(-) diff --git a/man/man8/argdist.8 b/man/man8/argdist.8 index 4116cd4d..aa128d2d 100644 @@ -111,7 +115,7 @@ index 4116cd4d..aa128d2d 100644 .SH AUTHOR Sasha Goldshtein diff --git a/man/man8/bashreadline.8 b/man/man8/bashreadline.8 -index 185598aa..9141ac63 100644 +index bc68a491..705c514e 100644 --- a/man/man8/bashreadline.8 +++ b/man/man8/bashreadline.8 @@ -53,8 +53,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -123,8 +127,21 @@ index 185598aa..9141ac63 100644 .SH AUTHOR Brendan Gregg .SH SEE ALSO +diff --git a/man/man8/bindsnoop.8 b/man/man8/bindsnoop.8 +index ec7ca1da..2ac4b69e 100644 +--- a/man/man8/bindsnoop.8 ++++ b/man/man8/bindsnoop.8 +@@ -136,8 +136,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing + example usage, output, and commentary for this tool. + .SH OS + Linux +-.SH STABILITY +-Unstable - in development. + .SH AUTHOR + Pavel Dubovitsky + .SH SEE ALSO diff --git a/man/man8/biolatency.8 b/man/man8/biolatency.8 -index 7aa3dd89..8f3166f9 100644 +index fe4da6b2..6ffa3429 100644 --- a/man/man8/biolatency.8 +++ b/man/man8/biolatency.8 @@ -91,8 +91,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -136,8 +153,21 @@ index 7aa3dd89..8f3166f9 100644 .SH AUTHOR Brendan Gregg .SH SEE ALSO +diff --git a/man/man8/biolatpcts.8 b/man/man8/biolatpcts.8 +index 7a06a11d..9dd41d08 100644 +--- a/man/man8/biolatpcts.8 ++++ b/man/man8/biolatpcts.8 +@@ -81,8 +81,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing + example usage, output, and commentary for this tool. + .SH OS + Linux +-.SH STABILITY +-Unstable - in development. + .SH AUTHOR + Tejun Heo + .SH SEE ALSO diff --git a/man/man8/biosnoop.8 b/man/man8/biosnoop.8 -index 2a41348c..ec16596c 100644 +index 4c073f76..2b2f7434 100644 --- a/man/man8/biosnoop.8 +++ b/man/man8/biosnoop.8 @@ -79,8 +79,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -213,7 +243,7 @@ index 480264f9..cbf75121 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/btrfsslower.8 b/man/man8/btrfsslower.8 -index 9f0a89a6..409b0bb0 100644 +index a1ea106a..33864589 100644 --- a/man/man8/btrfsslower.8 +++ b/man/man8/btrfsslower.8 @@ -114,8 +114,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -252,10 +282,10 @@ index 5642fa1d..1fe4067b 100644 Emmanuel Bretelle .SH SEE ALSO diff --git a/man/man8/capable.8 b/man/man8/capable.8 -index e20eb78f..6f6137ed 100644 +index dfb8a6aa..7e545638 100644 --- a/man/man8/capable.8 +++ b/man/man8/capable.8 -@@ -72,8 +72,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -84,8 +84,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -264,6 +294,18 @@ index e20eb78f..6f6137ed 100644 .SH AUTHOR Brendan Gregg .SH SEE ALSO +diff --git a/man/man8/compactsnoop.8 b/man/man8/compactsnoop.8 +index a2933d7a..c1339579 100644 +--- a/man/man8/compactsnoop.8 ++++ b/man/man8/compactsnoop.8 +@@ -173,7 +173,5 @@ Also look in the bcc distribution for a companion _examples.txt file containing + example usage, output, and commentary for this tool. + .SH OS + Linux +-.SH STABILITY +-Unstable - in development. + .SH AUTHOR + Wenbo Zhang diff --git a/man/man8/cpudist.8 b/man/man8/cpudist.8 index 6ee1f3bf..979f0451 100644 --- a/man/man8/cpudist.8 @@ -291,7 +333,7 @@ index 674be499..107ff67b 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/criticalstat.8 b/man/man8/criticalstat.8 -index 52baf1d8..d9dfec91 100644 +index cdd5e8ed..8f918707 100644 --- a/man/man8/criticalstat.8 +++ b/man/man8/criticalstat.8 @@ -65,8 +65,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -304,7 +346,7 @@ index 52baf1d8..d9dfec91 100644 Joel Fernandes .SH SEE ALSO diff --git a/man/man8/dbslower.8 b/man/man8/dbslower.8 -index c21e6fae..947180df 100644 +index e39b8bd0..e73b77f1 100644 --- a/man/man8/dbslower.8 +++ b/man/man8/dbslower.8 @@ -72,8 +72,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -368,7 +410,7 @@ index 0be3f4ab..7300446a 100644 .SH AUTHOR Kenny Yu diff --git a/man/man8/drsnoop.8 b/man/man8/drsnoop.8 -index 98e27e56..b8276b3e 100644 +index 572c0dce..3563da81 100644 --- a/man/man8/drsnoop.8 +++ b/man/man8/drsnoop.8 @@ -104,7 +104,5 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -378,12 +420,12 @@ index 98e27e56..b8276b3e 100644 -.SH STABILITY -Unstable - in development. .SH AUTHOR - Ethercflow + Wenbo Zhang diff --git a/man/man8/execsnoop.8 b/man/man8/execsnoop.8 -index 500a9321..938fde0d 100644 +index 4a88e007..f8db4944 100644 --- a/man/man8/execsnoop.8 +++ b/man/man8/execsnoop.8 -@@ -109,8 +109,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -137,8 +137,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -419,7 +461,7 @@ index 61ecb727..ba17fc3d 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/ext4slower.8 b/man/man8/ext4slower.8 -index 7591f284..231337bf 100644 +index a16bd5ef..b6276269 100644 --- a/man/man8/ext4slower.8 +++ b/man/man8/ext4slower.8 @@ -105,8 +105,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -432,7 +474,7 @@ index 7591f284..231337bf 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/filelife.8 b/man/man8/filelife.8 -index 1e4e423e..5a792a48 100644 +index 9495d4e2..6438b374 100644 --- a/man/man8/filelife.8 +++ b/man/man8/filelife.8 @@ -64,8 +64,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -445,7 +487,7 @@ index 1e4e423e..5a792a48 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/fileslower.8 b/man/man8/fileslower.8 -index 169013bd..b30bf4c7 100644 +index fe912436..d567986b 100644 --- a/man/man8/fileslower.8 +++ b/man/man8/fileslower.8 @@ -106,8 +106,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -458,10 +500,10 @@ index 169013bd..b30bf4c7 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/filetop.8 b/man/man8/filetop.8 -index e70d908f..69b1aae5 100644 +index ba0cbd6e..1f818d68 100644 --- a/man/man8/filetop.8 +++ b/man/man8/filetop.8 -@@ -108,8 +108,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -111,8 +111,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -510,7 +552,7 @@ index 06f17934..0e85989d 100644 Sasha Goldshtein .SH SEE ALSO diff --git a/man/man8/gethostlatency.8 b/man/man8/gethostlatency.8 -index c5a53303..87b26829 100644 +index a9d18e07..876f3983 100644 --- a/man/man8/gethostlatency.8 +++ b/man/man8/gethostlatency.8 @@ -55,8 +55,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -550,7 +592,7 @@ index 2ab80dbb..85b36b6e 100644 .SH AUTHOR Howard McLauchlan diff --git a/man/man8/killsnoop.8 b/man/man8/killsnoop.8 -index b7048ed7..1fe8979f 100644 +index b90162f0..ff44a306 100644 --- a/man/man8/killsnoop.8 +++ b/man/man8/killsnoop.8 @@ -75,8 +75,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -562,6 +604,19 @@ index b7048ed7..1fe8979f 100644 .SH AUTHOR Brendan Gregg .SH SEE ALSO +diff --git a/man/man8/klockstat.8 b/man/man8/klockstat.8 +index 0a3167d1..57f9db18 100644 +--- a/man/man8/klockstat.8 ++++ b/man/man8/klockstat.8 +@@ -182,8 +182,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing + example usage, output, and commentary for this tool. + .SH OS + Linux +-.SH STABILITY +-Unstable - in development. + .SH CREDITS + This tool is based on work of David Valin and his script. + .SH AUTHOR diff --git a/man/man8/llcstat.8 b/man/man8/llcstat.8 index 36dbed7d..2b554c46 100644 --- a/man/man8/llcstat.8 @@ -601,7 +656,7 @@ index fa52c8cf..718ae3c2 100644 .SH AUTHOR Sasha Goldshtein diff --git a/man/man8/mountsnoop.8 b/man/man8/mountsnoop.8 -index 450301a0..8336f2fd 100644 +index 01efdf9c..8afafba0 100644 --- a/man/man8/mountsnoop.8 +++ b/man/man8/mountsnoop.8 @@ -46,8 +46,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -640,7 +695,7 @@ index c72cfaa6..34532c18 100644 Samuel Nair .SH SEE ALSO diff --git a/man/man8/nfsslower.8 b/man/man8/nfsslower.8 -index 19eb6359..416c081e 100644 +index 22b36e3e..66021002 100644 --- a/man/man8/nfsslower.8 +++ b/man/man8/nfsslower.8 @@ -114,8 +114,6 @@ Also look in the bcc distribution for a companion nfsslower_examples.txt file co @@ -692,10 +747,10 @@ index b6d6f9e1..965ba545 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/opensnoop.8 b/man/man8/opensnoop.8 -index 37b40a47..10741406 100644 +index 54a7788a..8a1b9949 100644 --- a/man/man8/opensnoop.8 +++ b/man/man8/opensnoop.8 -@@ -137,8 +137,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -145,8 +145,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -718,10 +773,10 @@ index 2164ffaf..9d272c81 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/profile.8 b/man/man8/profile.8 -index 88311e7e..9cd3ca44 100644 +index 823ff699..7739058f 100644 --- a/man/man8/profile.8 +++ b/man/man8/profile.8 -@@ -141,8 +141,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -148,8 +148,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -756,7 +811,7 @@ index d535ebbf..9e146a5e 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/runqlen.8 b/man/man8/runqlen.8 -index 27a649da..395a68bb 100644 +index b36a5a18..c2f0ffb4 100644 --- a/man/man8/runqlen.8 +++ b/man/man8/runqlen.8 @@ -78,8 +78,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -769,20 +824,20 @@ index 27a649da..395a68bb 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/runqslower.8 b/man/man8/runqslower.8 -index 0baee64a..9aa7e9f7 100644 +index f8b5f008..c72389d7 100644 --- a/man/man8/runqslower.8 +++ b/man/man8/runqslower.8 -@@ -78,8 +78,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -81,8 +81,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux -.SH STABILITY -Unstable - in development. .SH AUTHOR - Ivan Babrou - .SH SEE ALSO + Ivan Babrou, original BCC Python version + Andrii Nakryiko, CO-RE version diff --git a/man/man8/shmsnoop.8 b/man/man8/shmsnoop.8 -index 390974f6..a495ab4f 100644 +index e7092e19..944e9f07 100644 --- a/man/man8/shmsnoop.8 +++ b/man/man8/shmsnoop.8 @@ -66,8 +66,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -880,7 +935,7 @@ index d2459561..2cf789c1 100644 Brendan Gregg, Sasha Goldshtein .SH SEE ALSO diff --git a/man/man8/statsnoop.8 b/man/man8/statsnoop.8 -index 00921d69..4efee52e 100644 +index c0555043..d1560b3c 100644 --- a/man/man8/statsnoop.8 +++ b/man/man8/statsnoop.8 @@ -83,8 +83,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -893,7 +948,7 @@ index 00921d69..4efee52e 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/syncsnoop.8 b/man/man8/syncsnoop.8 -index 3d4c8c4f..2ad2b298 100644 +index 8543f213..cd7b0629 100644 --- a/man/man8/syncsnoop.8 +++ b/man/man8/syncsnoop.8 @@ -45,8 +45,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -919,10 +974,10 @@ index d13793be..88343e14 100644 Sasha Goldshtein .SH SEE ALSO diff --git a/man/man8/tcpaccept.8 b/man/man8/tcpaccept.8 -index 6e340bd0..550e9b55 100644 +index 43219260..4176a32b 100644 --- a/man/man8/tcpaccept.8 +++ b/man/man8/tcpaccept.8 -@@ -94,8 +94,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -101,8 +101,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -932,10 +987,10 @@ index 6e340bd0..550e9b55 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/tcpconnect.8 b/man/man8/tcpconnect.8 -index 9bf44e9c..60721bc8 100644 +index 60aac1e2..856873c0 100644 --- a/man/man8/tcpconnect.8 +++ b/man/man8/tcpconnect.8 -@@ -111,8 +111,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -118,8 +118,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -984,7 +1039,7 @@ index a2419c61..a2a2550c 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/tcpretrans.8 b/man/man8/tcpretrans.8 -index e4f6fbf6..b08b0fe4 100644 +index 0ac82afa..04226dc6 100644 --- a/man/man8/tcpretrans.8 +++ b/man/man8/tcpretrans.8 @@ -83,8 +83,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -1023,10 +1078,10 @@ index 525b8082..daf41583 100644 Rodrigo Manyari .SH INSPIRATION diff --git a/man/man8/tcptop.8 b/man/man8/tcptop.8 -index 672e8edd..f5e13880 100644 +index 631c00c3..eddab761 100644 --- a/man/man8/tcptop.8 +++ b/man/man8/tcptop.8 -@@ -102,8 +102,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -110,8 +110,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -1036,10 +1091,10 @@ index 672e8edd..f5e13880 100644 Brendan Gregg .SH INSPIRATION diff --git a/man/man8/tcptracer.8 b/man/man8/tcptracer.8 -index b5b30617..6f3bf82e 100644 +index 728c80af..cd444ee4 100644 --- a/man/man8/tcptracer.8 +++ b/man/man8/tcptracer.8 -@@ -90,8 +90,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -96,8 +96,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -1061,10 +1116,10 @@ index da5edf37..f7e459da 100644 .SH AUTHOR Sasha Goldshtein diff --git a/man/man8/trace.8 b/man/man8/trace.8 -index ebbb4383..9e28c956 100644 +index 0b27dbd6..fb33599a 100644 --- a/man/man8/trace.8 +++ b/man/man8/trace.8 -@@ -197,7 +197,5 @@ Also look in the bcc distribution for a companion _examples.txt file containing +@@ -206,7 +206,5 @@ Also look in the bcc distribution for a companion _examples.txt file containing example usage, output, and commentary for this tool. .SH OS Linux @@ -1216,7 +1271,7 @@ index 3c890007..75b2c66e 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/xfsslower.8 b/man/man8/xfsslower.8 -index 533a7011..cd2a5ed2 100644 +index 30ec3253..c914dcee 100644 --- a/man/man8/xfsslower.8 +++ b/man/man8/xfsslower.8 @@ -105,8 +105,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -1242,7 +1297,7 @@ index 1e5632fd..6c5de7d7 100644 Brendan Gregg .SH SEE ALSO diff --git a/man/man8/zfsslower.8 b/man/man8/zfsslower.8 -index 8f5c8cf3..95c0c09d 100644 +index d1e2f9c1..31d382f6 100644 --- a/man/man8/zfsslower.8 +++ b/man/man8/zfsslower.8 @@ -108,8 +108,6 @@ Also look in the bcc distribution for a companion _examples.txt file containing @@ -1255,5 +1310,5 @@ index 8f5c8cf3..95c0c09d 100644 Brendan Gregg .SH SEE ALSO -- -2.23.0 +2.25.3 diff --git a/SOURCES/bcc-0.14.0-deadlock-print-a-more-explicit-message-when-pthread_.patch b/SOURCES/bcc-0.14.0-deadlock-print-a-more-explicit-message-when-pthread_.patch new file mode 100644 index 0000000..b068ff6 --- /dev/null +++ b/SOURCES/bcc-0.14.0-deadlock-print-a-more-explicit-message-when-pthread_.patch @@ -0,0 +1,28 @@ +From c263daf925a7a74f7ae64b049cf3def8b298beee Mon Sep 17 00:00:00 2001 +From: Jerome Marchand +Date: Wed, 10 Jun 2020 10:28:42 +0200 +Subject: [PATCH 1/4] deadlock: print a more explicit message when + pthread_mutex_unlock can't be attached + +Most likely, this happen because of a missing --binary argument. Let's +be friendly to our user and print a more useful messsage. +--- + tools/deadlock.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/deadlock.py b/tools/deadlock.py +index 17848720..81122adb 100755 +--- a/tools/deadlock.py ++++ b/tools/deadlock.py +@@ -483,7 +483,7 @@ import time + pid=args.pid, + ) + except Exception as e: +- print('%s. Failed to attach to symbol: %s' % (str(e), symbol)) ++ print('%s. Failed to attach to symbol: %s\nIs --binary argument missing?' % (str(e), symbol)) + sys.exit(1) + for symbol in args.lock_symbols: + try: +-- +2.25.4 + diff --git a/SOURCES/bcc-0.14.0-loader-suggest-to-install-the-right-kernel-devel-pac.patch b/SOURCES/bcc-0.14.0-loader-suggest-to-install-the-right-kernel-devel-pac.patch new file mode 100644 index 0000000..6dc155c --- /dev/null +++ b/SOURCES/bcc-0.14.0-loader-suggest-to-install-the-right-kernel-devel-pac.patch @@ -0,0 +1,33 @@ +From f7e7347dc1b4873f70a26392c997228999d346a8 Mon Sep 17 00:00:00 2001 +From: Jerome Marchand +Date: Wed, 10 Jun 2020 11:41:59 +0200 +Subject: [PATCH 3/4] loader: suggest to install the right kernel devel package + +Unfortunately, some package dependency system do not allow to make +sure that the kernel development package installed is the same version +as the running kernel. When this happen, the loader, unable to find +the kernel header, will suggest to rebuild the kernel with +CONFIG_IKHEADERS. For most users, this is probably not an option, but +installing the kernel development package corresponding to the running +kernel version is. +--- + src/cc/frontends/clang/loader.cc | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/cc/frontends/clang/loader.cc b/src/cc/frontends/clang/loader.cc +index 9d768d30..79558dd3 100644 +--- a/src/cc/frontends/clang/loader.cc ++++ b/src/cc/frontends/clang/loader.cc +@@ -151,7 +151,8 @@ int ClangLoader::parse(unique_ptr *mod, TableStorage &ts, + kpath = tmpdir; + } else { + std::cout << "Unable to find kernel headers. "; +- std::cout << "Try rebuilding kernel with CONFIG_IKHEADERS=m (module)\n"; ++ std::cout << "Try rebuilding kernel with CONFIG_IKHEADERS=m (module) "; ++ std::cout << "or installing the kernel development package for your running kernel version.\n"; + } + } + +-- +2.25.4 + diff --git a/SOURCES/bcc-0.14.0-man-remove-non-existent-x-argument-from-tcpconnect-m.patch b/SOURCES/bcc-0.14.0-man-remove-non-existent-x-argument-from-tcpconnect-m.patch new file mode 100644 index 0000000..fcc49c5 --- /dev/null +++ b/SOURCES/bcc-0.14.0-man-remove-non-existent-x-argument-from-tcpconnect-m.patch @@ -0,0 +1,28 @@ +From 1762f5c28832842ea2c67ab68feaf7fddb94a543 Mon Sep 17 00:00:00 2001 +From: Jerome Marchand +Date: Wed, 10 Jun 2020 11:30:35 +0200 +Subject: [PATCH 2/4] man: remove non-existent -x argument from tcpconnect man + page + +There's no -x option in tcpconnect. I don't know how it get into the +man page sysnopsis, but it doesn't belong there. +--- + man/man8/tcpconnect.8 | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/man/man8/tcpconnect.8 b/man/man8/tcpconnect.8 +index 60aac1e2..8180f0fe 100644 +--- a/man/man8/tcpconnect.8 ++++ b/man/man8/tcpconnect.8 +@@ -2,7 +2,7 @@ + .SH NAME + tcpconnect \- Trace TCP active connections (connect()). Uses Linux eBPF/bcc. + .SH SYNOPSIS +-.B tcpconnect [\-h] [\-c] [\-t] [\-x] [\-p PID] [-P PORT] [\-\-cgroupmap MAPPATH] ++.B tcpconnect [\-h] [\-c] [\-t] [\-p PID] [-P PORT] [\-\-cgroupmap MAPPATH] + .SH DESCRIPTION + This tool traces active TCP connections (eg, via a connect() syscall; + accept() are passive connections). This can be useful for general +-- +2.25.4 + diff --git a/SOURCES/bcc-0.14.0-tools-fix-a-python-3-map-issue-in-dbstat-and-dbslowe.patch b/SOURCES/bcc-0.14.0-tools-fix-a-python-3-map-issue-in-dbstat-and-dbslowe.patch new file mode 100644 index 0000000..603368a --- /dev/null +++ b/SOURCES/bcc-0.14.0-tools-fix-a-python-3-map-issue-in-dbstat-and-dbslowe.patch @@ -0,0 +1,49 @@ +From fc72365ad7a3fb66902b3e2d0b0fb712eb8735d3 Mon Sep 17 00:00:00 2001 +From: Jerome Marchand +Date: Wed, 10 Jun 2020 18:29:11 +0200 +Subject: [PATCH 4/4] tools: fix a python 3 map issue in dbstat and dbslower + +In python 3, map returns an iterator and not a list anymore. This +patch cast the map into a list. It fixes the following error: + +$ /usr/share/bcc/tools/dbstat mysql +Traceback (most recent call last): + File "/usr/share/bcc/tools/dbstat", line 95, in + bpf = BPF(text=program, usdt_contexts=usdts) + File "/usr/lib/python3.6/site-packages/bcc/__init__.py", line 339, in __init__ + ctx_array = (ct.c_void_p * len(usdt_contexts))() +TypeError: object of type 'map' has no len() +--- + tools/dbslower.py | 2 +- + tools/dbstat.py | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tools/dbslower.py b/tools/dbslower.py +index 2f1b6a8b..e2ee7ad0 100755 +--- a/tools/dbslower.py ++++ b/tools/dbslower.py +@@ -188,7 +188,7 @@ int query_end(struct pt_regs *ctx) { + args.pids = map(int, subprocess.check_output( + "pidof postgres".split()).split()) + +- usdts = map(lambda pid: USDT(pid=pid), args.pids) ++ usdts = list(map(lambda pid: USDT(pid=pid), args.pids)) + for usdt in usdts: + usdt.enable_probe("query__start", "query_start") + usdt.enable_probe("query__done", "query_end") +diff --git a/tools/dbstat.py b/tools/dbstat.py +index a89b0971..a7d301b1 100755 +--- a/tools/dbstat.py ++++ b/tools/dbstat.py +@@ -83,7 +83,7 @@ program = program.replace("SCALE", str(1000 if args.microseconds else 1000000)) + program = program.replace("FILTER", "" if args.threshold == 0 else + "if (delta / 1000000 < %d) { return 0; }" % args.threshold) + +-usdts = map(lambda pid: USDT(pid=pid), args.pids) ++usdts = list(map(lambda pid: USDT(pid=pid), args.pids)) + for usdt in usdts: + usdt.enable_probe("query__start", "probe_start") + usdt.enable_probe("query__done", "probe_end") +-- +2.25.4 + diff --git a/SPECS/bcc.spec b/SPECS/bcc.spec index 7b7d311..95f2731 100644 --- a/SPECS/bcc.spec +++ b/SPECS/bcc.spec @@ -4,23 +4,19 @@ %bcond_without llvm_static Name: bcc -Version: 0.11.0 +Version: 0.14.0 Release: 2%{?dist} Summary: BPF Compiler Collection (BCC) License: ASL 2.0 URL: https://github.com/iovisor/bcc -# Generate source tarball until upstream bug is fixed -# See https://github.com/iovisor/bcc/issues/2261 -# To generate the tarball, use the following commands -# git clone -b "v0.11.0" --single-branch --depth 1 url bcc-0.11.0 -# pushd bcc-0.11.0 -# git submodule update --init -# popd -# tar zcvf bcc-0.11.0.tar.gz bcc-0.11.0/ +# Upstream now provides a release with the git submodule embedded in it +Source0: %{url}/releases/download/v%{version}/%{name}-src-with-submodule.tar.gz #Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz -Source0: %{name}-%{version}.tar.gz -Patch1: %{name}-%{version}-Manpages-remove-unstable-statement.patch -patch2: %{name}-%{version}-man-add-missing-c-option-to-tcpretrans-synopsis.patch +Patch0: %{name}-%{version}-Manpages-remove-unstable-statement.patch +Patch1: %{name}-%{version}-deadlock-print-a-more-explicit-message-when-pthread_.patch +Patch2: %{name}-%{version}-man-remove-non-existent-x-argument-from-tcpconnect-m.patch +Patch3: %{name}-%{version}-loader-suggest-to-install-the-right-kernel-devel-pac.patch +Patch4: %{name}-%{version}-tools-fix-a-python-3-map-issue-in-dbstat-and-dbslowe.patch # Arches will be included as upstream support is added and dependencies are # satisfied in the respective arches @@ -77,7 +73,7 @@ Examples for BPF Compiler Collection (BCC) %package -n python3-%{name} Summary: Python3 bindings for BPF Compiler Collection (BCC) Requires: %{name}%{?_isa} = %{version}-%{release} -%{?python_provide:%python_provide python3-%{srcname}} +%{?python_provide:%python_provide python3-%{name}} %description -n python3-%{name} Python3 bindings for BPF Compiler Collection (BCC) @@ -103,7 +99,7 @@ Requires: kernel-devel Command line tools for BPF Compiler Collection (BCC) %prep -%autosetup -p1 +%autosetup -p1 -n %{name} %build %cmake . \ @@ -156,6 +152,8 @@ done %{_libdir}/libbcc_bpf.so.* %files devel +%exclude %{_libdir}/lib%{name}*.a +%exclude %{_libdir}/lib%{name}*.la %{_libdir}/lib%{name}.so %{_libdir}/libbcc_bpf.so %{_libdir}/pkgconfig/lib%{name}.pc @@ -192,7 +190,13 @@ done # criticalstat relies on CONFIG_PREEMPTIRQ_EVENTS which is disabled on RHEL 8 %exclude %{_datadir}/%{name}/tools/criticalstat %exclude %{_datadir}/%{name}/tools/doc/criticalstat_example.txt -%exclude %{_mandir}/man8/criticalstat.8 +%exclude %{_mandir}/man8/bcc-criticalstat.8.gz +# compactsnoop is only supported on x86_64 +%ifnarch x86_64 +%exclude %{_datadir}/%{name}/tools/compactsnoop +%exclude %{_datadir}/%{name}/tools/doc/compactsnoop_example.txt +%exclude %{_mandir}/man8/bcc-compactsnoop.8.gz +%endif %{_mandir}/man8/* %if %{with lua} @@ -202,6 +206,17 @@ done %changelog +* Thu Jun 11 2020 Jerome Marchand - 0.14.0-2 +- Remove criticalstat manpage +- Remove compactsnoop on non x86_64 +- Suggest to use --binary in deadlock +- Remove non-existent argument from tcpconnect man page +- Suggest to install the proper kernel-devel version +- Fix dbstat and dbslower + +* Wed Apr 22 2020 Jerome Marchand - 0.14.0-1 +- Rebase on bcc-0.14.0 + * Wed Dec 04 2019 Jerome Marchand - 0.11.0-2 - Add -c option ton the synopsis of tcpretrans manpage