From bd5ac20b134f2936c54245fc83a8e70207d3e07e Mon Sep 17 00:00:00 2001
From: Florian Weimer <fweimer@redhat.com>
Date: Mon, 20 Nov 2023 14:06:11 +0100
Subject: [PATCH] Fix another C compatibility issue in the configure script

Related to:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>
---
 bash-configure-c99-2.patch | 20 ++++++++++++++++++++
 bash.spec                  |  1 +
 2 files changed, 21 insertions(+)
 create mode 100644 bash-configure-c99-2.patch

diff --git a/bash-configure-c99-2.patch b/bash-configure-c99-2.patch
new file mode 100644
index 0000000..98fbce4
--- /dev/null
+++ b/bash-configure-c99-2.patch
@@ -0,0 +1,20 @@
+Another C compatibility issue: char ** and char * are distinct types,
+and strtold expects the former for its second argument.
+
+Submitted upstream:
+
+  <https://lists.gnu.org/archive/html/bug-bash/2023-11/msg00104.html>
+
+diff --git a/configure.ac b/configure.ac
+index 6defea0835fe8877..955c1149a8141e19 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -885,7 +885,7 @@ AC_CHECK_DECLS([strtold], [
+ 	[AC_COMPILE_IFELSE(
+ 		[AC_LANG_PROGRAM(
+ 		[[#include <stdlib.h>]],
+-		[[long double r; char *foo, bar; r = strtold(foo, &bar);]]
++		[[long double r; char *foo, *bar; r = strtold(foo, &bar);]]
+ 	)],
+ 	[bash_cv_strtold_broken=no],[bash_cv_strtold_broken=yes])
+         ]
diff --git a/bash.spec b/bash.spec
index e231bfa..de17a76 100644
--- a/bash.spec
+++ b/bash.spec
@@ -90,6 +90,7 @@ Patch127: bash-4.4-no-loadable-builtins.patch
 # This option is undocumented in upstream and is documented by this patch
 Patch128: bash-5.0-syslog-history.patch
 Patch129: bash-configure-c99.patch
+Patch130: bash-configure-c99-2.patch
 
 BuildRequires:  gcc
 BuildRequires: texinfo bison