From 59e49a4039109f3fabeff0478a0d550c91db87e7 Mon Sep 17 00:00:00 2001 From: Frederic Berat Date: Fri, 29 Jul 2022 17:31:32 +0200 Subject: [PATCH] Fix build failures on aarch64 Global build flags are breaking Objc compilation, since the corresponding "-fPIC" and "-fPIE" flags are not set for this language. The flags are therefore disabled completely, as this uncovers the fact that automake tests are covering more than the distribution actually supports. Reviewed-by: Jonathan Wakely --- automake.spec | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/automake.spec b/automake.spec index 8615d26..439da55 100644 --- a/automake.spec +++ b/automake.spec @@ -1,5 +1,13 @@ %global api_version 1.16 +# redhat-rpm-config sets CFLAGS, CXXFLAGS and LDFLAGS, but not +# OBJCFLAGS. This means that Obj-C tests will be compiled without hardening +# flags, and then fail when linked with the hardened linker flags. +# We therefore need to disable build flags to be able to test automake itself. +# Since the automake executables are all interpreted languages, they aren't +# compiled and so the build flags only affect the tests anyway. +%undefine _auto_set_build_flags + # do not mangle shebang in files which are part of bootstraped project %global __brp_mangle_shebangs_exclude_from /usr/share/automake-%{api_version} @@ -15,7 +23,7 @@ Summary: A GNU tool for automatically creating Makefiles Name: automake # Any bump here requires libtool rebuild, rhbz#1813010 Version: %{api_version}.5 -Release: 8%{?dist} +Release: 9%{?dist} # docs ~> GFDL, sources ~> GPLv2+, mkinstalldirs ~> PD and install-sh ~> MIT License: GPLv2+ and GFDL and Public Domain and MIT @@ -131,6 +139,9 @@ make -k %{?_smp_mflags} check %{?TESTS_FLAGS: TESTS="%{TESTS_FLAGS}"} \ %changelog +* Wed Aug 03 2022 Frederic Berat - 1.16.5-9 +- Fix tests environment failures due to LDFLAGS being set globally + * Wed Jul 20 2022 Fedora Release Engineering - 1.16.5-8 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild