da0ee4c338
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2056320 Changes to resolve internal hosts map problem: - fix root offset error handling. - fix nonstrict fail handling of last offset mount. - dont fail on duplicate offset entry tree add. - fix loop under run in cache_get_offset_parent(). - simplify cache_add() a little. - fix use after free in tree_mapent_delete_offset_tree(). - fix memory leak in xdr_exports(). - avoid calling pthread_getspecific() with NULL key_thread_attempt_id. - fix sysconf(3) return handling. - remove rpcgen dependedncy, it hasn't been needed since rev 10. Resolves: rhbz#2056320 Signed-off-by: Ian Kent ikent@redhat.com
86 lines
2.6 KiB
Diff
86 lines
2.6 KiB
Diff
autofs-5.1.8 - fix root offset error handling
|
|
|
|
From: Ian Kent <raven@themaw.net>
|
|
|
|
If mounting the root or offsets of a multi-mount root fails any mounts
|
|
done so far need to be umounted and the multi-mount offset tree deleted
|
|
so it can be created cleanly and possibly mounted the next time it's
|
|
triggered.
|
|
|
|
Also, if a subtree that is not the multi-mount root fails the expire
|
|
alarm needs to be re-instated so other subtrees (at least the root)
|
|
will continue to expire.
|
|
|
|
Signed-off-by: Ian Kent <raven@themaw.net>
|
|
---
|
|
CHANGELOG | 1 +
|
|
daemon/direct.c | 10 +++++++++-
|
|
modules/parse_sun.c | 6 ++++++
|
|
3 files changed, 16 insertions(+), 1 deletion(-)
|
|
|
|
--- autofs-5.1.7.orig/CHANGELOG
|
|
+++ autofs-5.1.7/CHANGELOG
|
|
@@ -84,6 +84,7 @@
|
|
- fix fedfs build flags.
|
|
- fix set open file limit.
|
|
- improve descriptor open error reporting.
|
|
+- fix root offset error handling.
|
|
|
|
25/01/2021 autofs-5.1.7
|
|
- make bind mounts propagation slave by default.
|
|
--- autofs-5.1.7.orig/daemon/direct.c
|
|
+++ autofs-5.1.7/daemon/direct.c
|
|
@@ -1163,6 +1163,7 @@ static void *do_mount_direct(void *arg)
|
|
struct ioctl_ops *ops = get_ioctl_ops();
|
|
struct pending_args *args, mt;
|
|
struct autofs_point *ap;
|
|
+ struct mapent *me;
|
|
struct stat st;
|
|
int status, state;
|
|
|
|
@@ -1226,7 +1227,6 @@ static void *do_mount_direct(void *arg)
|
|
pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &state);
|
|
if (status) {
|
|
struct mnt_list *sbmnt;
|
|
- struct mapent *me;
|
|
struct statfs fs;
|
|
unsigned int close_fd = 0;
|
|
unsigned int flags = MNTS_DIRECT|MNTS_MOUNTED;
|
|
@@ -1267,6 +1267,14 @@ static void *do_mount_direct(void *arg)
|
|
mt.ioctlfd, mt.wait_queue_token, -ENOENT);
|
|
ops->close(ap->logopt, mt.ioctlfd);
|
|
info(ap->logopt, "failed to mount %s", mt.name);
|
|
+
|
|
+ /* If this is a multi-mount subtree mount failure
|
|
+ * ensure the tree continues to expire.
|
|
+ */
|
|
+ me = cache_lookup_distinct(mt.mc, mt.name);
|
|
+ if (me && IS_MM(me) && !IS_MM_ROOT(me))
|
|
+ conditional_alarm_add(ap, ap->exp_runfreq);
|
|
+ cache_unlock(mt.mc);
|
|
}
|
|
pthread_setcancelstate(state, NULL);
|
|
|
|
--- autofs-5.1.7.orig/modules/parse_sun.c
|
|
+++ autofs-5.1.7/modules/parse_sun.c
|
|
@@ -1142,6 +1142,9 @@ static int mount_subtree(struct autofs_p
|
|
if (!len) {
|
|
warn(ap->logopt, "path loo long");
|
|
cache_unlock(mc);
|
|
+ cache_writelock(mc);
|
|
+ tree_mapent_delete_offsets(mc, name);
|
|
+ cache_unlock(mc);
|
|
return 1;
|
|
}
|
|
key[len] = '/';
|
|
@@ -1186,6 +1189,9 @@ static int mount_subtree(struct autofs_p
|
|
cache_unlock(mc);
|
|
error(ap->logopt, MODPREFIX
|
|
"failed to mount offset triggers");
|
|
+ cache_writelock(mc);
|
|
+ tree_mapent_delete_offsets(mc, name);
|
|
+ cache_unlock(mc);
|
|
return 1;
|
|
}
|
|
}
|