FedoraRewiew minor fixes

autoconf.spec

@@ -39,7 +39,7 @@ Requires(preun):    /sbin/install-info
 %description
 GNU's Autoconf is a tool for configuring source code and Makefiles.
 Using Autoconf, programmers can create portable and configurable
-packages, since the person building the package is allowed to 
+packages, since the person building the package is allowed to
 specify various configuration options.
 
 You should install Autoconf if you are developing software and
@@ -61,23 +61,12 @@ their use.
 make
 
 %check
-# The following test is failing.
-# 199: autotest.at  parallel autotest and signal handling
-# In test/autotest.at, under comment "Test PIPE", the exit code written
-# to file "status" is 0.  Report mailed to bug-autoconf.
-# make check TESTSUITEFLAGS='-198 200-'
 %if %{with check}
-make check
+make check # TESTSUITEFLAGS='1-198 200-' # will disable nr. 199.
 %endif
 
 %install
-rm -rf ${RPM_BUILD_ROOT}
+make install DESTDIR=%{buildroot}
-make install DESTDIR=$RPM_BUILD_ROOT
-
-rm -f $RPM_BUILD_ROOT%{_infodir}/dir
-
-%clean
-rm -rf ${RPM_BUILD_ROOT}
 
 %post
 /sbin/install-info %{_infodir}/autoconf.info %{_infodir}/dir || :
@@ -88,11 +77,12 @@ if [ "$1" = 0 ]; then
 fi
 
 %files
-%defattr(-,root,root,-)
 %{_bindir}/*
 %{_infodir}/autoconf.info*
 # don't include standards.info, because it comes from binutils...
 %exclude %{_infodir}/standards*
+# don't include info's TOP directory
+%exclude %{_infodir}/dir
 %{_datadir}/autoconf/
 %exclude %{_datadir}/autoconf/INSTALL
 %dir %{_datadir}/emacs/
@@ -101,6 +91,12 @@ fi
 %doc AUTHORS COPYING* ChangeLog NEWS README THANKS TODO
 
 %changelog
+* Thu Oct 25 2012 Pavel Raiskup <praiskup@redhat.com> - 2.69-6
+- fedora-review (minor) fixes and typos: trim lines, remove defattr(,,), do not
+  run `rm -rf %%{buildroot} at the beginning of install section, use curly
+  brackets only around rpm macros/variables and not around shell variables,
+  remove clean section
+
 * Wed Sep 26 2012 Pavel Raiskup <praiskup@redhat.com> - 2.69-5
 - do not install the "INSTALL" documentation file (#661623)
 
@@ -182,7 +178,7 @@ fi
 - add fix for same line comments #449245 (Ralf Wildenhues)
 
 * Fri Jun 06 2008 Karsten Hopp <karsten@redhat.com> 2.62-2
-- add upstream fix from Eric Blake for #449973, 
+- add upstream fix from Eric Blake for #449973,
   m4_if releated error message from autotest
 
 * Tue May 13 2008 Karsten Hopp <karsten@redhat.com> 2.62-1
@@ -215,7 +211,7 @@ fi
 - fix buildroot
 - use Requires(post), Requires(preun)
 - use make install DESTDIR=....
-- drop perl requirement as it gets pulled it automatically 
+- drop perl requirement as it gets pulled it automatically
 
 * Thu Jan 18 2007 Karsten Hopp <karsten@redhat.com> 2.61-3
 - don't abort (un)install scriptlets when _excludedocs is set (Ville Skyttä)
@@ -395,7 +391,7 @@ fi
 - add patch to help autoconf clean after itself and not leave /tmp clobbered
   with acin.* and acout.* files (can you say annoying?)
 
-* Sun Mar 21 1999 Cristian Gafton <gafton@redhat.com> 
+* Sun Mar 21 1999 Cristian Gafton <gafton@redhat.com>
 - auto rebuild in the new build environment (release 4)
 - use gawk, not mawk
 
@@ -425,4 +421,3 @@ fi
 
 * Thu Jul 17 1997 Erik Troan <ewt@redhat.com>
 - built with glibc
-