Compare commits
No commits in common. "c10s" and "c8" have entirely different histories.
1
.adcli.metadata
Normal file
1
.adcli.metadata
Normal file
@ -0,0 +1 @@
|
||||
5aba9ae88ad5a75f8ce143372cb8678b96ca5773 SOURCES/adcli-0.9.2.tar.gz
|
||||
20
.gitignore
vendored
20
.gitignore
vendored
@ -1,19 +1 @@
|
||||
/adcli-0.1.tar.gz
|
||||
/adcli-0.2.tar.gz
|
||||
/adcli-0.3.tar.gz
|
||||
/adcli-0.4.tar.gz
|
||||
/adcli-0.5.tar.gz
|
||||
/adcli-0.6.tar.gz
|
||||
/adcli-0.7.tar.gz
|
||||
/adcli-0.7.1.tar.gz
|
||||
/old
|
||||
/adcli-0.7.2.tar.gz
|
||||
/adcli-0.7.3.tar.gz
|
||||
/adcli-0.7.4.tar.gz
|
||||
/adcli-0.7.5.tar.gz
|
||||
/adcli-0.7.6.tar.gz
|
||||
/adcli-0.8.0.tar.gz
|
||||
/adcli-0.8.2.tar.gz
|
||||
/adcli-0.9.0.tar.gz
|
||||
/adcli-0.9.1.tar.gz
|
||||
/adcli-0.9.2.tar.gz
|
||||
SOURCES/adcli-0.9.2.tar.gz
|
||||
|
||||
@ -1,198 +0,0 @@
|
||||
From fab13daeaf23cc4a26b10cfe0c3d7ac469a9da76 Mon Sep 17 00:00:00 2001
|
||||
From: Sumit Bose <sbose@redhat.com>
|
||||
Date: Tue, 5 Nov 2024 14:22:47 +0100
|
||||
Subject: [PATCH 1/2] Various fixes for issues found by static code scanners
|
||||
|
||||
---
|
||||
library/adconn.c | 17 ++++++++++++-----
|
||||
library/adenroll.c | 4 ++--
|
||||
library/adutil.c | 2 +-
|
||||
library/seq.c | 13 +++++++++----
|
||||
library/seq.h | 3 ++-
|
||||
tools/tools.c | 24 +++++++++++++++++-------
|
||||
6 files changed, 43 insertions(+), 20 deletions(-)
|
||||
|
||||
diff --git a/library/adconn.c b/library/adconn.c
|
||||
index 087225d..e668b8d 100644
|
||||
--- a/library/adconn.c
|
||||
+++ b/library/adconn.c
|
||||
@@ -402,9 +402,9 @@ clear_krb5_conf_snippet (adcli_conn *conn)
|
||||
static adcli_result
|
||||
setup_krb5_conf_snippet (adcli_conn *conn)
|
||||
{
|
||||
- char *filename;
|
||||
- char *snippet;
|
||||
- char *controller;
|
||||
+ char *filename = NULL;
|
||||
+ char *snippet = NULL;
|
||||
+ char *controller = NULL;
|
||||
int errn;
|
||||
int ret;
|
||||
int fd;
|
||||
@@ -429,7 +429,10 @@ setup_krb5_conf_snippet (adcli_conn *conn)
|
||||
controller = strdup (conn->domain_controller);
|
||||
}
|
||||
|
||||
- return_unexpected_if_fail (controller != NULL);
|
||||
+ if (controller == NULL) {
|
||||
+ free (filename);
|
||||
+ return_unexpected_if_reached ();
|
||||
+ }
|
||||
|
||||
if (asprintf (&snippet, "[realms]\n"
|
||||
" %s = {\n"
|
||||
@@ -442,8 +445,11 @@ setup_krb5_conf_snippet (adcli_conn *conn)
|
||||
" %s = %s\n",
|
||||
conn->domain_realm, controller, controller, controller,
|
||||
conn->canonical_host, conn->domain_realm,
|
||||
- conn->domain_controller, conn->domain_realm) < 0)
|
||||
+ conn->domain_controller, conn->domain_realm) < 0) {
|
||||
+ free (controller);
|
||||
+ free (filename);
|
||||
return_unexpected_if_reached ();
|
||||
+ }
|
||||
|
||||
old_mask = umask (0177);
|
||||
fd = mkstemp (filename);
|
||||
@@ -451,6 +457,7 @@ setup_krb5_conf_snippet (adcli_conn *conn)
|
||||
if (fd < 0) {
|
||||
_adcli_warn ("Couldn't create krb5.conf snippet file in: %s: %s",
|
||||
conn->krb5_conf_dir, strerror (errno));
|
||||
+ free (filename);
|
||||
|
||||
} else {
|
||||
conn->krb5_conf_snippet = filename;
|
||||
diff --git a/library/adenroll.c b/library/adenroll.c
|
||||
index b6558ed..e978f46 100644
|
||||
--- a/library/adenroll.c
|
||||
+++ b/library/adenroll.c
|
||||
@@ -2340,9 +2340,9 @@ update_keytab_for_principals (adcli_enroll *enroll,
|
||||
|
||||
for (i = 0; enroll->keytab_principals[i] != 0; i++) {
|
||||
if (krb5_unparse_name (k5, enroll->keytab_principals[i], &name) != 0)
|
||||
- name = "";
|
||||
+ name = NULL;
|
||||
res = add_principal_to_keytab (enroll, k5, enroll->keytab_principals[i],
|
||||
- name, &which_salt, flags);
|
||||
+ name != NULL ? name : "", &which_salt, flags);
|
||||
krb5_free_unparsed_name (k5, name);
|
||||
|
||||
if (res != ADCLI_SUCCESS)
|
||||
diff --git a/library/adutil.c b/library/adutil.c
|
||||
index 36822e2..a112ad8 100644
|
||||
--- a/library/adutil.c
|
||||
+++ b/library/adutil.c
|
||||
@@ -169,7 +169,7 @@ _adcli_strv_dup (char **strv)
|
||||
return NULL;
|
||||
|
||||
count = seq_count (strv);
|
||||
- return seq_dup (strv, &count, (seq_copy)strdup);
|
||||
+ return seq_dup (strv, &count, (seq_copy)strdup, (seq_destroy)free);
|
||||
}
|
||||
|
||||
char *
|
||||
diff --git a/library/seq.c b/library/seq.c
|
||||
index 8e7475d..5410918 100644
|
||||
--- a/library/seq.c
|
||||
+++ b/library/seq.c
|
||||
@@ -299,7 +299,8 @@ seq_lookup (seq_voidp sequence,
|
||||
void *
|
||||
seq_dup (seq_voidp sequence,
|
||||
int *length,
|
||||
- seq_copy copy)
|
||||
+ seq_copy copy,
|
||||
+ seq_destroy destroy)
|
||||
{
|
||||
void **seq = sequence;
|
||||
void **copied;
|
||||
@@ -308,6 +309,7 @@ seq_dup (seq_voidp sequence,
|
||||
int at;
|
||||
|
||||
assert (length != NULL);
|
||||
+ assert ( (copy != NULL && destroy != NULL) || (copy == NULL && destroy == NULL) );
|
||||
|
||||
len = *length;
|
||||
alloc = alloc_size (len + 1);
|
||||
@@ -321,7 +323,10 @@ seq_dup (seq_voidp sequence,
|
||||
copied[at] = seq[at];
|
||||
} else {
|
||||
copied[at] = copy (seq[at]);
|
||||
- bail_on_null (copied[at]);
|
||||
+ if (copied[at] == NULL) {
|
||||
+ destroy (copied);
|
||||
+ return NULL;
|
||||
+ }
|
||||
}
|
||||
}
|
||||
|
||||
@@ -707,7 +712,7 @@ test_dup (void)
|
||||
seq = seq_insert (seq, &len, "3", (seq_compar)strcmp, NULL);
|
||||
seq = seq_insert (seq, &len, "1", (seq_compar)strcmp, NULL);
|
||||
|
||||
- dup = seq_dup (seq, &len, NULL);
|
||||
+ dup = seq_dup (seq, &len, NULL, NULL);
|
||||
assert (dup != NULL);
|
||||
|
||||
assert_str_eq (dup[0], "1");
|
||||
@@ -734,7 +739,7 @@ test_dup_deep (void)
|
||||
seq = seq_insert (seq, &len, "3", (seq_compar)strcmp, NULL);
|
||||
seq = seq_insert (seq, &len, "1", (seq_compar)strcmp, NULL);
|
||||
|
||||
- dup = seq_dup (seq, &len, (seq_copy)strdup);
|
||||
+ dup = seq_dup (seq, &len, (seq_copy)strdup, (seq_destroy)free);
|
||||
assert (dup != NULL);
|
||||
|
||||
assert_str_eq (dup[0], "1");
|
||||
diff --git a/library/seq.h b/library/seq.h
|
||||
index 5d48848..3fec747 100644
|
||||
--- a/library/seq.h
|
||||
+++ b/library/seq.h
|
||||
@@ -89,7 +89,8 @@ int seq_count (seq_voidp seq);
|
||||
|
||||
seq_voidp seq_dup (seq_voidp seq,
|
||||
int *length,
|
||||
- seq_copy copy);
|
||||
+ seq_copy copy,
|
||||
+ seq_destroy destroy);
|
||||
|
||||
void seq_free (seq_voidp seq,
|
||||
seq_destroy destroy);
|
||||
diff --git a/tools/tools.c b/tools/tools.c
|
||||
index 7e382ae..444485c 100644
|
||||
--- a/tools/tools.c
|
||||
+++ b/tools/tools.c
|
||||
@@ -399,14 +399,24 @@ setup_krb5_conf_directory (adcli_conn *conn)
|
||||
warnx ("couldn't create temporary directory in: %s: %s",
|
||||
parent, strerror (errn));
|
||||
} else {
|
||||
- if (asprintf (&filename, "%s/krb5.conf", directory) < 0 ||
|
||||
- asprintf (&snippets, "%s/krb5.d", directory) < 0 ||
|
||||
- asprintf (&contents, "includedir %s\n%s%s\n", snippets,
|
||||
- krb5_conf ? "include " : "",
|
||||
- krb5_conf ? krb5_conf : "") < 0) {
|
||||
+ if (asprintf (&filename, "%s/krb5.conf", directory) < 0) {
|
||||
+ warnx ("unexpected: out of memory");
|
||||
+ failed = 1;
|
||||
+ }
|
||||
+ if (!failed && asprintf (&snippets, "%s/krb5.d", directory) < 0) {
|
||||
+ free (filename);
|
||||
+ filename = NULL;
|
||||
+ warnx ("unexpected: out of memory");
|
||||
+ failed = 1;
|
||||
+ }
|
||||
+ if (!failed && asprintf (&contents, "includedir %s\n%s%s\n", snippets,
|
||||
+ krb5_conf ? "include " : "",
|
||||
+ krb5_conf ? krb5_conf : "") < 0) {
|
||||
+ free (snippets);
|
||||
+ snippets = NULL;
|
||||
+ free (filename);
|
||||
+ filename = NULL;
|
||||
warnx ("unexpected: out of memory");
|
||||
- filename = NULL; /* content is undefined */
|
||||
- snippets = NULL; /* content is undefined */
|
||||
contents = NULL; /* content is undefined */
|
||||
failed = 1;
|
||||
}
|
||||
--
|
||||
2.48.1
|
||||
|
||||
@ -1,226 +0,0 @@
|
||||
From d3db46e8b03f0f2db0df01466b597fde588a06bf Mon Sep 17 00:00:00 2001
|
||||
From: Sumit Bose <sbose@redhat.com>
|
||||
Date: Tue, 5 Nov 2024 19:00:54 +0100
|
||||
Subject: [PATCH 2/2] krb5: add adcli_krb5_get_error_message()
|
||||
|
||||
The krb5_get_error_message() call returns an error message in an
|
||||
allocated string which must be freed. This makes it hard to simply use
|
||||
krb5_get_error_message() in a printf() argument list.
|
||||
adcli_krb5_get_error_message() used a static memory area to make the
|
||||
usage more easy.
|
||||
---
|
||||
library/adconn.c | 10 +++++-----
|
||||
library/adenroll.c | 18 +++++++++---------
|
||||
library/adentry.c | 2 +-
|
||||
library/adkrb5.c | 22 +++++++++++++++++++---
|
||||
library/adprivate.h | 2 ++
|
||||
5 files changed, 36 insertions(+), 18 deletions(-)
|
||||
|
||||
diff --git a/library/adconn.c b/library/adconn.c
|
||||
index e668b8d..2c94af9 100644
|
||||
--- a/library/adconn.c
|
||||
+++ b/library/adconn.c
|
||||
@@ -367,20 +367,20 @@ handle_kinit_krb5_code (adcli_conn *conn,
|
||||
code == KRB5_PREAUTH_FAILED) {
|
||||
if (type == ADCLI_LOGIN_COMPUTER_ACCOUNT) {
|
||||
_adcli_err ("Couldn't authenticate as machine account: %s: %s",
|
||||
- name, krb5_get_error_message (conn->k5, code));
|
||||
+ name, adcli_krb5_get_error_message (conn->k5, code));
|
||||
} else {
|
||||
_adcli_err ("Couldn't authenticate as: %s: %s",
|
||||
- name, krb5_get_error_message (conn->k5, code));
|
||||
+ name, adcli_krb5_get_error_message (conn->k5, code));
|
||||
}
|
||||
return ADCLI_ERR_CREDENTIALS;
|
||||
|
||||
} else {
|
||||
if (type == ADCLI_LOGIN_COMPUTER_ACCOUNT) {
|
||||
_adcli_err ("Couldn't get kerberos ticket for machine account: %s: %s",
|
||||
- name, krb5_get_error_message (conn->k5, code));
|
||||
+ name, adcli_krb5_get_error_message (conn->k5, code));
|
||||
} else {
|
||||
_adcli_err ("Couldn't get kerberos ticket for: %s: %s",
|
||||
- name, krb5_get_error_message (conn->k5, code));
|
||||
+ name, adcli_krb5_get_error_message (conn->k5, code));
|
||||
}
|
||||
return ADCLI_ERR_DIRECTORY;
|
||||
}
|
||||
@@ -726,7 +726,7 @@ prep_kerberos_and_kinit (adcli_conn *conn)
|
||||
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't open kerberos credential cache: %s: %s",
|
||||
- conn->login_ccache_name, krb5_get_error_message (NULL, code));
|
||||
+ conn->login_ccache_name, adcli_krb5_get_error_message (NULL, code));
|
||||
return ADCLI_ERR_CONFIG;
|
||||
}
|
||||
}
|
||||
diff --git a/library/adenroll.c b/library/adenroll.c
|
||||
index e978f46..c854c9e 100644
|
||||
--- a/library/adenroll.c
|
||||
+++ b/library/adenroll.c
|
||||
@@ -549,7 +549,7 @@ ensure_keytab_principals (adcli_result res,
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't parse kerberos user principal: %s: %s",
|
||||
enroll->user_principal,
|
||||
- krb5_get_error_message (k5, code));
|
||||
+ adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_CONFIG;
|
||||
}
|
||||
}
|
||||
@@ -1523,7 +1523,7 @@ set_password_with_user_creds (adcli_enroll *enroll)
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't set password for %s account: %s: %s",
|
||||
s_or_c (enroll),
|
||||
- enroll->computer_sam, krb5_get_error_message (k5, code));
|
||||
+ enroll->computer_sam, adcli_krb5_get_error_message (k5, code));
|
||||
/* TODO: Parse out these values */
|
||||
res = ADCLI_ERR_DIRECTORY;
|
||||
|
||||
@@ -1584,7 +1584,7 @@ set_password_with_computer_creds (adcli_enroll *enroll)
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't get change password ticket for %s account: %s: %s",
|
||||
s_or_c (enroll),
|
||||
- enroll->computer_sam, krb5_get_error_message (k5, code));
|
||||
+ enroll->computer_sam, adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_DIRECTORY;
|
||||
}
|
||||
|
||||
@@ -1596,7 +1596,7 @@ set_password_with_computer_creds (adcli_enroll *enroll)
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't change password for %s account: %s: %s",
|
||||
s_or_c (enroll),
|
||||
- enroll->computer_sam, krb5_get_error_message (k5, code));
|
||||
+ enroll->computer_sam, adcli_krb5_get_error_message (k5, code));
|
||||
/* TODO: Parse out these values */
|
||||
res = ADCLI_ERR_DIRECTORY;
|
||||
|
||||
@@ -2113,7 +2113,7 @@ load_host_keytab (adcli_enroll *enroll)
|
||||
code = _adcli_krb5_keytab_enumerate (k5, keytab, load_keytab_entry, enroll);
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't enumerate keytab: %s: %s",
|
||||
- enroll->keytab_name, krb5_get_error_message (k5, code));
|
||||
+ enroll->keytab_name, adcli_krb5_get_error_message (k5, code));
|
||||
res = ADCLI_ERR_FAIL;
|
||||
}
|
||||
krb5_kt_close (k5, keytab);
|
||||
@@ -2225,7 +2225,7 @@ remove_principal_from_keytab (adcli_enroll *enroll,
|
||||
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't update keytab: %s: %s",
|
||||
- enroll->keytab_name, krb5_get_error_message (k5, code));
|
||||
+ enroll->keytab_name, adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_FAIL;
|
||||
}
|
||||
|
||||
@@ -2257,7 +2257,7 @@ add_principal_to_keytab (adcli_enroll *enroll,
|
||||
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't update keytab: %s: %s",
|
||||
- enroll->keytab_name, krb5_get_error_message (k5, code));
|
||||
+ enroll->keytab_name, adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_FAIL;
|
||||
}
|
||||
|
||||
@@ -2296,7 +2296,7 @@ add_principal_to_keytab (adcli_enroll *enroll,
|
||||
enctypes, salts, which_salt);
|
||||
if (code != 0) {
|
||||
_adcli_warn ("Couldn't authenticate with keytab while discovering which salt to use: %s: %s",
|
||||
- principal_name, krb5_get_error_message (k5, code));
|
||||
+ principal_name, adcli_krb5_get_error_message (k5, code));
|
||||
*which_salt = DEFAULT_SALT;
|
||||
} else {
|
||||
assert (*which_salt >= 0);
|
||||
@@ -2313,7 +2313,7 @@ add_principal_to_keytab (adcli_enroll *enroll,
|
||||
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't add keytab entries: %s: %s",
|
||||
- enroll->keytab_name, krb5_get_error_message (k5, code));
|
||||
+ enroll->keytab_name, adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_FAIL;
|
||||
}
|
||||
|
||||
diff --git a/library/adentry.c b/library/adentry.c
|
||||
index 0d9b9af..38ec7ca 100644
|
||||
--- a/library/adentry.c
|
||||
+++ b/library/adentry.c
|
||||
@@ -515,7 +515,7 @@ adcli_entry_set_passwd (adcli_entry *entry, const char *user_pwd)
|
||||
if (code != 0) {
|
||||
_adcli_err ("Couldn't set password for %s account: %s: %s",
|
||||
entry->object_class,
|
||||
- entry->sam_name, krb5_get_error_message (k5, code));
|
||||
+ entry->sam_name, adcli_krb5_get_error_message (k5, code));
|
||||
/* TODO: Parse out these values */
|
||||
res = ADCLI_ERR_DIRECTORY;
|
||||
|
||||
diff --git a/library/adkrb5.c b/library/adkrb5.c
|
||||
index be3ede5..7a9ee8f 100644
|
||||
--- a/library/adkrb5.c
|
||||
+++ b/library/adkrb5.c
|
||||
@@ -33,6 +33,7 @@
|
||||
#include <ctype.h>
|
||||
#include <errno.h>
|
||||
#include <stdio.h>
|
||||
+#include <sys/param.h>
|
||||
|
||||
krb5_error_code
|
||||
_adcli_krb5_build_principal (krb5_context k5,
|
||||
@@ -174,7 +175,7 @@ _adcli_krb5_init_context (krb5_context *k5)
|
||||
|
||||
} else if (code != 0) {
|
||||
_adcli_err ("Failed to create kerberos context: %s",
|
||||
- krb5_get_error_message (NULL, code));
|
||||
+ adcli_krb5_get_error_message (NULL, code));
|
||||
return ADCLI_ERR_UNEXPECTED;
|
||||
}
|
||||
|
||||
@@ -192,7 +193,7 @@ _adcli_krb5_open_keytab (krb5_context k5,
|
||||
code = krb5_kt_resolve (k5, keytab_name, keytab);
|
||||
if (code != 0) {
|
||||
_adcli_err ("Failed to open keytab: %s: %s",
|
||||
- keytab_name, krb5_get_error_message (k5, code));
|
||||
+ keytab_name, adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_FAIL;
|
||||
}
|
||||
|
||||
@@ -200,7 +201,7 @@ _adcli_krb5_open_keytab (krb5_context k5,
|
||||
code = krb5_kt_default (k5, keytab);
|
||||
if (code != 0) {
|
||||
_adcli_err ("Failed to open default keytab: %s",
|
||||
- krb5_get_error_message (k5, code));
|
||||
+ adcli_krb5_get_error_message (k5, code));
|
||||
return ADCLI_ERR_FAIL;
|
||||
}
|
||||
}
|
||||
@@ -570,3 +571,18 @@ _adcli_krb5_format_enctypes (krb5_enctype *enctypes)
|
||||
|
||||
return value;
|
||||
}
|
||||
+
|
||||
+const char *adcli_krb5_get_error_message (krb5_context ctx, krb5_error_code code)
|
||||
+{
|
||||
+ static char out[4096];
|
||||
+ const char *tmp;
|
||||
+ size_t len;
|
||||
+
|
||||
+ tmp = krb5_get_error_message (ctx, code);
|
||||
+ len = strlen (tmp);
|
||||
+ memcpy (out, tmp, MIN (sizeof (out), len));
|
||||
+ out[sizeof(out) - 1] = '\0';
|
||||
+ krb5_free_error_message (ctx, tmp);
|
||||
+
|
||||
+ return out;
|
||||
+}
|
||||
diff --git a/library/adprivate.h b/library/adprivate.h
|
||||
index bf0381c..cca58f9 100644
|
||||
--- a/library/adprivate.h
|
||||
+++ b/library/adprivate.h
|
||||
@@ -323,4 +323,6 @@ adcli_result _adcli_call_external_program (const char *binary,
|
||||
uint8_t **stdout_data,
|
||||
size_t *stdout_data_len);
|
||||
|
||||
+const char *adcli_krb5_get_error_message (krb5_context ctx,
|
||||
+ krb5_error_code code);
|
||||
#endif /* ADPRIVATE_H_ */
|
||||
--
|
||||
2.48.1
|
||||
|
||||
@ -1,15 +1,11 @@
|
||||
Name: adcli
|
||||
Version: 0.9.2
|
||||
Release: 9%{?dist}
|
||||
Release: 1%{?dist}
|
||||
Summary: Active Directory enrollment
|
||||
License: LGPL-2.1-or-later
|
||||
License: LGPLv2+
|
||||
URL: https://gitlab.freedesktop.org/realmd/adcli
|
||||
Source0: https://gitlab.freedesktop.org/realmd/adcli/uploads/ea560656ac921b3fe0d455976aaae9be/adcli-%{version}.tar.gz
|
||||
|
||||
# fixes for issues found by static analyser
|
||||
Patch1: 0001-Various-fixes-for-issues-found-by-static-code-scanne.patch
|
||||
Patch2: 0002-krb5-add-adcli_krb5_get_error_message.patch
|
||||
|
||||
BuildRequires: gcc
|
||||
BuildRequires: intltool pkgconfig
|
||||
BuildRequires: libtool
|
||||
@ -43,13 +39,13 @@ autoreconf --force --install --verbose
|
||||
--with-vendor-error-message='Please check\n https://red.ht/support_rhel_ad \nto get help for common issues.' \
|
||||
%endif
|
||||
%{nil}
|
||||
%make_build
|
||||
make %{?_smp_mflags}
|
||||
|
||||
%check
|
||||
make check
|
||||
|
||||
%install
|
||||
%make_install
|
||||
make install DESTDIR=%{buildroot}
|
||||
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
|
||||
|
||||
%ldconfig_scriptlets
|
||||
@ -73,135 +69,69 @@ documentation.
|
||||
%doc %{_datadir}/doc/adcli/*
|
||||
|
||||
%changelog
|
||||
* Thu Feb 13 2025 Sumit Bose <sbose@redhat.com> - 0.9.2-9
|
||||
- Fixes for RHEL SAST Automation
|
||||
Resolves: RHEL-45146
|
||||
|
||||
* Tue Oct 29 2024 Troy Dawson <tdawson@redhat.com> - 0.9.2-8
|
||||
- Bump release for October 2024 mass rebuild:
|
||||
Resolves: RHEL-64018
|
||||
|
||||
* Mon Jun 24 2024 Troy Dawson <tdawson@redhat.com> - 0.9.2-7
|
||||
- Bump release for June 2024 mass rebuild
|
||||
|
||||
* Mon Jan 22 2024 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.2-6
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
|
||||
|
||||
* Fri Jan 19 2024 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.2-5
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
|
||||
|
||||
* Wed Oct 18 2023 Sumit Bose <sbose@redhat.com> - 0.9.2-4
|
||||
- migrated to SPDX license
|
||||
|
||||
* Wed Jul 19 2023 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.2-3
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
|
||||
|
||||
* Wed Jan 18 2023 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.2-2
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
|
||||
|
||||
* Thu Sep 29 2022 Sumit Bose <sbose@redhat.com> - 0.9.2-1
|
||||
* Fri Oct 21 2022 Sumit Bose <sbose@redhat.com> - 0.9.2-1
|
||||
- Update to upstream release 0.9.2
|
||||
Resolves: rhbz#1991619, rhbz#2111348, rhbz#2133838
|
||||
|
||||
* Wed Jul 20 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.1-11
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
|
||||
* Mon Jun 14 2021 Sumit Bose <sbose@redhat.com> - 0.8.2-12
|
||||
- [RFE] Allow adcli to create AD user with password as well as set or reset
|
||||
existing user password [#1952828]
|
||||
- [RFE] add option to populate "managed by" computer attribute [#1690920]
|
||||
|
||||
* Wed Jan 19 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.1-10
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
|
||||
* Thu Jun 03 2021 Sumit Bose <sbose@redhat.com> - 0.8.2-11
|
||||
- Add missing patch for [#1769644]
|
||||
|
||||
* Wed Jul 28 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-9
|
||||
- Add ns_get16() and ns_get32() to configure check
|
||||
Resolves: rhbz#1984891
|
||||
* Thu Jun 03 2021 Sumit Bose <sbose@redhat.com> - 0.8.2-10
|
||||
- [RFE] Adcli and Realm Error Code Optimization Request [#1889386]
|
||||
- [RFE] adcli should allow to modify DONT_EXPIRE_PASSWORD attribute [#1769644]
|
||||
|
||||
* Wed Jul 21 2021 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.1-8
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
|
||||
* Fri Dec 11 2020 Sumit Bose <sbose@redhat,com> - 0.8.2-9
|
||||
- Typo in CREATE A SERVICE ACCOUNT section of man page of adcli [#1906303]
|
||||
|
||||
* Mon Jun 28 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-7
|
||||
- Add user-passwd sub-command
|
||||
- Add setattr/delattr option
|
||||
* Wed Nov 11 2020 Sumit Bose <sbose@redhat.com> - 0.8.2-8
|
||||
- Add --use-ldaps option to adcli update as well [#1883467]
|
||||
- Cannot join a pre-staged Computer Account on AD in Custom OU using Delegated
|
||||
user [#1734764]
|
||||
- missing documentation for required AD rights for adcli join and net
|
||||
join [#1852080]
|
||||
- [RFE] Add new mode to just create an AD account to be able to connect to
|
||||
LDAP [#1854112]
|
||||
|
||||
* Thu Jun 03 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-6
|
||||
- Add fix for dont-expire-password option
|
||||
* Thu Aug 13 2020 Sumit Bose <sbose@redhat.com> - 0.8.2-7
|
||||
- Improve "-C" option description in man page even more [#1791545]
|
||||
|
||||
* Wed Jun 02 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-5
|
||||
- Add dont-expire-password option and coverity fixes
|
||||
* Mon Jun 15 2020 Sumit Bose <sbose@redhat.com> - 0.8.2-6
|
||||
- [abrt] [faf] adcli: raise(): /usr/sbin/adcli killed by 6 [#1806260]
|
||||
- No longer able to delete computer from AD using adcli [#1846882]
|
||||
- adcli: presetting $computer in $domain domain failed: Cannot set computer
|
||||
password: Authentication error [#1846878]
|
||||
- Typo in adcli update --help option [#1791611]
|
||||
- Manpage and help does not explain the use of "-C" option [#1791545]
|
||||
|
||||
* Wed Apr 07 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-4
|
||||
- Add macro updates for autoconf-2.71 and downstream gating
|
||||
* Wed Jan 29 2020 Sumit Bose <sbose@redhat.com> - 0.8.2-5
|
||||
- adcli should be able to Force LDAPS over 636 with AD Access Provider w.r.t
|
||||
sssd [#1762420]
|
||||
|
||||
* Mon Mar 29 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-3
|
||||
- Add vendor error message
|
||||
Resolves: rhbz#1889386
|
||||
* Thu Nov 28 2019 Sumit Bose <sbose@redhat.com> - 0.8.2-4
|
||||
- adcli update --add-samba-data does not work as expected [#1745931]
|
||||
- Issue is that with arcfour-hmac as first encryption type [#1745932]
|
||||
- [RFE] enhancement adcli to set description attribute and to show all AD
|
||||
attributes [#1737342]
|
||||
|
||||
* Sat Feb 20 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-2
|
||||
- Add Conflicts to avoid update/downgrade issues
|
||||
* Fri Jun 14 2019 Sumit Bose <sbose@redhat.com> - 0.8.2-3
|
||||
- use autosetup macro to simplify patch handling
|
||||
- fixed rpmlint warnings in the spec file
|
||||
- join failed if hostname is not FQDN [#1677194]
|
||||
- adcli join fails in FIPS enabled environment [#1717355]
|
||||
- forward port of RHEL-7.7 fixes and enhancements
|
||||
|
||||
* Sat Feb 20 2021 Sumit Bose <sbose@redhat.com> - 0.9.1-1
|
||||
- Update to upstream release 0.9.1
|
||||
* Tue Oct 09 2018 Sumit Bose <sbose@redhat.com> - 0.8.2-2
|
||||
- Do not add service principals twice and related fixes
|
||||
- Resolves: rhbz#1631734
|
||||
|
||||
* Mon Jan 25 2021 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.0-7
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
|
||||
|
||||
* Fri Nov 13 2020 Sumit Bose <sbose@redhat.com> - 0.9.0-6
|
||||
- Include the latest upstream patches with use-ldaps fixes, man page
|
||||
improvements and a new sub-command to create managed service accounts
|
||||
|
||||
* Thu Aug 13 2020 Sumit Bose <sbose@redhat.com> - 0.9.0-5
|
||||
- man page and help output fixes
|
||||
|
||||
* Fri Jul 31 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.0-4
|
||||
- Second attempt - Rebuilt for
|
||||
https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
|
||||
|
||||
* Mon Jul 27 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.9.0-3
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
|
||||
|
||||
* Mon Jun 08 2020 Sumit Bose <sbose@redhat.com> - 0.9.0-2
|
||||
- Include the latest upstream patches
|
||||
|
||||
* Wed Mar 18 2020 Sumit Bose <sbose@redhat.com> - 0.9.0-1
|
||||
- Update to upstream release 0.9.0 and latest patches
|
||||
|
||||
* Tue Jan 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.8.2-9
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
|
||||
|
||||
* Mon Aug 26 2019 Sumit Bose <sbose@redhat.com> - 0.8.2-8
|
||||
- various fixes and improvements
|
||||
Resolves: rhbz#1683745, rhbz#1738573
|
||||
|
||||
* Wed Jul 24 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.8.2-7
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
|
||||
|
||||
* Fri Jul 5 2019 Jakub Hrozek <jhrozek@redhat.com> - 0.8.2-6
|
||||
- Resolves: rhbz#1727144 - adcli join fails with new krb5-libs; adcli
|
||||
needs to backport patches to only use permitted
|
||||
enctypes from upstream
|
||||
|
||||
* Tue Apr 30 2019 Sumit Bose <sbose@redhat.com> - 0.8.2-5
|
||||
- addition patch for rhbz#1630187 and new ones for rhbz#1588596
|
||||
Resolves: rhbz#1630187, rhbz#1588596
|
||||
|
||||
* Fri Mar 22 2019 Sumit Bose <sbose@redhat.com> - 0.8.2-4
|
||||
- various fixes and improvements
|
||||
Resolves: rhbz#1593240, rhbz#1608212, rhbz#1547014, rhbz#1547014,
|
||||
rhbz#1649868, rhbz#1588596, rhbz#1642546, rhbz#1595911,
|
||||
rhbz#1644311, rhbz#1337489, rhbz#1630187, rhbz#1622583
|
||||
|
||||
* Thu Jan 31 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.8.2-3
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
|
||||
|
||||
* Thu Jul 12 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.8.2-2
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
|
||||
|
||||
* Thu Jul 05 2018 Sumit Bose <sbose@redhat.com> - 0.8.0-1
|
||||
* Thu Jul 05 2018 Sumit Bose <sbose@redhat.com> - 0.8.2-1
|
||||
- Update to upstream release 0.8.2
|
||||
- various other fixes and improvements
|
||||
- add option to enable "Trust this computer for delegation"
|
||||
Resolves: rhbz#988349
|
||||
- fix typos in the adcli man page
|
||||
Resolves: rhbz#1440533
|
||||
|
||||
* Wed Mar 07 2018 Sumit Bose <sbose@redhat.com> - 0.8.0-7
|
||||
- Added BuildRequires gcc
|
||||
- various other fixes and improvements from the latest Fedora update
|
||||
|
||||
* Wed Feb 07 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.8.0-6
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
|
||||
@ -1,6 +0,0 @@
|
||||
--- !Policy
|
||||
product_versions:
|
||||
- rhel-10
|
||||
decision_context: osci_compose_gate
|
||||
rules:
|
||||
- !PassingTestCaseRule {test_case_name: idm-ci.brew-build.tier1.functional}
|
||||
Loading…
Reference in New Issue
Block a user