Fixed fedora-review tool complaints:

- removed %clean
- removed defattr
- removed BuildRoot:
- use %global
This commit is contained in:
Jan Safranek 2012-08-27 14:44:08 +02:00
parent d21197474f
commit 55e230f32f

View File

@ -1,6 +1,6 @@
# TODO: uses private copy of libedit, should be modified to use system one # TODO: uses private copy of libedit, should be modified to use system one
%{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
Summary: IPMI (Intelligent Platform Management Interface) library and tools Summary: IPMI (Intelligent Platform Management Interface) library and tools
Name: OpenIPMI Name: OpenIPMI
Version: 2.0.19 Version: 2.0.19
@ -12,7 +12,6 @@ Source: http://downloads.sourceforge.net/openipmi/%{name}-%{version}.tar.gz
Source1: openipmi.sysconf Source1: openipmi.sysconf
Source2: openipmi-helper Source2: openipmi-helper
Source3: ipmi.service Source3: ipmi.service
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: gdbm-devel swig glib2-devel net-snmp-devel ncurses-devel BuildRequires: gdbm-devel swig glib2-devel net-snmp-devel ncurses-devel
BuildRequires: openssl-devel python-devel perl-devel tcl-devel tkinter BuildRequires: openssl-devel python-devel perl-devel tcl-devel tkinter
BuildRequires: desktop-file-utils BuildRequires: desktop-file-utils
@ -81,7 +80,6 @@ export CFLAGS="-fPIC $RPM_OPT_FLAGS"
make # not %{?_smp_mflags} safe make # not %{?_smp_mflags} safe
%install %install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT
rm -rf $RPM_BUILD_ROOT/%{_libdir}/*.la rm -rf $RPM_BUILD_ROOT/%{_libdir}/*.la
@ -120,11 +118,7 @@ rm ${RPM_BUILD_ROOT}/%{_mandir}/man1/openipmigui.1
/sbin/chkconfig --del ipmi >/dev/null 2>&1 || : /sbin/chkconfig --del ipmi >/dev/null 2>&1 || :
/bin/systemctl try-restart ipmi.service >/dev/null 2>&1 || : /bin/systemctl try-restart ipmi.service >/dev/null 2>&1 || :
%clean
rm -rf $RPM_BUILD_ROOT
%files %files
%defattr(-,root,root)
%doc CONFIGURING_FOR_LAN COPYING COPYING.BSD COPYING.LIB FAQ README README.Force README.MotorolaMXP %doc CONFIGURING_FOR_LAN COPYING COPYING.BSD COPYING.LIB FAQ README README.Force README.MotorolaMXP
%config(noreplace) %{_sysconfdir}/sysconfig/ipmi %config(noreplace) %{_sysconfdir}/sysconfig/ipmi
%{_libexecdir}/openipmi-helper %{_libexecdir}/openipmi-helper
@ -147,20 +141,16 @@ rm -rf $RPM_BUILD_ROOT
%{_mandir}/man8/ipmilan* %{_mandir}/man8/ipmilan*
%files perl %files perl
%defattr(-,root,root)
%attr(644,root,root) %{perl_vendorarch}/OpenIPMI.pm %attr(644,root,root) %{perl_vendorarch}/OpenIPMI.pm
%{perl_vendorarch}/auto/OpenIPMI/ %{perl_vendorarch}/auto/OpenIPMI/
%files python %files python
%defattr(-,root,root)
%{python_sitearch}/*OpenIPMI* %{python_sitearch}/*OpenIPMI*
%files libs %files libs
%defattr(-,root,root)
%{_libdir}/*.so.* %{_libdir}/*.so.*
%files devel %files devel
%defattr(-,root,root)
%{_includedir}/OpenIPMI %{_includedir}/OpenIPMI
%{_libdir}/*.so %{_libdir}/*.so
%{_libdir}/pkgconfig/*.pc %{_libdir}/pkgconfig/*.pc
@ -168,6 +158,7 @@ rm -rf $RPM_BUILD_ROOT
%changelog %changelog
* Mon Aug 27 2012 Jan Safranek <jsafrane@redhat.com> - 2.0.19-2 * Mon Aug 27 2012 Jan Safranek <jsafrane@redhat.com> - 2.0.19-2
- Updated RPM scriptlets with latest systemd-rpm macros (#850246) - Updated RPM scriptlets with latest systemd-rpm macros (#850246)
- Fixed fedora-review tool complaints
* Wed Aug 8 2012 Jan Safranek <jsafrane@redhat.com> - 2.0.19-1 * Wed Aug 8 2012 Jan Safranek <jsafrane@redhat.com> - 2.0.19-1
- Update to 2.0.19 - Update to 2.0.19