rpminspect: clarify usage of badfunc "inet_aton" in comment

Related: #1966123
This commit is contained in:
Thomas Haller 2021-07-22 15:04:32 +02:00
parent 8464cb3f17
commit 1254c71598
No known key found for this signature in database
GPG Key ID: 29C2366E4DFC5728
1 changed files with 11 additions and 6 deletions

View File

@ -3,9 +3,10 @@
#
# *** INTERNAL SETTINGS FOR RED HAT -- DO NOT REDISTRIBUTE ***
#
# In order to tweak the rpminspect configuration per component, the
# default configuration file can be obtained from
# https://gitlab.cee.redhat.com/osci/rpminspect-data-redhat/-/blob/master/redhat.yaml
#XXX In order to tweak the rpminspect configuration per component, the
#XXX default configuration file can be obtained from
#XXX https://gitlab.cee.redhat.com/osci/rpminspect-data-redhat/-/blob/master/redhat.yaml
---
badfuncs:
@ -16,13 +17,17 @@ badfuncs:
# only provide them to users for backwards compatibility.
# This is an array of forbidden function names.
# Forbidden function symbol `inet_aton` is used in NetworkManager
# (Since 1.32.2 ).
# So drop these three function symbols from the list.
- gethostbyname
- gethostbyname2
- gethostbyaddr
- inet_addr
#XXX NetworkManager intentionally uses inet_aton. It does so in a controlled manner
#XXX to parse IPv4 addresses in the legacy style (with leading zeros, which inet_pton() does
#XXX not support). See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/cf1b726157c36f72a79aa1276c8c80fe2be1d04d/src/libnm-glib-aux/nm-shared-utils.c#L911
#XXX
#XXX - inet_aton
- inet_nsap_addr
- inet_ntoa
- inet_nsap_ntoa