6a59456f24
- Resolves: RHEL-5141 - [RFE] For each request, a ldap client can assign an identifier to be added in the logs - Resolves: RHEL-77948 - ns-slapd crashes with data directory ≥ 2 days old [rhel-10] - Resolves: RHEL-78342 - During import of entries without nsUniqueId, a supplier generates duplicate nsUniqueId (LMDB only)
147 lines
4.6 KiB
Diff
147 lines
4.6 KiB
Diff
From dc8032856d51c382e266eea72f66284e70a0e40c Mon Sep 17 00:00:00 2001
|
|
From: Mark Reynolds <mreynolds@redhat.com>
|
|
Date: Fri, 31 Jan 2025 08:54:27 -0500
|
|
Subject: [PATCH] Issue 6489 - After log rotation refresh the FD pointer
|
|
|
|
Description:
|
|
|
|
When flushing a log buffer we get a FD for log prior to checking if the
|
|
log should be rotated. If the log is rotated that FD reference is now
|
|
invalid, and it needs to be refrehed before proceeding
|
|
|
|
Relates: https://github.com/389ds/389-ds-base/issues/6489
|
|
|
|
Reviewed by: tbordaz(Thanks!)
|
|
---
|
|
.../suites/logging/log_flush_rotation_test.py | 81 +++++++++++++++++++
|
|
ldap/servers/slapd/log.c | 18 +++++
|
|
2 files changed, 99 insertions(+)
|
|
create mode 100644 dirsrvtests/tests/suites/logging/log_flush_rotation_test.py
|
|
|
|
diff --git a/dirsrvtests/tests/suites/logging/log_flush_rotation_test.py b/dirsrvtests/tests/suites/logging/log_flush_rotation_test.py
|
|
new file mode 100644
|
|
index 000000000..b33a622e1
|
|
--- /dev/null
|
|
+++ b/dirsrvtests/tests/suites/logging/log_flush_rotation_test.py
|
|
@@ -0,0 +1,81 @@
|
|
+# --- BEGIN COPYRIGHT BLOCK ---
|
|
+# Copyright (C) 2025 Red Hat, Inc.
|
|
+# All rights reserved.
|
|
+#
|
|
+# License: GPL (version 3 or any later version).
|
|
+# See LICENSE for details.
|
|
+# --- END COPYRIGHT BLOCK ---
|
|
+#
|
|
+import os
|
|
+import logging
|
|
+import time
|
|
+import pytest
|
|
+from lib389._constants import DEFAULT_SUFFIX, PW_DM
|
|
+from lib389.tasks import ImportTask
|
|
+from lib389.idm.user import UserAccounts
|
|
+from lib389.topologies import topology_st as topo
|
|
+
|
|
+
|
|
+log = logging.getLogger(__name__)
|
|
+
|
|
+
|
|
+def test_log_flush_and_rotation_crash(topo):
|
|
+ """Make sure server does not crash whening flushing a buffer and rotating
|
|
+ the log at the same time
|
|
+
|
|
+ :id: d4b0af2f-48b2-45f5-ae8b-f06f692c3133
|
|
+ :setup: Standalone Instance
|
|
+ :steps:
|
|
+ 1. Enable all logs
|
|
+ 2. Enable log buffering for all logs
|
|
+ 3. Set rotation time unit to 1 minute
|
|
+ 4. Make sure server is still running after 1 minute
|
|
+ :expectedresults:
|
|
+ 1. Success
|
|
+ 2. Success
|
|
+ 3. Success
|
|
+ 4. Success
|
|
+ """
|
|
+
|
|
+ inst = topo.standalone
|
|
+
|
|
+ # Enable logging and buffering
|
|
+ inst.config.set("nsslapd-auditlog-logging-enabled", "on")
|
|
+ inst.config.set("nsslapd-accesslog-logbuffering", "on")
|
|
+ inst.config.set("nsslapd-auditlog-logbuffering", "on")
|
|
+ inst.config.set("nsslapd-errorlog-logbuffering", "on")
|
|
+ inst.config.set("nsslapd-securitylog-logbuffering", "on")
|
|
+
|
|
+ # Set rotation policy to trigger rotation asap
|
|
+ inst.config.set("nsslapd-accesslog-logrotationtimeunit", "minute")
|
|
+ inst.config.set("nsslapd-auditlog-logrotationtimeunit", "minute")
|
|
+ inst.config.set("nsslapd-errorlog-logrotationtimeunit", "minute")
|
|
+ inst.config.set("nsslapd-securitylog-logrotationtimeunit", "minute")
|
|
+
|
|
+ #
|
|
+ # Performs ops to populate all the logs
|
|
+ #
|
|
+ # Access & audit log
|
|
+ users = UserAccounts(topo.standalone, DEFAULT_SUFFIX)
|
|
+ user = users.create_test_user()
|
|
+ user.set("userPassword", PW_DM)
|
|
+ # Security log
|
|
+ user.bind(PW_DM)
|
|
+ # Error log
|
|
+ import_task = ImportTask(inst)
|
|
+ import_task.import_suffix_from_ldif(ldiffile="/not/here",
|
|
+ suffix=DEFAULT_SUFFIX)
|
|
+
|
|
+ # Wait a minute and make sure the server did not crash
|
|
+ log.info("Sleep until logs are flushed and rotated")
|
|
+ time.sleep(61)
|
|
+
|
|
+ assert inst.status()
|
|
+
|
|
+
|
|
+if __name__ == '__main__':
|
|
+ # Run isolated
|
|
+ # -s for DEBUG mode
|
|
+ CURRENT_FILE = os.path.realpath(__file__)
|
|
+ pytest.main(["-s", CURRENT_FILE])
|
|
+
|
|
diff --git a/ldap/servers/slapd/log.c b/ldap/servers/slapd/log.c
|
|
index 76f2b6768..7e2c980a4 100644
|
|
--- a/ldap/servers/slapd/log.c
|
|
+++ b/ldap/servers/slapd/log.c
|
|
@@ -6746,6 +6746,23 @@ log_refresh_state(int32_t log_type)
|
|
return 0;
|
|
}
|
|
}
|
|
+static LOGFD
|
|
+log_refresh_fd(int32_t log_type)
|
|
+{
|
|
+ switch (log_type) {
|
|
+ case SLAPD_ACCESS_LOG:
|
|
+ return loginfo.log_access_fdes;
|
|
+ case SLAPD_SECURITY_LOG:
|
|
+ return loginfo.log_security_fdes;
|
|
+ case SLAPD_AUDIT_LOG:
|
|
+ return loginfo.log_audit_fdes;
|
|
+ case SLAPD_AUDITFAIL_LOG:
|
|
+ return loginfo.log_auditfail_fdes;
|
|
+ case SLAPD_ERROR_LOG:
|
|
+ return loginfo.log_error_fdes;
|
|
+ }
|
|
+ return NULL;
|
|
+}
|
|
|
|
/* this function assumes the lock is already acquired */
|
|
/* if sync_now is non-zero, data is flushed to physical storage */
|
|
@@ -6857,6 +6874,7 @@ log_flush_buffer(LogBufferInfo *lbi, int log_type, int sync_now, int locked)
|
|
rotationtime_secs);
|
|
}
|
|
log_state = log_refresh_state(log_type);
|
|
+ fd = log_refresh_fd(log_type);
|
|
}
|
|
|
|
if (log_state & LOGGING_NEED_TITLE) {
|
|
--
|
|
2.48.0
|
|
|