184 lines
		
	
	
		
			8.6 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			184 lines
		
	
	
		
			8.6 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From patchwork Wed Oct  2 14:43:18 2019
 | 
						|
Content-Type: text/plain; charset="utf-8"
 | 
						|
MIME-Version: 1.0
 | 
						|
Content-Transfer-Encoding: 7bit
 | 
						|
X-Patchwork-Submitter: Thierry Reding <thierry.reding@gmail.com>
 | 
						|
X-Patchwork-Id: 11171225
 | 
						|
Return-Path: 
 | 
						|
 <SRS0=hIqC=X3=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org>
 | 
						|
Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org
 | 
						|
 [172.30.200.123])
 | 
						|
	by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C771E1747
 | 
						|
	for <patchwork-linux-arm@patchwork.kernel.org>;
 | 
						|
 Wed,  2 Oct 2019 14:45:14 +0000 (UTC)
 | 
						|
Received: from bombadil.infradead.org (bombadil.infradead.org
 | 
						|
 [198.137.202.133])
 | 
						|
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 | 
						|
	(No client certificate requested)
 | 
						|
	by mail.kernel.org (Postfix) with ESMTPS id 9703B21D81
 | 
						|
	for <patchwork-linux-arm@patchwork.kernel.org>;
 | 
						|
 Wed,  2 Oct 2019 14:45:14 +0000 (UTC)
 | 
						|
Authentication-Results: mail.kernel.org;
 | 
						|
	dkim=pass (2048-bit key) header.d=lists.infradead.org
 | 
						|
 header.i=@lists.infradead.org header.b="LCP5OdWP";
 | 
						|
	dkim=fail reason="signature verification failed" (2048-bit key)
 | 
						|
 header.d=gmail.com header.i=@gmail.com header.b="ahoJ80fO"
 | 
						|
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9703B21D81
 | 
						|
Authentication-Results: mail.kernel.org;
 | 
						|
 dmarc=fail (p=none dis=none) header.from=gmail.com
 | 
						|
Authentication-Results: mail.kernel.org;
 | 
						|
 spf=none
 | 
						|
 smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
 | 
						|
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 | 
						|
	d=lists.infradead.org; s=bombadil.20170209; h=Sender:
 | 
						|
	Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:
 | 
						|
	List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To
 | 
						|
	:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:
 | 
						|
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:
 | 
						|
	List-Owner; bh=csIWPoJz7RR9msf1imaCNOLXiDPcaRmxRKjOL8gMaXM=; b=LCP5OdWPpIBxJz
 | 
						|
	tSNffGBZI2pwLSarAvmqKIowLW5LghNe3CVQh7HM3sIR+IqrUtTSXi/0EEQAQORrYHSnR4zrDlubl
 | 
						|
	8IIqIetbgOrEmYRpHQxWZV/Z0p5JTdvNVeOiR63CuFbjz/h9UXPWOiLZijU1eZfSN2UuEJWxzoWMF
 | 
						|
	CsXxW+3rZ3os8AAa9x0lt6gGLwAPEPrxP44q4AJTVp3q+cD7GTXHu0F2ZT2flxES+cFF2/cPg2GiM
 | 
						|
	yR5j7GNMDhdxFKjGp8qcDhfCKx/0jF0DofnC4JsVlN0R25HdwYHzdHhysk8ca7JxLIMJlgXsgM5aY
 | 
						|
	4XUIEB/0CjoPtdbP+8yw==;
 | 
						|
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
 | 
						|
	by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux))
 | 
						|
	id 1iFfsO-0006Nf-SR; Wed, 02 Oct 2019 14:45:12 +0000
 | 
						|
Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443])
 | 
						|
 by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux))
 | 
						|
 id 1iFfqd-0003rK-EL
 | 
						|
 for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2019 14:43:47 +0000
 | 
						|
Received: by mail-wr1-x443.google.com with SMTP id w12so19991081wro.5
 | 
						|
 for <linux-arm-kernel@lists.infradead.org>;
 | 
						|
 Wed, 02 Oct 2019 07:43:21 -0700 (PDT)
 | 
						|
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 | 
						|
 h=from:to:cc:subject:date:message-id:mime-version
 | 
						|
 :content-transfer-encoding;
 | 
						|
 bh=y9l/1MkRoZLCyZNPXaR5fzwvTbuyIzYA20JLtWuhYR4=;
 | 
						|
 b=ahoJ80fONPxwQPqvbuQRAba40syj0YJFK3SbqTxd0FOzhs1n3WTvNd/gHQ+2WK5WwB
 | 
						|
 8joqipXveUGBgePR1RwHR0oQyDAumewRmSMStvhyCHPeo154CNqZfGQNlbNlRng2QJqd
 | 
						|
 1/Sq8GNJ1DjcLifpHWbCC9LoK5U3UkvdIWHPFx0cqJ+ENvPHkYPr2FdpaZ8jxuJta3TT
 | 
						|
 dplkNk0AsL/tc33KBJbKUSlnYppX878WQXUvnhdB+TRmr5R3dtc5Ewc0TH4h7V1SXTly
 | 
						|
 GiNnbbCc+BKzzqk9PTo/Pqf5dzWcpNDBA1GUkzQZDTXOXXUzBjnlrTaQctjSdE6meWfJ
 | 
						|
 JbDw==
 | 
						|
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 | 
						|
 d=1e100.net; s=20161025;
 | 
						|
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 | 
						|
 :content-transfer-encoding;
 | 
						|
 bh=y9l/1MkRoZLCyZNPXaR5fzwvTbuyIzYA20JLtWuhYR4=;
 | 
						|
 b=m4CouDn44ioMScPU+9h/V5vlxCAt0m4CSZKRu3pcsThkHE6u1TeKieaoBr1mh1qnIv
 | 
						|
 YS+V9Cd7osJa8R8USg+SJkEaSSarOn4kUq2MPTgMMmvKb63SSCCs0QD44nwEBAjIgMd/
 | 
						|
 /akFUOMTGQBnN7P8Iq3KWI00bVJLeoVWmqtQPkLFI1cIRrkCKTF4jh6b+i6xsiT8t2rd
 | 
						|
 l6WPsWnKkqUmPAqzpmLJ9bmSsiGBBFUexUJDcQnskkx6tTBzFhyNtpsbq6VdcY2mS3LR
 | 
						|
 rgGbisZRFdLvdZfGhmPX1hRgDoiHQLuWNAv49LtJtR7/CjNFmsKr4MBg1ydz0uO01Axr
 | 
						|
 zoIQ==
 | 
						|
X-Gm-Message-State: APjAAAXPZ9a+CEGZKeL6T+FXZoBRFrxryg3xujpPFnNpjznB8ehsaTI0
 | 
						|
 P6wL6cWqK9IRnS17Y/YRAb4=
 | 
						|
X-Google-Smtp-Source: 
 | 
						|
 APXvYqyETp8FIXhzzDrv+mhfzHhU0D9h3bcpLQ9oRbkEYPG7JvxLk5RVWx/ooYmku2+exI6oXsHTnA==
 | 
						|
X-Received: by 2002:a5d:4dd0:: with SMTP id f16mr2905889wru.85.1570027400467;
 | 
						|
 Wed, 02 Oct 2019 07:43:20 -0700 (PDT)
 | 
						|
Received: from localhost (p2E5BE2CE.dip0.t-ipconnect.de. [46.91.226.206])
 | 
						|
 by smtp.gmail.com with ESMTPSA id z125sm10251381wme.37.2019.10.02.07.43.19
 | 
						|
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 | 
						|
 Wed, 02 Oct 2019 07:43:19 -0700 (PDT)
 | 
						|
From: Thierry Reding <thierry.reding@gmail.com>
 | 
						|
To: Lee Jones <lee.jones@linaro.org>
 | 
						|
Subject: [PATCH] mfd: max77620: Do not allocate IRQs upfront
 | 
						|
Date: Wed,  2 Oct 2019 16:43:18 +0200
 | 
						|
Message-Id: <20191002144318.140365-1-thierry.reding@gmail.com>
 | 
						|
X-Mailer: git-send-email 2.23.0
 | 
						|
MIME-Version: 1.0
 | 
						|
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
 | 
						|
X-CRM114-CacheID: sfid-20191002_074330_018855_CC323A91 
 | 
						|
X-CRM114-Status: GOOD (  11.81  )
 | 
						|
X-Spam-Score: -0.2 (/)
 | 
						|
X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary:
 | 
						|
 Content analysis details:   (-0.2 points)
 | 
						|
 pts rule name              description
 | 
						|
 ---- ----------------------
 | 
						|
 --------------------------------------------------
 | 
						|
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 | 
						|
 no trust [2a00:1450:4864:20:0:0:0:443 listed in]
 | 
						|
 [list.dnswl.org]
 | 
						|
 -0.0 SPF_PASS               SPF: sender matches SPF record
 | 
						|
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 | 
						|
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 | 
						|
 provider (thierry.reding[at]gmail.com)
 | 
						|
 -0.1 DKIM_VALID_EF          Message has a valid DKIM or DK signature from
 | 
						|
 envelope-from domain
 | 
						|
 0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
 | 
						|
 not necessarily
 | 
						|
 valid
 | 
						|
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from
 | 
						|
 author's domain
 | 
						|
 -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
 | 
						|
X-BeenThere: linux-arm-kernel@lists.infradead.org
 | 
						|
X-Mailman-Version: 2.1.29
 | 
						|
Precedence: list
 | 
						|
List-Id: <linux-arm-kernel.lists.infradead.org>
 | 
						|
List-Unsubscribe: 
 | 
						|
 <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 | 
						|
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
 | 
						|
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
 | 
						|
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
 | 
						|
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
 | 
						|
List-Subscribe: 
 | 
						|
 <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 | 
						|
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
 | 
						|
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
 | 
						|
 linux-arm-kernel@lists.infradead.org
 | 
						|
Content-Type: text/plain; charset="us-ascii"
 | 
						|
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
 | 
						|
Errors-To: 
 | 
						|
 linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
 | 
						|
 | 
						|
From: Thierry Reding <treding@nvidia.com>
 | 
						|
 | 
						|
regmap_add_irq_chip() will try to allocate all of the IRQ descriptors
 | 
						|
upfront if passed a non-zero irq_base parameter. However, the intention
 | 
						|
is to allocate IRQ descriptors on an as-needed basis if possible. Pass 0
 | 
						|
instead of -1 to fix that use-case.
 | 
						|
 | 
						|
Signed-off-by: Thierry Reding <treding@nvidia.com>
 | 
						|
---
 | 
						|
 drivers/mfd/max77620.c       | 5 ++---
 | 
						|
 include/linux/mfd/max77620.h | 1 -
 | 
						|
 2 files changed, 2 insertions(+), 4 deletions(-)
 | 
						|
 | 
						|
diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
 | 
						|
index a851ff473a44..c7ed5c353553 100644
 | 
						|
--- a/drivers/mfd/max77620.c
 | 
						|
+++ b/drivers/mfd/max77620.c
 | 
						|
@@ -507,7 +507,6 @@ static int max77620_probe(struct i2c_client *client,
 | 
						|
 
 | 
						|
 	i2c_set_clientdata(client, chip);
 | 
						|
 	chip->dev = &client->dev;
 | 
						|
-	chip->irq_base = -1;
 | 
						|
 	chip->chip_irq = client->irq;
 | 
						|
 	chip->chip_id = (enum max77620_chip_id)id->driver_data;
 | 
						|
 
 | 
						|
@@ -545,8 +544,8 @@ static int max77620_probe(struct i2c_client *client,
 | 
						|
 
 | 
						|
 	max77620_top_irq_chip.irq_drv_data = chip;
 | 
						|
 	ret = devm_regmap_add_irq_chip(chip->dev, chip->rmap, client->irq,
 | 
						|
-				       IRQF_ONESHOT | IRQF_SHARED,
 | 
						|
-				       chip->irq_base, &max77620_top_irq_chip,
 | 
						|
+				       IRQF_ONESHOT | IRQF_SHARED, 0,
 | 
						|
+				       &max77620_top_irq_chip,
 | 
						|
 				       &chip->top_irq_data);
 | 
						|
 	if (ret < 0) {
 | 
						|
 		dev_err(chip->dev, "Failed to add regmap irq: %d\n", ret);
 | 
						|
diff --git a/include/linux/mfd/max77620.h b/include/linux/mfd/max77620.h
 | 
						|
index 12ba157cb83f..f552ef5b1100 100644
 | 
						|
--- a/include/linux/mfd/max77620.h
 | 
						|
+++ b/include/linux/mfd/max77620.h
 | 
						|
@@ -329,7 +329,6 @@ struct max77620_chip {
 | 
						|
 	struct regmap *rmap;
 | 
						|
 
 | 
						|
 	int chip_irq;
 | 
						|
-	int irq_base;
 | 
						|
 
 | 
						|
 	/* chip id */
 | 
						|
 	enum max77620_chip_id chip_id;
 |