kzhukov/albs-oval-errata-diff
1
0
Fork 0
Code Issues Pull Requests Releases Activity

ALBS-931 Added integration with AlmaLinux Build System (errata feed) #3

Merged
kzhukov merged 4 commits from ALBS-931 into main 2023-01-20 11:49:11 +00:00
Conversation 0 Commits 4 Files Changed 6 +143 -13
kzhukov commented 2023-01-19 12:24:43 +00:00
Owner
Copy Link
No description provided.
kzhukov added 1 commit 2023-01-19 12:24:44 +00:00
soksanichenko requested changes 2023-01-19 12:41:50 +00:00
albs_oval_errata_diff/albs.py
@ -0,0 +12,4 @@
"""
def __init__(self, url: str, token: str, timeout: int):
if url.endswith('/'):
soksanichenko commented 2023-01-19 12:36:32 +00:00
First-time contributor
Copy Link

It's not necessary if you fix comments below.

It's not necessary if you fix comments below.
kzhukov marked this conversation as resolved
albs_oval_errata_diff/albs.py
@ -0,0 +27,4 @@
endpoint = '/api/v1/platforms/'
headers = {'accept': 'application/json',
'Authorization': f'Bearer {self.token}'}
response = requests.get(url=self.url+endpoint,
soksanichenko commented 2023-01-19 12:38:42 +00:00
First-time contributor
Copy Link

self.url+endpoint don't do the same, please :)

from urllib.parse import urljoin
urljoin(url + '/', some_uri)

That code join part of an URL right in all cases

`self.url+endpoint` don't do the same, please :) ``` from urllib.parse import urljoin urljoin(url + '/', some_uri) ``` That code join part of an URL right in all cases
kzhukov marked this conversation as resolved
albs_oval_errata_diff/albs.py Outdated
@ -0,0 +31,4 @@
headers=headers,
timeout=self.timeout)
response.raise_for_status()
res = {}
soksanichenko commented 2023-01-19 12:40:02 +00:00
First-time contributor
Copy Link

That looks more pretty I guess

res = {platform['name']: platform['id'] for platform in response.json()}
That looks more pretty I guess ``` res = {platform['name']: platform['id'] for platform in response.json()} ```
albs_oval_errata_diff/albs.py
@ -0,0 +60,4 @@
params = {'id': errata_id, 'platformId': platform_id}
headers = {'accept': 'application/json',
'Authorization': f'Bearer {self.token}'}
response = requests.get(url=self.url+endpoint,
soksanichenko commented 2023-01-19 12:40:29 +00:00
First-time contributor
Copy Link

same as above

same as above
kzhukov marked this conversation as resolved
albs_oval_errata_diff/albs.py Outdated
@ -0,0 +68,4 @@
# errata_id was not found
if response_json['total_records'] == 0:
return None
soksanichenko commented 2023-01-19 12:41:11 +00:00
First-time contributor
Copy Link

jfyi, return None is redundunt form of return

jfyi, `return None` is redundunt form of `return`
Korulag approved these changes 2023-01-19 12:52:05 +00:00
kzhukov added 1 commit 2023-01-19 21:13:16 +00:00
kzhukov added 1 commit 2023-01-19 21:15:57 +00:00
soksanichenko approved these changes 2023-01-20 11:14:37 +00:00
kzhukov added 1 commit 2023-01-20 11:41:54 +00:00
kzhukov merged commit e5f23da079 into main 2023-01-20 11:49:11 +00:00
kzhukov deleted branch ALBS-931 2023-01-20 11:49:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Korulag
soksanichenko
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kzhukov/albs-oval-errata-diff#3
No description provided.
Delete Branch "ALBS-931"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?