From e5f783d5529157f689df56d6f43aa7151fb25748 Mon Sep 17 00:00:00 2001 From: Clemens Lang Date: Thu, 16 Mar 2023 14:08:53 +0100 Subject: [PATCH] Fix Wpointer-sign compiler warning ``` providers/implementations/signature/ecdsa_sig.c: scope_hint: In function 'do_ec_pct' providers/implementations/signature/ecdsa_sig.c:594:46: warning[-Wpointer-sign]: pointer targets in passing argument 2 of 'ecdsa_digest_signverify_update' differ in signedness providers/implementations/signature/ecdsa_sig.c:325:69: note: expected 'const unsigned char *' but argument is of type 'const char *' ``` ``` providers/implementations/signature/rsa_sig.c: scope_hint: In function 'do_rsa_pct' providers/implementations/signature/rsa_sig.c:1518:44: warning[-Wpointer-sign]: pointer targets in passing argument 2 of 'rsa_digest_signverify_update' differ in signedness providers/implementations/signature/rsa_sig.c:910:62: note: expected 'const unsigned char *' but argument is of type 'const char *' ``` Resolves: rhbz#2178034 Signed-off-by: Clemens Lang --- 0044-FIPS-140-3-keychecks.patch | 4 ++-- openssl.spec | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/0044-FIPS-140-3-keychecks.patch b/0044-FIPS-140-3-keychecks.patch index 6b77eb4..38efa07 100644 --- a/0044-FIPS-140-3-keychecks.patch +++ b/0044-FIPS-140-3-keychecks.patch @@ -190,7 +190,7 @@ diff -up openssl-3.0.7/providers/implementations/signature/ecdsa_sig.c.pairwise +#ifdef FIPS_MODULE +int do_ec_pct(void *vctx, const char *mdname, void *ec) +{ -+ static const char data[32]; ++ static const unsigned char data[32]; + unsigned char sigbuf[256]; + size_t siglen = sizeof(sigbuf); + @@ -321,7 +321,7 @@ diff -up openssl-3.0.7/providers/implementations/signature/rsa_sig.c.pairwise op +#ifdef FIPS_MODULE +int do_rsa_pct(void *vctx, const char *mdname, void *rsa) +{ -+ static const char data[32]; ++ static const unsigned char data[32]; + unsigned char *sigbuf = NULL; + size_t siglen = 0; + int ret = 0; diff --git a/openssl.spec b/openssl.spec index 0440475..50a3bb4 100644 --- a/openssl.spec +++ b/openssl.spec @@ -29,7 +29,7 @@ print(string.sub(hash, 0, 16)) Summary: Utilities from the general purpose cryptography library with TLS implementation Name: openssl Version: 3.0.7 -Release: 7%{?dist} +Release: 8%{?dist} Epoch: 1 # We have to remove certain patented algorithms from the openssl source # tarball with the hobble-openssl script which is included below. @@ -505,6 +505,10 @@ install -m644 %{SOURCE9} \ %ldconfig_scriptlets libs %changelog +* Thu Mar 16 2023 Clemens Lang - 1:3.0.7-8 +- Fix Wpointer-sign compiler warning + Resolves: rhbz#2178034 + * Tue Mar 14 2023 Clemens Lang - 1:3.0.7-7 - Add explicit FIPS indicators to key derivation functions Resolves: rhbz#2175860 rhbz#2175864