forked from rpms/open-vm-tools
df1076857b
to fix CVE-2022-31676 in open-vm-tools 12.0.5 tracked in PR 120976. Correct build requirements - replace systemd-rpm-macros with systemd_udev.
37 lines
1.4 KiB
Diff
37 lines
1.4 KiB
Diff
From be635a7eaf7bd19177b7002aa2c793c78be77ecc Mon Sep 17 00:00:00 2001
|
|
From: John Wolfe <jwolfe@vmware.com>
|
|
Date: Wed, 10 Aug 2022 07:20:28 -0700
|
|
Subject: [PATCH] Properly check authorization on incoming guestOps requests
|
|
|
|
Fix public pipe request checks. Only a SessionRequest type should
|
|
be accepted on the public pipe.
|
|
---
|
|
open-vm-tools/vgauth/serviceImpl/proto.c | 6 +++++-
|
|
1 file changed, 5 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/open-vm-tools/vgauth/serviceImpl/proto.c b/open-vm-tools/vgauth/serviceImpl/proto.c
|
|
index db7159e..c4f85b0 100644
|
|
--- a/vgauth/serviceImpl/proto.c
|
|
+++ b/vgauth/serviceImpl/proto.c
|
|
@@ -1,5 +1,5 @@
|
|
/*********************************************************
|
|
- * Copyright (C) 2011-2016,2019-2021 VMware, Inc. All rights reserved.
|
|
+ * Copyright (c) 2011-2016,2019-2022 VMware, Inc. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU Lesser General Public License as published
|
|
@@ -1201,6 +1201,10 @@ Proto_SecurityCheckRequest(ServiceConnection *conn,
|
|
VGAuthError err;
|
|
gboolean isSecure = ServiceNetworkIsConnectionPrivateSuperUser(conn);
|
|
|
|
+ if (conn->isPublic && req->reqType != PROTO_REQUEST_SESSION_REQ) {
|
|
+ return VGAUTH_E_PERMISSION_DENIED;
|
|
+ }
|
|
+
|
|
switch (req->reqType) {
|
|
/*
|
|
* This comes over the public connection; alwsys let it through.
|
|
--
|
|
2.6.2
|
|
|