From c55679b84895175043a9123a7e256ce426508a32 Mon Sep 17 00:00:00 2001 From: Yaakov Selkowitz Date: Tue, 18 Mar 2025 15:07:32 -0400 Subject: [PATCH] Fix build with GCC 15 GCC 15 defaults to C23, in which the interpretation of function declarations without parameters has changed from unspecified (as in K&R) to `void`. This fix has been accepted upstream. https://github.com/vmware/open-vm-tools/pull/751 --- 751.patch | 23 +++++++++++++++++++++++ open-vm-tools.spec | 2 ++ 2 files changed, 25 insertions(+) create mode 100644 751.patch diff --git a/751.patch b/751.patch new file mode 100644 index 0000000..4529fca --- /dev/null +++ b/751.patch @@ -0,0 +1,23 @@ +From 129d87bd5fd5f2436a467d4b7d43e0d102a867da Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum +Date: Wed, 20 Nov 2024 10:40:03 +1100 +Subject: [PATCH] Fix build when compiling with -std=c23 + +Fixes the build when using gcc 15 +--- + open-vm-tools/lib/lock/ul.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/open-vm-tools/lib/lock/ul.c b/open-vm-tools/lib/lock/ul.c +index d376a98af..fc9fdb714 100644 +--- a/open-vm-tools/lib/lock/ul.c ++++ b/open-vm-tools/lib/lock/ul.c +@@ -29,7 +29,7 @@ + static Bool mxInPanic = FALSE; // track when involved in a panic + static Bool mxUserCollectLockingTree = FALSE; + +-Bool (*MXUserTryAcquireForceFail)() = NULL; ++Bool (*MXUserTryAcquireForceFail)(const char *) = NULL; + + static MX_Rank (*MXUserMxCheckRank)(void) = NULL; + static void (*MXUserMxLockLister)(void) = NULL; diff --git a/open-vm-tools.spec b/open-vm-tools.spec index 31e7396..801a4c6 100644 --- a/open-vm-tools.spec +++ b/open-vm-tools.spec @@ -78,6 +78,8 @@ ExclusiveArch: %{ix86} x86_64 aarch64 # Patches #Patch0: .patch +# Fix build when compiling with -std=c23 (GCC 15) +Patch1: https://github.com/vmware/open-vm-tools/pull/751.patch BuildRequires: autoconf BuildRequires: automake