forked from rpms/libvirt
Import from CS git
This commit is contained in:
parent
daae142f13
commit
0c3db8e72e
@ -0,0 +1,51 @@
|
|||||||
|
From afbf59c823a04b417b4ae66edb99e15e6e8ba877 Mon Sep 17 00:00:00 2001
|
||||||
|
Message-ID: <afbf59c823a04b417b4ae66edb99e15e6e8ba877.1730898528.git.jdenemar@redhat.com>
|
||||||
|
From: Peter Krempa <pkrempa@redhat.com>
|
||||||
|
Date: Tue, 8 Aug 2023 15:53:53 +0200
|
||||||
|
Subject: [PATCH] virStorageBackendLogicalCheckPool: Properly mark empty
|
||||||
|
logical pools as active
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
The '/dev' filesystem convenience directory for a LVM volume group is
|
||||||
|
not created when the volume group is empty.
|
||||||
|
|
||||||
|
The logic in 'virStorageBackendLogicalCheckPool' which is used to see
|
||||||
|
whether a pool is active was first checking presence of the directory,
|
||||||
|
which failed for an empty VG.
|
||||||
|
|
||||||
|
Since the second step is virStorageBackendLogicalMatchPoolSource which
|
||||||
|
is checking mapping between configured PVs and the VG, we can simply
|
||||||
|
rely on the function to also check presence of the pool.
|
||||||
|
|
||||||
|
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2228223
|
||||||
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
||||||
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
||||||
|
(cherry picked from commit fa1a54baa59d244289ce666f9dc52d9eabca47f1)
|
||||||
|
https://issues.redhat.com/browse/RHEL-65771
|
||||||
|
---
|
||||||
|
src/storage/storage_backend_logical.c | 8 +-------
|
||||||
|
1 file changed, 1 insertion(+), 7 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
|
||||||
|
index 3f27e63aeb..b7e3ba2498 100644
|
||||||
|
--- a/src/storage/storage_backend_logical.c
|
||||||
|
+++ b/src/storage/storage_backend_logical.c
|
||||||
|
@@ -628,13 +628,7 @@ static int
|
||||||
|
virStorageBackendLogicalCheckPool(virStoragePoolObj *pool,
|
||||||
|
bool *isActive)
|
||||||
|
{
|
||||||
|
- virStoragePoolDef *def = virStoragePoolObjGetDef(pool);
|
||||||
|
-
|
||||||
|
- /* If we can find the target.path as well as ensure that the
|
||||||
|
- * pool's def source
|
||||||
|
- */
|
||||||
|
- *isActive = virFileExists(def->target.path) &&
|
||||||
|
- virStorageBackendLogicalMatchPoolSource(pool);
|
||||||
|
+ *isActive = virStorageBackendLogicalMatchPoolSource(pool);
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
--
|
||||||
|
2.47.0
|
@ -210,7 +210,7 @@
|
|||||||
Summary: Library providing a simple virtualization API
|
Summary: Library providing a simple virtualization API
|
||||||
Name: libvirt
|
Name: libvirt
|
||||||
Version: 8.0.0
|
Version: 8.0.0
|
||||||
Release: 23.2%{?dist}%{?extra_release}
|
Release: 23.3%{?dist}%{?extra_release}
|
||||||
License: LGPLv2+
|
License: LGPLv2+
|
||||||
URL: https://libvirt.org/
|
URL: https://libvirt.org/
|
||||||
|
|
||||||
@ -321,6 +321,7 @@ Patch98: libvirt-virnuma-Avoid-integer-overflow-in-virNumaGetPages.patch
|
|||||||
Patch99: libvirt-remote-check-for-negative-array-lengths-before-allocation.patch
|
Patch99: libvirt-remote-check-for-negative-array-lengths-before-allocation.patch
|
||||||
Patch100: libvirt-util-Fix-error-return-for-virProcessKillPainfullyDelay.patch
|
Patch100: libvirt-util-Fix-error-return-for-virProcessKillPainfullyDelay.patch
|
||||||
Patch101: libvirt-rpc-ensure-temporary-GSource-is-removed-from-client-event-loop.patch
|
Patch101: libvirt-rpc-ensure-temporary-GSource-is-removed-from-client-event-loop.patch
|
||||||
|
Patch102: libvirt-virStorageBackendLogicalCheckPool-Properly-mark-empty-logical-pools-as-active.patch
|
||||||
|
|
||||||
Requires: libvirt-daemon = %{version}-%{release}
|
Requires: libvirt-daemon = %{version}-%{release}
|
||||||
Requires: libvirt-daemon-config-network = %{version}-%{release}
|
Requires: libvirt-daemon-config-network = %{version}-%{release}
|
||||||
@ -2200,6 +2201,9 @@ exit 0
|
|||||||
|
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Wed Nov 6 2024 Jiri Denemark <jdenemar@redhat.com> - 8.0.0-23.3.el8
|
||||||
|
- virStorageBackendLogicalCheckPool: Properly mark empty logical pools as active (RHEL-65771)
|
||||||
|
|
||||||
* Thu Jun 6 2024 Jiri Denemark <jdenemar@redhat.com> - 8.0.0-23.2.el8
|
* Thu Jun 6 2024 Jiri Denemark <jdenemar@redhat.com> - 8.0.0-23.2.el8
|
||||||
- util: Fix error return for virProcessKillPainfullyDelay() (RHEL-36064)
|
- util: Fix error return for virProcessKillPainfullyDelay() (RHEL-36064)
|
||||||
- rpc: ensure temporary GSource is removed from client event loop (CVE-2024-4418)
|
- rpc: ensure temporary GSource is removed from client event loop (CVE-2024-4418)
|
||||||
|
Loading…
Reference in New Issue
Block a user