From a065674efffa41fa0f1a91f18c4a8dd77f7699cb Mon Sep 17 00:00:00 2001
From: 0xC4aE1e5 <charles4@no-reply@disroot.org>
Date: Sun, 18 Aug 2024 18:30:24 -0700
Subject: [PATCH] Remove a permission, document justifications

---
 .idea/gradle.xml                                         | 1 +
 .idea/misc.xml                                           | 1 -
 .../main/java/to/us/charlesst/discord/MainActivity.kt    | 9 ++++-----
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/.idea/gradle.xml b/.idea/gradle.xml
index 32522c1..0897082 100644
--- a/.idea/gradle.xml
+++ b/.idea/gradle.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
+  <component name="GradleMigrationSettings" migrationVersion="1" />
   <component name="GradleSettings">
     <option name="linkedExternalProjectsSettings">
       <GradleProjectSettings>
diff --git a/.idea/misc.xml b/.idea/misc.xml
index 0ad17cb..8978d23 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
   <component name="ExternalStorageConfigurationManager" enabled="true" />
   <component name="ProjectRootManager" version="2" languageLevel="JDK_17" default="true" project-jdk-name="jbr-17" project-jdk-type="JavaSDK">
diff --git a/app/src/main/java/to/us/charlesst/discord/MainActivity.kt b/app/src/main/java/to/us/charlesst/discord/MainActivity.kt
index 2db1bba..512368d 100644
--- a/app/src/main/java/to/us/charlesst/discord/MainActivity.kt
+++ b/app/src/main/java/to/us/charlesst/discord/MainActivity.kt
@@ -12,13 +12,12 @@ class MainActivity : AppCompatActivity() {
                 super.onCreate(savedInstanceState)
                 setContentView(R.layout.activity_main)
                 val webView: WebView = findViewById(R.id.webview)
-                CookieManager.getInstance().setAcceptCookie(true)
+                CookieManager.getInstance().setAcceptCookie(true) // for Cloudflare
                 val webSettings: WebSettings = webView.getSettings()
-                webView.settings.javaScriptEnabled = true
+                webView.settings.javaScriptEnabled = true // for obvious reasons, Discord is a JS-heavy app
                 webView.webViewClient = WebViewClient()
-                webView.settings.userAgentString = "Android/10.0 (compatible; Charles Discord webapp wrapper)"
-                webView.settings.mixedContentMode = WebSettings.MIXED_CONTENT_ALWAYS_ALLOW
-                webSettings.setDomStorageEnabled(true)
+                webView.settings.userAgentString = "Android/10.0 (compatible; Charles Discord webapp wrapper)" // prevent fingerprinting by user-agent, also prevents being detected as very old Android version
+                webSettings.setDomStorageEnabled(true) // seems to be needed for login
                 webView.loadUrl("https://discord.com/app")
     }
 }
\ No newline at end of file