favorite-apps was set in persistant config for qa-testday, but only for
the live enviroment in live-desktop. The latter happens later since it
happens at run time, not build time. So a new section was added to
do a runtime override as well so the the qa-testday favorites are used
both in the live environment and after a test install.
Both qa-testday.ks and fedora-live-desktop.ks were trying to modify
/usr/share/glib-2.0/schemas/org.gnome.shell.qa-testday.gschema.override
by appending to the end of it. However, even though fedora-live-desktop.ks
was %included at the start of qa-testday.ks, the %post section from
fedora-live-desktop.ks was run second, so that its favorite-apps setting
was taking prference.
So I am going back to including a vender string in the name of the
override file. This seems to result in the config from qa-testday.ks
taking precedence. But I don't know if this is based on alphabetic
ordering by filename or just random happenstance. I have a question
pending on the kickstart list to see if I can get more information
on %post ordering.
It looks like the override for favorites working depending on the
override file from qa-testday being processed after that from
live-desktop. It worked in testing, but might not work later.
So instead use append and the same name. This will put the qa-testday
definition after the live-desktop one in the same file.
For some reason I don't know right now, the installed liveinst.desktop
gets renamed to anaconda.desktop in live-base. So until I know if that
should really be done differently, I'm adding a local one.