From 4a6850e465f0d17841a4794ac3ed67f0a30345f6 Mon Sep 17 00:00:00 2001
From: Dusty Mabe <dusty@dustymabe.com>
Date: Wed, 2 Sep 2020 17:10:07 -0400
Subject: [PATCH] cloud: rework package list, add comments

This reworks the package list to add comments and remove some things
that didn't need to be explicitly removed.

- remove +systemd-udev -> already included by default
- remove -biosdevname -> not included by default
- remove -iprutils -> not included by default
- remove -uboot-tools -> not included by default

There are no packages added or removed from the built cloud image as
part of this change. Just updating the input package list to be more
meaningful.
---
 fedora-cloud-base.ks | 37 ++++++++++++++++---------------------
 1 file changed, 16 insertions(+), 21 deletions(-)

diff --git a/fedora-cloud-base.ks b/fedora-cloud-base.ks
index 8a5f453..0a7d13f 100644
--- a/fedora-cloud-base.ks
+++ b/fedora-cloud-base.ks
@@ -44,38 +44,33 @@ autopart --noboot --nohome --noswap --nolvm
 
 reboot
 
-# Package list.
+##### begin package list #############################################
 %packages --instLangs=en
 
-kernel-core
+# Include packages for the cloud-server-environment group
 @^cloud-server-environment
-# Need to pull in the udev subpackage
-systemd-udev
 
-# after move away from grub2 - let's add 'which' back
-which
+# Don't include the kernel toplevel package since it pulls in
+# kernel-modules. We're happy for now with kernel-core.
+-kernel
+kernel-core
 
-# rescue mode generally isn't useful in the cloud context
+# Don't include dracut-config-rescue. It will have dracut generate a
+# "rescue" entry in the grub menu, but that also means there is a
+# rescue kernel and initramfs that get created, which (currently) add
+# about another 40MiB to the /boot/ partition. Also the "rescue" mode
+# is generally not useful in the cloud.
 -dracut-config-rescue
 
-# Some things from @core we can do without in a minimal install
--biosdevname
-# Need to also add back plymouth in order to mask failure of
-# systemd-vconsole-setup.service. BZ#1272684. Comment out for now
-#-plymouth
--iprutils
-# Now that BZ#1199868 is fixed kbd really gets removed but it breaks
-# systemd-vconsole-setup.service on boot. Comment out for now
-#-kbd
--uboot-tools
--kernel
-# No need for plymouth. Also means anaconda won't put rhgb/quiet
-# on kernel command line
+# Plymouth provides a graphical boot animation. In the cloud we don't
+# need a graphical boot animation. This also means anaconda won't put
+# rhgb/quiet on kernel command line
 -plymouth
+
 # noswap on Cloud for now
 -zram-generator-defaults
-
 %end
+##### end package list ###############################################