autopatch/gnome-shell
5
0
Fork 0
Code Issues Pull Requests Releases Activity

fix(autopatch): Replaced obsolete action targeting dict-style string in gnome-shell-favourite-apps-firefox.patch with action targeting o #1

Merged
eabdullin merged 1 commits from agent-fix/a10-20260522-073316 into a10 2026-05-22 07:39:11 +00:00
Conversation 0 Commits 1 Files Changed 1 +3 -3
eabdullin commented 2026-05-22 07:33:17 +00:00
Owner
Copy Link

Automated fix by autopatch agent.

Summary: Replaced obsolete action targeting dict-style string in gnome-shell-favourite-apps-firefox.patch with action targeting org.mozilla.Firefox.desktop in gnome-shell-favourite-apps-terminal.patch, matching the fix already present in the a10s reference branch.

Root cause

The upstream c10 gnome-shell-favourite-apps-firefox.patch was updated to use a plain dash.txt format instead of the old Python-dict style. The old action 2 tried to find "'firefox.desktop': 'org.mozilla.firefox.desktop'," which no longer exists in that file. The reference branch (a10s) had already fixed this by replacing that action with one that targets gnome-shell-favourite-apps-terminal.patch, replacing the context-line reference 'org.mozilla.Firefox.desktop' with 'firefox.desktop'. Action 1 already handles the '+org.mozilla.Firefox.desktop' line in the firefox patch file.

Original error

Type: ActionNotAppliedError

Traceback (most recent call last):
  File "/root/autopatch-tool/src/webserv.py", line 77, in debrand_packages
    result = apply_modifications(
  File "/root/autopatch-tool/src/debranding.py", line 111, in apply_modifications
    config.apply_actions(rpms_working_dir + f"/{package}")
  File "/root/autopatch-tool/src/actions_handler.py", line 925, in apply_actions
    action.execute(Path(package_path))
  File "/root/autopatch-tool/src/actions_handler.py", line 472, in execute
    process_lines(
  File "/root/autopatch-tool/src/actions_handler.py", line 233, in process_lines
    raise ActionNotAppliedError(
actions_handler.ActionNotAppliedError: Action 'ReplaceAction' was not applied successfully: No changes made for '["'firefox.desktop': 'org.mozilla.firefox.desktop',"]' in /root/autopatch-tool/src/rpms-namespace/gnome-shell/gnome-shell-favourite-apps-firefox.patch

Package: gnome-shell | Webhook branch: c10

Automated fix by autopatch agent. **Summary:** Replaced obsolete action targeting dict-style string in gnome-shell-favourite-apps-firefox.patch with action targeting org.mozilla.Firefox.desktop in gnome-shell-favourite-apps-terminal.patch, matching the fix already present in the a10s reference branch. ### Root cause The upstream c10 gnome-shell-favourite-apps-firefox.patch was updated to use a plain dash.txt format instead of the old Python-dict style. The old action 2 tried to find "'firefox.desktop': 'org.mozilla.firefox.desktop'," which no longer exists in that file. The reference branch (a10s) had already fixed this by replacing that action with one that targets gnome-shell-favourite-apps-terminal.patch, replacing the context-line reference 'org.mozilla.Firefox.desktop' with 'firefox.desktop'. Action 1 already handles the '+org.mozilla.Firefox.desktop' line in the firefox patch file. ### Original error **Type:** `ActionNotAppliedError` ``` Traceback (most recent call last): File "/root/autopatch-tool/src/webserv.py", line 77, in debrand_packages result = apply_modifications( File "/root/autopatch-tool/src/debranding.py", line 111, in apply_modifications config.apply_actions(rpms_working_dir + f"/{package}") File "/root/autopatch-tool/src/actions_handler.py", line 925, in apply_actions action.execute(Path(package_path)) File "/root/autopatch-tool/src/actions_handler.py", line 472, in execute process_lines( File "/root/autopatch-tool/src/actions_handler.py", line 233, in process_lines raise ActionNotAppliedError( actions_handler.ActionNotAppliedError: Action 'ReplaceAction' was not applied successfully: No changes made for '["'firefox.desktop': 'org.mozilla.firefox.desktop',"]' in /root/autopatch-tool/src/rpms-namespace/gnome-shell/gnome-shell-favourite-apps-firefox.patch ``` --- Package: `gnome-shell` | Webhook branch: `c10`
eabdullin added 1 commit 2026-05-22 07:33:17 +00:00 
Replaced obsolete action targeting dict-style string in gnome-shell-favourite-apps-firefox.patch with action targeting org.mozilla.Firefox.desktop in gnome-shell-favourite-apps-terminal.patch, matchin
eabdullin merged commit b9d5e7405f into a10 2026-05-22 07:39:11 +00:00
eabdullin deleted branch agent-fix/a10-20260522-073316 2026-05-22 07:39:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: autopatch/gnome-shell#1
No description provided.
Delete Branch "agent-fix/a10-20260522-073316"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?