autopatch/fwupd
5
0
Fork 0
Code Issues Pull Requests Releases Activity

fix(autopatch): Removed obsolete delete_line/add_files/delete_files/sbat/pesign actions; kept efi_vendor inject; added sb_key replacemen #1

Merged
eabdullin merged 1 commits from agent-fix/a9-beta-20260413-074407 into a9-beta 2026-04-13 08:05:40 +00:00
Conversation 0 Commits 1 Files Changed 1 +2 -40
eabdullin commented 2026-04-13 07:44:09 +00:00
Owner
Copy Link

Automated fix by autopatch agent.

Summary: Removed obsolete delete_line/add_files/delete_files/sbat/pesign actions; kept efi_vendor inject; added sb_key replacement (redhatsecureboot802 → almalinuxsecureboot0)

Root cause

The upstream spec was significantly reworked: Source300/301/500/503 (Red Hat secure boot cert files) were removed in favour of system-provided certs via macros (%define sb_ca/%define sb_cer pointing to /usr/share/pki/sb-certs/). The double-pesign pattern and all sbat_distro_* meson options were also removed. The remaining Red Hat-specific value was %define sb_key redhatsecureboot802 (the NSS signing key name). The config was updated to: (1) remove the broken delete_line action, (2) remove now-obsolete add_files/delete_files cert source actions, (3) remove three broken replace actions (sbat_distro_* and old pesign pattern), (4) keep the %global efi_vendor/efidir/efi_esp_dir injection (still needed since line 286 uses %{efi_vendor}), and (5) add a new replace action to change redhatsecureboot802 to almalinuxsecureboot0.

Original error

Type: ActionNotAppliedError

Traceback (most recent call last):
  File "/root/autopatch-tool/src/webserv.py", line 77, in debrand_packages
    result = apply_modifications(
  File "/root/autopatch-tool/src/debranding.py", line 111, in apply_modifications
    config.apply_actions(rpms_working_dir + f"/{package}")
  File "/root/autopatch-tool/src/actions_handler.py", line 925, in apply_actions
    action.execute(Path(package_path))
  File "/root/autopatch-tool/src/actions_handler.py", line 795, in execute
    process_lines(file_path, entry.target, find_lines, "", -1)
  File "/root/autopatch-tool/src/actions_handler.py", line 233, in process_lines
    raise ActionNotAppliedError(
actions_handler.ActionNotAppliedError: Action 'DeleteAction' was not applied successfully: No changes made for '['Source300:   redhatsecurebootca3.cer', 'Source301:   redhatsecureboot301.cer', 'Source500:   redhatsecurebootca5.cer', 'Source503:   redhatsecureboot503.cer']' in /root/autopatch-tool/src/rpms-namespace/fwupd/SPECS/fwupd.spec

Package: fwupd | Webhook branch: c9-beta

Automated fix by autopatch agent. **Summary:** Removed obsolete delete_line/add_files/delete_files/sbat/pesign actions; kept efi_vendor inject; added sb_key replacement (redhatsecureboot802 → almalinuxsecureboot0) ### Root cause The upstream spec was significantly reworked: Source300/301/500/503 (Red Hat secure boot cert files) were removed in favour of system-provided certs via macros (%define sb_ca/%define sb_cer pointing to /usr/share/pki/sb-certs/). The double-pesign pattern and all sbat_distro_* meson options were also removed. The remaining Red Hat-specific value was %define sb_key redhatsecureboot802 (the NSS signing key name). The config was updated to: (1) remove the broken delete_line action, (2) remove now-obsolete add_files/delete_files cert source actions, (3) remove three broken replace actions (sbat_distro_* and old pesign pattern), (4) keep the %global efi_vendor/efidir/efi_esp_dir injection (still needed since line 286 uses %{efi_vendor}), and (5) add a new replace action to change redhatsecureboot802 to almalinuxsecureboot0. ### Original error **Type:** `ActionNotAppliedError` ``` Traceback (most recent call last): File "/root/autopatch-tool/src/webserv.py", line 77, in debrand_packages result = apply_modifications( File "/root/autopatch-tool/src/debranding.py", line 111, in apply_modifications config.apply_actions(rpms_working_dir + f"/{package}") File "/root/autopatch-tool/src/actions_handler.py", line 925, in apply_actions action.execute(Path(package_path)) File "/root/autopatch-tool/src/actions_handler.py", line 795, in execute process_lines(file_path, entry.target, find_lines, "", -1) File "/root/autopatch-tool/src/actions_handler.py", line 233, in process_lines raise ActionNotAppliedError( actions_handler.ActionNotAppliedError: Action 'DeleteAction' was not applied successfully: No changes made for '['Source300: redhatsecurebootca3.cer', 'Source301: redhatsecureboot301.cer', 'Source500: redhatsecurebootca5.cer', 'Source503: redhatsecureboot503.cer']' in /root/autopatch-tool/src/rpms-namespace/fwupd/SPECS/fwupd.spec ``` --- Package: `fwupd` | Webhook branch: `c9-beta`
eabdullin added 1 commit 2026-04-13 07:44:09 +00:00 
Removed obsolete delete_line/add_files/delete_files/sbat/pesign actions; kept efi_vendor inject; added sb_key replacement (redhatsecureboot802 → almalinuxsecureboot0)
eabdullin merged commit 3609869943 into a9-beta 2026-04-13 08:05:40 +00:00
eabdullin deleted branch agent-fix/a9-beta-20260413-074407 2026-04-13 08:05:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: autopatch/fwupd#1
No description provided.
Delete Branch "agent-fix/a9-beta-20260413-074407"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?